Re: RFR: 8314891: Additional Zip64 extra header validation [v8]

2024-05-13 Thread Marco N .
On Wed, 8 Nov 2023 17:27:19 GMT, Lance Andersen wrote: >> @LanceAndersen >> >> I noticed that this PR did not update `ZipInputStream.readLOC` to perform >> consistency validation between expected and actual extra field size and >> values. Any particular reason why processing of LOC headers wa

Re: RFR: 8314891: Additional Zip64 extra header validation [v8]

2023-11-08 Thread Lance Andersen
On Wed, 8 Nov 2023 16:27:56 GMT, Eirik Bjorsnos wrote: > @LanceAndersen > > I noticed that this PR did not update `ZipInputStream.readLOC` to perform > consistency validation between expected and actual extra field size and > values. Any particular reason why processing of LOC headers was not

Re: RFR: 8314891: Additional Zip64 extra header validation [v8]

2023-11-08 Thread Eirik Bjorsnos
On Mon, 23 Oct 2023 19:12:57 GMT, Lance Andersen wrote: >> Please review this PR which improves the Zip64 extra header validation: >> >> - Throw a ZipException If the extra len field is 0 and : >> -- size, csize, or loc offset are set to 0x >> -- disk starting number is set to 0x >>

Re: RFR: 8314891: Additional Zip64 extra header validation [v8]

2023-10-23 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v7]

2023-10-18 Thread Sean Coffey
On Mon, 18 Sep 2023 13:17:25 GMT, Lance Andersen wrote: >> Please review this PR which improves the Zip64 extra header validation: >> >> - Throw a ZipException If the extra len field is 0 and : >> -- size, csize, or loc offset are set to 0x >> -- disk starting number is set to 0x >>

Re: RFR: 8314891: Additional Zip64 extra header validation [v7]

2023-09-18 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v6]

2023-09-18 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v5]

2023-09-17 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v4]

2023-09-17 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v3]

2023-09-14 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

2023-09-14 Thread Lance Andersen
On Mon, 11 Sep 2023 23:42:37 GMT, Sergey Bylokhov wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added additional tests, along with additional cleanup and refactoring > > test/jdk/java/util/zip/ZipFile/MissingZI

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

2023-09-14 Thread Lance Andersen
On Tue, 12 Sep 2023 08:47:03 GMT, Andrey Turbanov wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added additional tests, along with additional cleanup and refactoring > > test/jdk/java/util/zip/ZipFile/MissingZI

Re: RFR: 8314891: Additional Zip64 extra header validation [v2]

2023-09-14 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation

2023-09-12 Thread Andrey Turbanov
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote: > Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We

Re: RFR: 8314891: Additional Zip64 extra header validation

2023-09-11 Thread Sergey Bylokhov
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote: > Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We

RFR: 8314891: Additional Zip64 extra header validation

2023-09-09 Thread Lance Andersen
Please review this PR which improves the Zip64 extra header validation: - Throw a ZipException If the extra len field is 0 and : -- size, csize, or loc offset are not set to 0x -- disk starting number is not set to 0x - We have a valid size for the Zip64 extra header but we are missin