Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-03 Thread Jaikiran Pai
On Wed, 3 Jan 2024 11:53:43 GMT, Alan Bateman wrote: > It's been bumped to 1.5g in the loom repo for some time. Ah, I misread that change previously as reducing it from `1g` to `150m`, while infact this change is increasing it to `1500m`. Given your reference to JDK-8303635, the change looks

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-03 Thread Alan Bateman
On Wed, 3 Jan 2024 11:53:24 GMT, Jaikiran Pai wrote: > Just one question - doesn't the use of a new native code in the test library > (the `libVThreadPinner.c`) require any build changes (I'm not too familiar > with that part)? Magnus did some work in the make files some time ago to build

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-03 Thread Jaikiran Pai
On Tue, 2 Jan 2024 15:22:05 GMT, Alan Bateman wrote: >> A lot of test changes have accumulated in the loom repo, this includes both >> new tests and updates to existing tests. Some of these updates can be >> brought to the main line. This update brings over: >> >> - The existing tests for

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-03 Thread Alan Bateman
On Wed, 3 Jan 2024 11:39:01 GMT, Jaikiran Pai wrote: > Are these heap sizing changes to reduce the resource usage of this test or is > it to try and trigger any potential issue that this test verifies? The heap usage for this one can vary quite a bit, some of the lower optimization modes lead

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-03 Thread Jaikiran Pai
On Tue, 2 Jan 2024 15:22:05 GMT, Alan Bateman wrote: >> A lot of test changes have accumulated in the loom repo, this includes both >> new tests and updates to existing tests. Some of these updates can be >> brought to the main line. This update brings over: >> >> - The existing tests for

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-02 Thread Alan Bateman
> A lot of test changes have accumulated in the loom repo, this includes both > new tests and updates to existing tests. Some of these updates can be brought > to the main line. This update brings over: > > - The existing tests for pinning use synchronized blocks. In preparation for > changes

Re: RFR: 8320707: Virtual thread test updates

2023-12-19 Thread Alan Bateman
On Mon, 18 Dec 2023 20:37:29 GMT, Chris Plummer wrote: > I'm working on a test where I just added a CountDownLatch(1) and am wondering > if I should do the same, but I'm not sure if there is something about these > tests that is motivating the change. CountDownLatch is great for many tests.

Re: RFR: 8320707: Virtual thread test updates

2023-12-18 Thread Chris Plummer
On Sat, 16 Dec 2023 17:25:20 GMT, Alan Bateman wrote: > A lot of test changes have accumulated in the loom repo, this includes both > new tests and updates to existing tests. Some of these updates can be brought > to the main line. This update brings over: > > - The existing tests for pinning

RFR: 8320707: Virtual thread test updates

2023-12-16 Thread Alan Bateman
A lot of test changes have accumulated in the loom repo, this includes both new tests and updates to existing tests. Some of these updates can be brought to the main line. This update brings over: - The existing tests for pinning use synchronized blocks. In preparation for changes to allow