Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v7]

2024-05-02 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v6]

2024-04-15 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v4]

2024-03-06 Thread Adam Sotona
On Wed, 6 Mar 2024 15:31:40 GMT, Chen Liang wrote: > Looking at 8326836 #18030, we might need `@since` tags on the new API methods. Thanks for pointing it out, I've added them. - PR Comment: https://git.openjdk.org/jdk/pull/17282#issuecomment-1981230434

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v5]

2024-03-06 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v4]

2024-03-06 Thread Chen Liang
On Wed, 6 Mar 2024 15:00:09 GMT, Adam Sotona wrote: >> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. >> Existing ClassFile API use cases proved the concept one big CodeBuilder is >> comfortable. However there are some redundancies, glitches in the naming >> conventions,

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v4]

2024-03-06 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v3]

2024-03-05 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v2]

2024-02-05 Thread Adam Sotona
On Mon, 5 Feb 2024 17:23:54 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed CodeBuilder::newObject methods > > src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 507: > >

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v2]

2024-02-05 Thread Paul Sandoz
On Mon, 5 Feb 2024 18:31:44 GMT, Adam Sotona wrote: >> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. >> Existing ClassFile API use cases proved the concept one big CodeBuilder is >> comfortable. However there are some redundancies, glitches in the naming >> conventions,

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface [v2]

2024-02-05 Thread Adam Sotona
> `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some frequently used methods are hard to find and some met

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface

2024-02-05 Thread Brian Goetz
On Fri, 5 Jan 2024 15:17:13 GMT, Adam Sotona wrote: > `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some

Re: RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface

2024-02-01 Thread Erik Gahlin
On Fri, 5 Jan 2024 15:17:13 GMT, Adam Sotona wrote: > `java.lang.classfile.CodeBuilder` contains more than 230 API methods. > Existing ClassFile API use cases proved the concept one big CodeBuilder is > comfortable. However there are some redundancies, glitches in the naming > conventions, some

RFR: 8323058: Revisit j.l.classfile.CodeBuilder API surface

2024-02-01 Thread Adam Sotona
`java.lang.classfile.CodeBuilder` contains more than 230 API methods. Existing ClassFile API use cases proved the concept one big CodeBuilder is comfortable. However there are some redundancies, glitches in the naming conventions, some frequently used methods are hard to find and some methods ha