On Wed, 3 Apr 2024 07:13:13 GMT, Jan Lahoda wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
>> line 1415:
>>
>>> 1413:
>>> canonicalConstructorTypes,
>>> 1414:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Mon, 8 Apr 2024 16:36:49 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding tests as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
> line 101:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Fri, 5 Apr 2024 18:30:30 GMT, Joe Darcy wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback:
>> - pre-generating the JCVarDecls in Attr, to aid Flow
>> - adding a note on how the
On Mon, 8 Apr 2024 16:21:19 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Fri, 5 Apr 2024 18:28:58 GMT, Jan Lahoda wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 4443:
>>
>>> 4441: }
>>> 4442:
>>> 4443: @Override
>>
>> As usual, I suggest to add some brief comment with the shape of the
>> generated code.
>
> Done here:
On Fri, 5 Apr 2024 18:32:09 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 13:09:56 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JavaCompiler cleanup
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2117:
>
>> 2115:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Thu, 4 Apr 2024 20:27:36 GMT, Jan Lahoda wrote:
>> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java
>> line 133:
>>
>>> 131: */
>>> 132:
>>> @PreviewFeature(feature=PreviewFeature.Feature.DERIVED_RECORD_CREATION,
>>> reflective=true)
>>> 133:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Thu, 4 Apr 2024 17:00:33 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java
> line 1574:
>
>> 1572:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Thu, 4 Apr 2024 16:47:07 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2235:
>
>> 2233:
On Thu, 4 Apr 2024 00:37:45 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java
> line 133:
>
>> 131:
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>>
On Tue, 2 Apr 2024 12:50:19 GMT, ExE Boss wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
> line 1415:
>
>> 1413:
On Tue, 2 Apr 2024 18:09:52 GMT, Joe Darcy wrote:
> > For the `javax.lang.model` changes, as a new ElementKind is being
> > introduced, there should be a matching layer of new concrete visitors and
> > selected updates to existing visitor implementations, etc.
>
> I can help develop the
On Tue, 2 Apr 2024 18:05:43 GMT, Joe Darcy wrote:
> For the `javax.lang.model` changes, as a new ElementKind is being introduced,
> there should be a matching layer of new concrete visitors and selected
> updates to existing visitor implementations, etc.
I can help develop the visitor changes
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>>
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Thu, 28 Mar 2024 11:00:42 GMT, Aggelos Biboudis
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renaming visitReconstruction to visitDerivedInstance as suggested.
>
>
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Wed, 27 Mar 2024 10:24:51 GMT, Jan Lahoda wrote:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The
This is a patch for javac, that adds the Derived Record Creation expressions.
The current draft specification for the feature is:
https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
The current CSR is here:
https://bugs.openjdk.org/browse/JDK-8328637
36 matches
Mail list logo