RFR: 8326915: NPE when a validating parser is restricted

2024-02-29 Thread Joe Wang
Fix a NPE when a validating parser is restricted by the JDKCatalog resolve property. Also slightly improved the error msg with the catalog name. Test: new test added existing test CatalogSupport5 would fail without the Null check on ErrorReporter. It's a separate issue not covered by th

Re: RFR: 8326915: NPE when a validating parser is restricted

2024-03-01 Thread Lance Andersen
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote: > Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null ch

Re: RFR: 8326915: NPE when a validating parser is restricted

2024-03-01 Thread Naoto Sato
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote: > Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null ch

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Joe Wang
On Fri, 1 Mar 2024 00:53:17 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> input.substring second argument not needed; proper test method name > > src/java.xml/share/classes/jdk/xml/internal/SecuritySu

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Joe Wang
> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null check on > ErrorReporter. It's a separate issue not c

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Lance Andersen
On Fri, 1 Mar 2024 18:02:24 GMT, Joe Wang wrote: >> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve >> property. Also slightly improved the error msg with the catalog name. >> >> Test: new test added >> existing test CatalogSupport5 would fail without the Nul