Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-06 Thread Naoto Sato
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-05 Thread Lance Andersen
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-05 Thread Brian Burkhalter
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-05 Thread Justin Lu
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-05 Thread Joe Wang
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

2024-03-05 Thread Naoto Sato
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote: > Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Thanks for the reviews. Updated as suggested - PR Comment: https://git.openjdk.org/jdk/pull/18113#issuecomment-1979271823

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]

2024-03-05 Thread Naoto Sato
> Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflects review comments - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

2024-03-05 Thread Guoxiong Li
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote: > Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Looks good. Only a trivial suggestion. test/jdk/java/lang/Double/ParseDouble.java line 564: > 562: check(input[i]); > 563:

Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

2024-03-04 Thread Joe Darcy
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote: > Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Looks fine; thanks for sending out the fix. test/jdk/java/lang/Double/ParseDouble.java line 559: > 557: private static void testParsing(Str

RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases

2024-03-04 Thread Naoto Sato
Fixing test cases. For bad test cases, only the first case was run, and the rest were ignored. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/18113/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18113&range=00 Issue: https://bugs.openjdk.or