On Wed, 22 May 2024 07:49:27 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change for addressing
>> https://bugs.openjdk.org/browse/JDK-8332490?
>>
>> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
>> then doesn't close the stream. This
On Wed, 22 May 2024 07:49:27 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change for addressing
>> https://bugs.openjdk.org/browse/JDK-8332490?
>>
>> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
>> then doesn't close the stream. This
On Wed, 22 May 2024 07:28:04 GMT, Claes Redestad wrote:
> LGTM - feel free to add a comment that closing the InflaterInputStream has no
> effect on the underlying stream deflated.
Hello Claes, I've updated the PR to include a comment.
-
PR Comment:
On Wed, 22 May 2024 07:27:14 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/java/util/zip/InflaterInputStreams.java line
>> 113:
>>
>>> 111: try (InflaterInputStream iis = new
>>> InflaterInputStream(deflated)) {
>>> 112: while (iis.read(inflated, 0,
> Can I please get a review of this test-only change for addressing
> https://bugs.openjdk.org/browse/JDK-8332490?
>
> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
> then doesn't close the stream. This can lead to resource leak which can then
> cause OOM as noted
On Wed, 22 May 2024 07:20:04 GMT, Alan Bateman wrote:
>> Can I please get a review of this test-only change for addressing
>> https://bugs.openjdk.org/browse/JDK-8332490?
>>
>> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
>> then doesn't close the stream. This
On Wed, 22 May 2024 05:16:42 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change for addressing
> https://bugs.openjdk.org/browse/JDK-8332490?
>
> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
> then doesn't close the stream. This can
On Wed, 22 May 2024 05:16:42 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change for addressing
> https://bugs.openjdk.org/browse/JDK-8332490?
>
> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
> then doesn't close the stream. This can
On Wed, 22 May 2024 05:16:42 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change for addressing
> https://bugs.openjdk.org/browse/JDK-8332490?
>
> The jmh test opens a `InflaterInputStream`, reads the stream contents, but
> then doesn't close the stream. This can
Can I please get a review of this test-only change for addressing
https://bugs.openjdk.org/browse/JDK-8332490?
The jmh test opens a `InflaterInputStream`, reads the stream contents, but then
doesn't close the stream. This can lead to resource leak which can then cause
OOM as noted in that JBS
10 matches
Mail list logo
