Re: RFR: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher [v2]

2024-06-13 Thread Jaikiran Pai
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to remove the >> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that >> JBS issue, in

Re: RFR: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher [v2]

2024-06-13 Thread Alan Bateman
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to remove the >> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that >> JBS issue, in

Re: RFR: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher [v2]

2024-06-13 Thread Jaikiran Pai
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to remove the >> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that >> JBS issue, in

Re: RFR: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher [v2]

2024-06-06 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to remove the > `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? > > This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that > JBS issue, in a recent PR discussion, it was suggested > https://github.

RFR: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher

2024-06-06 Thread Jaikiran Pai
Can I please get a review for this change which proposes to remove the `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code? This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that JBS issue, in a recent PR discussion, it was suggested https://github.com/openjdk/