On Tue, 2 May 2023 16:27:25 GMT, Lance Andersen wrote:
>> This is added in setup method to create the serialized data with current JDK
>> version (JDK under test). In addition to serialized data generated with old
>> JDK version.
>
> Sorry, I still disagree with this. Your comment in the test
On Tue, 2 May 2023 14:05:03 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>>
>>> 83:
>>> 84: // Generates the Java Pseudo code for base64 encoded string
>>> that can be cut & pasted into the test
>>> 85: final
On Fri, 28 Apr 2023 18:43:32 GMT, Joe Wang wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 2:
>
>> 1:
On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Looks ok.
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
