On Thu, 2 Feb 2023 15:33:29 GMT, Scott Gibbons wrote:
>> Names are important, but always hard to get right. At the very least they
>> need to be correct. Maybe call it something like
>> `..parameterized_decode_tables..` and the other `..shared_decode_tables..`?
>
> I prefer leaving them the
On Thu, 2 Feb 2023 00:34:32 GMT, Claes Redestad wrote:
>> These tables are used for both URL and non-URL based on the parameter, and
>> they are only two of the three lut tables used (the other is in
>> `base64_AVX2_decode_tables_addr` ). Both names are essentially incorrect.
>> Does the
On Wed, 1 Feb 2023 20:59:24 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2202:
>>
>>> 2200: }
>>> 2201:
>>> 2202: address StubGenerator::base64_AVX2_decode_URL_tables_addr() {
>>
>> Shouldn't this be `decode_lut_tables`? As it's used for URL and non-URL
>>
On Wed, 1 Feb 2023 20:53:54 GMT, Claes Redestad wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handle AVX2 URL; address review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2202:
>
>> 2200: }
On Wed, 1 Feb 2023 18:28:25 GMT, Scott Gibbons wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64Encode.testBase64Encode 1024 thrpt3
