Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread 温绍锦
On Tue, 27 Jun 2023 16:35:20 GMT, Alan Bateman wrote: > > Wenshao hopes to use this array for other optimizations in `java.lang` in > > the future. > > But as for this PR, I suggest wenshao not to do so much. I suggest moving > > `DIGITS` back to `HexDigits` first to make the modifications in

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Glavo
On Tue, 27 Jun 2023 11:25:32 GMT, 温绍锦 wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> use ISO_8859_1.INSTANCE directly instead of StandardCharsets.ISO_8859_1 > >> I'm looking through >>

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Alan Bateman
On Tue, 27 Jun 2023 11:25:32 GMT, 温绍锦 wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> use ISO_8859_1.INSTANCE directly instead of StandardCharsets.ISO_8859_1 > >> I'm looking through >>

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Chen Liang
On Tue, 27 Jun 2023 11:50:40 GMT, Glavo wrote: >> do I need to change the copyright information? I am not sure > >> do I need to change the copyright information? I am not sure > > Yes, you should update the copyright information of each file you have > modified. The years in the header are

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Glavo
On Tue, 27 Jun 2023 11:27:18 GMT, 温绍锦 wrote: > do I need to change the copyright information? I am not sure Yes, you should update the copyright information of each file you have modified. - PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1243607127

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread 温绍锦
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread 温绍锦
On Tue, 27 Jun 2023 10:08:32 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> use ISO_8859_1.INSTANCE directly instead of StandardCharsets.ISO_8859_1 > > src/java.base/share/classes/java/util/UUID.java line

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Alan Bateman
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Chen Liang
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-27 Thread Chen Liang
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread 温绍锦
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread 温绍锦
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread 温绍锦
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread Roger Riggs
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread Chen Liang
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v25]

2023-06-26 Thread 温绍锦
> By optimizing the implementation of java.lang.Long#fastUUID, the performance > of the java.util.UUID#toString method can be significantly improved. > > The following are the test results of JMH: > > Benchmark Mode Cnt Score Error Units >