Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-22 Thread 温绍锦
On Thu, 22 Jun 2023 05:48:34 GMT, Alan Bateman wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> move HEX256 to LongCache > > src/java.base/share/classes/java/lang/Long.java line 1233: > >> 1231: HEX256[i] =

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-22 Thread Glavo
On Thu, 22 Jun 2023 02:03:55 GMT, Chen Liang wrote: > About @Glavo's VH suggestion: I think it is feasible, since the VH field is > not initialized until the method is used, so there should be no startup issue. @liach This sounds good. I'm thinking about refactoring `ByteArray` and

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread Alan Bateman
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread Chen Liang
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread Chen Liang
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread Roger Riggs
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread 温绍锦
On Thu, 22 Jun 2023 01:03:11 GMT, Roger Riggs wrote: > fyi, the title of this PR need to match exactly the title of the bug > [JDK-8310502](https://bugs.openjdk.org/browse/JDK-8310502). The mismatch is > an Integration blocker. (See the comment in the description). i have made the changes. is

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v7]

2023-06-21 Thread Roger Riggs
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote: >> By optimizing the implementation of java.lang.Long#fastUUID, the performance >> of the java.util.UUID#toString method can be significantly improved. >> >> The following are the test results of JMH: >> >> Benchmark Mode Cnt