Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-29 Thread Joe Darcy
On Tue, 28 Nov 2023 15:00:43 GMT, Jim Laskey wrote: >> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35: >> >>> 33: import java.lang.reflect.Modifier; >>> 34: >>> 35: public class TestImplicitClass { >> >> The test looks to be testing core reflection behavior (i.e. runti

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-28 Thread Jim Laskey
On Mon, 27 Nov 2023 23:46:00 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Requested changes > > test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35: > >> 33: import java.lang.re

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-28 Thread Pavel Rappo
On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> - S

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-27 Thread Joe Darcy
On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> - S

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-24 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull re