Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-03-01 Thread Matthias Baesken
On Mon, 26 Feb 2024 06:57:49 GMT, Jaikiran Pai wrote: > Hello David, the updated text that I proposed to Matthias, of the form > "expected: ... but was: ..." was borrowed from what junit5 Unfortunately we get now error messages like this java.lang.RuntimeException: VM output should contain

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-27 Thread Matthias Baesken
On Mon, 26 Feb 2024 01:17:23 GMT, Jaikiran Pai wrote: > Hello Christoph, yes that looks fine to me. I adjusted it to the given suggestion. - PR Comment: https://git.openjdk.org/jdk/pull/17952#issuecomment-1967070481

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-25 Thread Jaikiran Pai
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-25 Thread David Holmes
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-25 Thread Jaikiran Pai
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-25 Thread Christoph Langer
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-25 Thread Jaikiran Pai
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-24 Thread Christoph Langer
On Sat, 24 Feb 2024 11:45:46 GMT, Jaikiran Pai wrote: > This is similar to what other test libraries usually report for such failures. But in the case of a non-empty `msg` you would not see the actual values any more which I think could be helpful in a lot of cases... - PR

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-24 Thread Jaikiran Pai
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-23 Thread Matthias Baesken
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-23 Thread Christoph Langer
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-23 Thread Matthias Baesken
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken wrote: >> Currently assertEquals has in the failure case sometimes confusing output >> like : >> >> java.lang.RuntimeException: VM output should contain exactly one RTM locking >> statistics entry for method >>

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-02-22 Thread Matthias Baesken
> Currently assertEquals has in the failure case sometimes confusing output > like : > > java.lang.RuntimeException: VM output should contain exactly one RTM locking > statistics entry for method > compiler.rtm.locking.TestRTMTotalCountIncrRate$Test: expected 0 to equal 1 >at