Re: [core-workflow] self-approving pull requests

2017-02-24 Thread Nick Coghlan
On 25 February 2017 at 10:17, Brett Cannon wrote: > Two things. One, has someone verified that if a core dev edits a PR that > the squash commit still gives the PR creator the author credit in the git > metadata? I remember doing an edit like this once and GitHub didn't show > any author credit i

[core-workflow] Travis is now required to be passing, reviews are not

2017-02-24 Thread Brett Cannon
I didn't turn on Codecov requirements for the patch because we seem to still have variance in them where some module that are inconsistently being tested (there is a test for the whole project but I left that off as well). I think we should definitely work towards fixing the coverage variance as I

Re: [core-workflow] self-approving pull requests

2017-02-24 Thread Brett Cannon
Two things. One, has someone verified that if a core dev edits a PR that the squash commit still gives the PR creator the author credit in the git metadata? I remember doing an edit like this once and GitHub didn't show any author credit in the web UI because I assume GitHub refused to guess who th