Two things. One, has someone verified that if a core dev edits a PR that the squash commit still gives the PR creator the author credit in the git metadata? I remember doing an edit like this once and GitHub didn't show any author credit in the web UI because I assume GitHub refused to guess who the author credit should go to. So if someone could test this in a checkout that would be great as that means https://github.com/python/core-workflow/issues/7 can be easily solved and we can automate Misc/ACKS.
Two, we are going to review the new workflow in two weeks after having been using it for a month (I can't believe it's only been two weeks since the migration!). Since the sign-off requirement has generated the most discussion, what I will do is swap the requirement for PR merging to be no required review but to require all-green status checks (in a previous email Donald alluded to the fact that I thought self-approval would be possible in "emergencies" but that obviously doesn't hold). This will give us basically 2 weeks with both approaches when we review the process so we can make an informed decision. On Wed, 22 Feb 2017 at 20:19 Donald Stufft <don...@stufft.io> wrote: > > On Feb 22, 2017, at 11:17 PM, Nick Coghlan <ncogh...@gmail.com> wrote: > > On 23 February 2017 at 02:25, Barry Warsaw <ba...@python.org> wrote: > > On Feb 22, 2017, at 11:10 AM, Donald Stufft wrote: > > FWIW, I don’t think that creating a new PR and closing the original one is > a > subpar experience for contributors, particularly if we turn off the bit > that > requires reviews and just turn on the thing that requires passing > tests. Having been in that situation it has never once bothered me to have > someone cherry pick my change and amend it. > > > Since we're squashing commits wouldn't that obliterate the original > author's > credit for the work? > > > You can set "--author" when making the new squash commit (we should > document that somewhere, since it's also useful when importing patches > from bugs.python.org). > > Although looking at https://github.com/python/cpython/pull/169 (where > I set the author to Serhiy, since I was importing a patch he wrote), > it seems GitHub doesn't actually *show* the Author information > anywhere that I can find. > > > > Github automatically sets author of the squash commit based on who opened > the PR. > > > — > > Donald Stufft > _______________________________________________ > core-workflow mailing list > core-workflow@python.org > https://mail.python.org/mailman/listinfo/core-workflow > This list is governed by the PSF Code of Conduct: > https://www.python.org/psf/codeofconduct
_______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
