Can somebody give me a sanity check? I can't see the error with the macro.
I won't say too much here -- just take a look. I'm not convinced the
code is wrong.
thanks
ron
On Fri, Apr 18, 2014 at 7:39 AM, WANG FEI wrote:
> Ronald,
>
> I just noticed a bug in your code, I've added the comment to c
Still not seeing it.
I think the order should be
' ', 'S', 'S', 'B'
not ' ', 'B'','S','S'
or 'B','S','S',' '
i.e. space is the high order byte.
ron
On Fri, Apr 18, 2014 at 8:21 AM, Nico Huber wrote:
> On 18.04.2014 16:49, ron minnich wrote:
>>
>> Can somebody give me a sanity check? I can'
Which of course means my code IS wrong, but the suggested fix is wrong
too I think.
ron
On Fri, Apr 18, 2014 at 8:34 AM, ron minnich wrote:
> Still not seeing it.
>
> I think the order should be
> ' ', 'S', 'S', 'B'
>
> not ' ', 'B'','S','S'
> or 'B','S','S',' '
>
> i.e. space is the high order
Fooey. Now they all look wrong.
I think the macro maybe should be defined as makemagic(b0,b1,b2,b3)
the thing I can't figure out is why this ever worked.
OK, off to the dentist, ...
ron
On Fri, Apr 18, 2014 at 8:34 AM, ron minnich wrote:
> Which of course means my code IS wrong, but the sugg
On Fri, Apr 18, 2014 at 9:49 AM, ron minnich wrote:
> Can somebody give me a sanity check? I can't see the error with the macro.
> I won't say too much here -- just take a look. I'm not convinced the
> code is wrong.
http://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/include/cbfs_core.
On 18.04.2014 16:49, ron minnich wrote:
Can somebody give me a sanity check? I can't see the error with the macro.
I won't say too much here -- just take a look. I'm not convinced the
code is wrong.
Well, I'm convinced :P
Have a closer look at the placement of the space. It was next to the
latt
On Fri, Apr 18, 2014 at 11:08 AM, WANG FEI wrote:
> The first option to change makemagic('B', 'S', 'S', ' ') of
> PAYLOAD_SEGMENT_BSS in util/cbfstool/cbfs.h would be a better solution.
>
It wasn't an either or proposition. The #2 piece is to fix big endian
machines that are inherently broken wit
The first option to change makemagic('B', 'S', 'S', ' ') of
PAYLOAD_SEGMENT_BSS in util/cbfstool/cbfs.h would be a better solution.
On Fri, Apr 18, 2014 at 4:52 PM, Aaron Durbin wrote:
> On Fri, Apr 18, 2014 at 9:49 AM, ron minnich wrote:
> > Can somebody give me a sanity check? I can't see the
Please see http://review.coreboot.org/#/c/5544/ and I appreciate your patience.
ron
On Fri, Apr 18, 2014 at 9:08 AM, WANG FEI wrote:
> The first option to change makemagic('B', 'S', 'S', ' ') of
> PAYLOAD_SEGMENT_BSS in util/cbfstool/cbfs.h would be a better solution.
>
>
> On Fri, Apr 18, 2014
9 matches
Mail list logo