Thanks for the detailed explanation Ron. FWIW I agree that removing
guards like in acpi.h makes sense.
> I did a simple test: apply #pragma once to coreboot. A coreboot build
> for watson opens 80K .h files today. #pragma once makes barely any
> difference; this says we are doing a good job in
On Thu, May 23, 2019 at 7:13 PM Julius Werner wrote:
>
> ...
> In general I think it's fine if you discuss things on the call as they
> come up, but if you notice that it's something that would interest the
> community at large (e.g. proposed style changes) it would be nice if
> you could
On Thu, May 23, 2019 at 6:13 PM Julius Werner wrote:
>
> > > * Can we adopt on principle removing all cpp guards on protos?
> > Why would this be a good idea?
> > What does "cpp guards" actually refer to?
>
> Upon re-reading this I *think* what they mean is stuff like
>
> #if CONFIG(SOME_OPTION)
> > * Can we adopt on principle removing all cpp guards on protos?
> Why would this be a good idea?
> What does "cpp guards" actually refer to?
Upon re-reading this I *think* what they mean is stuff like
#if CONFIG(SOME_OPTION)
void function_prototype(void);
#endif
and not what I'd usually call
Guys, it is a bit tricky to prevent discussions in a call when someone
brings up a topic, and I'm not sure that blocking that is useful. The
meetings are open and particularly people commenting here have been invited
to the calls. Please make use of that opportunity and join, if you think
that you
> >* We should be more strict about how we define our blocks’ APIs.
>
> Ok, but.. I just don't understand this proposal? Can someone explain?
I second this... this sounds like another code style
discussion/change. Can we please keep all code style discussions on
the mailing list? Or if there
Martin Roth wrote:
> * Can we adopt on principle removing all cpp guards on protos?
Why would this be a good idea?
What does "cpp guards" actually refer to?
>* Add cleanup task - remove guards specifically around prototypes?
>* Having the prototypes outside of guards turns a compile
7 matches
Mail list logo
