On Wed, Feb 28, 2024 at 9:09 AM Pádraig Brady wrote:
> >> On 11/30/23 12:11, Pádraig Brady wrote:
> >>> Though that will generally give 128K, which is good when processing all
> >>> of a file,
> >>> but perhaps overkill when processing just the last part of a file.
> >>
> >> The 128 KiB
On Wed, Dec 27, 2023 at 4:14 PM Pádraig Brady wrote:
> On 27/12/2023 20:52, Jim Meyering wrote:
> > Thanks. Nice improvement.
> > I compared --help and --version output, which showed no difference
> > other than the intended ones.
>
> Thanks for the review. Pushed.
Thanks. Nice improvement.
I compared --help and --version output, which showed no difference
other than the intended ones.
make check passed, modulo this unrelated failure on Fedora 38:
numfmt.pl: test lcl-dbl-to-human-1: stdout mismatch, comparing
lcl-dbl-to-human-1.1 (expected) and
On Wed, Dec 27, 2023 at 8:20 AM Pádraig Brady wrote:
> On 17/12/2023 14:17, Pádraig Brady wrote:
> > On 16/12/2023 22:01, Bernhard Voelker wrote:
> >> On 12/15/23 14:22, Pádraig Brady wrote:
> >>> On 31/10/2023 19:49, Pádraig Brady wrote:
> On 31/10/2023 17:51, Ed Neville wrote:
> > Hi
Nice. Thanks.
On Tue, Jul 18, 2023 at 11:14 AM Pádraig Brady wrote:
> The new test where `split -n 1/2 /dev/zero` exhausts /tmp
> will trigger other false positive failures in the test suite
> which happens often when running tests with RUN_VERY_EXPENSIVE_TESTS set.
>
> The attached patches tackle this by
On Tue, Jul 18, 2023 at 3:14 PM Pádraig Brady wrote:
>
> * cfg.mk (sc_prohibit_NULL): Direct to use nullptr instead.
Good one. Now I want to add that in each of at least diffutils, grep, sed, gzip.
On Fri, Jul 14, 2023 at 3:27 AM Pádraig Brady wrote:
> On 14/07/2023 07:54, Jim Meyering wrote:
> > Small suggested improvement:
>
> Looks good thanks.
> Testing with the attached shows a 23% improvement on average
> with using strcspn() over strchr()x3.
Thanks for checking. Pushed.
Small suggested improvement:
>From c0e7e4a1d41049bbf38cf902d13746b1ab5b1e38 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 13 Jul 2023 22:29:52 -0700
Subject: [PATCH] cksum: improve problematic_chars function
* src/digest.c (problematic_chars): Implement using strcspn,
and traversin
On Sat, Jul 8, 2023 at 1:58 PM Pádraig Brady wrote:
> On 08/07/2023 19:52, Jim Meyering wrote:
> > On Sat, Jul 8, 2023 at 7:28 AM Pádraig Brady wrote:
> >> It would be nice to be able to support users who want to replace all
> >> the *sum utilities with a script t
On Sat, Jul 8, 2023 at 7:28 AM Pádraig Brady wrote:
> It would be nice to be able to support users who want to replace all
> the *sum utilities with a script that did:
>
>exec cksum -a --untagged "$@"
>
> To that end, it would be good to support all the options of the older utils.
> This is
On Sat, Jun 10, 2023 at 6:50 AM Pádraig Brady wrote:
> On 10/06/2023 02:45, Marc Lehmann wrote:
> > Package: coreutils
> > Version: 9.1-1
> > Severity: normal
> >
> > Dear Maintainer,
> >
> > I have a script that was used for some decades on multiple
> > unices. Beginning with bookworm, it
On Wed, May 31, 2023 at 9:12 AM Pádraig Brady wrote:
> On 30/05/2023 22:29, Paul Eggert wrote:
> > On 5/28/23 06:07, Pádraig Brady wrote:
> >> There still is a gotcha (hit in dd.c in coreutils)
> >> where if you define an error macro yourself
> >> you get a macro redefinition error,
> >
> > I see
On Mon, Mar 27, 2023 at 5:00 AM Pádraig Brady wrote:
> On 27/03/2023 02:27, Jim Meyering wrote:
> > Hi Pádraig,
> >
> > I recently made the grep-3.10 release using the very latest autoconf
> > (built from master). I'm preparing to make an autoconf snapshot, and
> >
On Sun, Mar 26, 2023 at 6:27 PM Jim Meyering wrote:
> Hi Pádraig,
>
> I recently made the grep-3.10 release using the very latest autoconf
> (built from master). I'm preparing to make an autoconf snapshot, and
> hopefully soon after, a "stable" 2.73 release. So far,
Hi Pádraig,
I recently made the grep-3.10 release using the very latest autoconf
(built from master). I'm preparing to make an autoconf snapshot, and
hopefully soon after, a "stable" 2.73 release. So far, no one has
reported any issue with grep-3.10, but it has significantly less
autoconf
On Tue, Feb 21, 2023 at 4:45 AM Pádraig Brady wrote:
> On 21/02/2023 02:59, Jim Meyering wrote:
...
> > Thank you for the bug report.
> > I've attached a patch that fixes those bugs.
>
> lgtm
> modulo the commit summary line should start with rm: not rm ...
> Do
-- Forwarded message -
From: Jim Meyering
Date: Mon, Feb 20, 2023 at 6:27 PM
Subject: Re: Bug#1015273: coreutils: rm -d doesn't try to remove
unreadable directories, lies in error message, with *fails to prompt*
with -i
To: наб , <1015...@bugs.debian.org>
Cc: Debian Bug Tr
On Sat, Feb 4, 2023 at 10:01 AM Pádraig Brady wrote:
>
> On 04/02/2023 16:58, Jim Meyering wrote:
> > On Sat, Feb 4, 2023 at 5:52 AM Pádraig Brady wrote:
> >>
> >> --raw output is the most composable format, and also is a
> >> robust way to discard the fil
On Sat, Feb 4, 2023 at 5:52 AM Pádraig Brady wrote:
>
> --raw output is the most composable format, and also is a
> robust way to discard the file name without parsing (escaped) output.
Very nice. I applied it and ran all tests, and distcheck. All passed.
TIny suggestions:
> diff --git
On Tue, Jan 31, 2023 at 1:43 PM Pádraig Brady wrote:
> s/accepted/supports/ in NEWS
Thanks. Good catch.
I prefer to use "accepts", matching the entry just below.
Will push soon.
On Tue, Jan 31, 2023 at 5:00 AM Pádraig Brady wrote:
> On 31/01/2023 06:48, Jim Meyering wrote:
> > On Mon, Jan 30, 2023 at 11:29 AM Pádraig Brady wrote:
> >> ...
> >
> > Thanks for the speedy feedback.
> >
> >> "If must be followed by white spa
On Mon, Jan 30, 2023 at 11:29 AM Pádraig Brady wrote:
> ...
Thanks for the speedy feedback.
> "If must be followed by white space." comment has a typo
> and also not enforced explicitly, so could be removed.
Thanks. Removed.
> valid_digits() may check beyond the end of the buffer
> in the
On Mon, Jan 30, 2023 at 10:17 AM Pádraig Brady wrote:
> On 29/01/2023 20:40, Jim Meyering wrote:
> > Hi Pádraig! Happy new year (belatedly ;-). Hope you're well.
> >
> > I'd like our generated announcements to be able to include
> > base64-encoded checksums without ha
On Sun, Jan 29, 2023 at 1:10 PM Jim Meyering wrote:
> On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering wrote:
> ...
> > - I'm inclined to work like the openbsd cksum and accept invocations
> > like "cksum -a sha1x" and "cksum -a sha1b". Any objection
FYI, while preparing the --base64 patch, I noticed this nit, so have
just pushed the attached:
cu-dup-local.diff
Description: Binary data
FYI, I noticed failures that arose due to lack of an EGREP definition,
so I pushed the attached to fix them. Possibly specific to me for
using the very latest autoconf and/or automake locally.
cu-EGREP.diff
Description: Binary data
On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering wrote:
...
> - I'm inclined to work like the openbsd cksum and accept invocations
> like "cksum -a sha1x" and "cksum -a sha1b". Any objection?
Actually, I am now **disinclined** to implement this part. It'd make
sense only
Hi Pádraig! Happy new year (belatedly ;-). Hope you're well.
I'd like our generated announcements to be able to include
base64-encoded checksums without having to recommend verifying them
using openbsd's cksum, so...
I've begun writing the code to add --base64/-b support for GNU cksum,
prompted
On Mon, Sep 12, 2022, 14:53 Pádraig Brady wrote:
> On 12/09/2022 10:20, David Pinto wrote:
> > On Sun, 26 Jun 2022 at 00:49, David Pinto
> wrote:
> >> Hi
> >>
> >> A couple of years ago [1] someone made a feature request for a wc
> >> option that would skip the total line when processing
On Fri, Aug 12, 2022 at 6:39 AM Pádraig Brady wrote:
> The attached adds support for explicitly specifying --time=mtime.
> I'm not sure about adding this, but it does give symmetry to the
> description of the --time arguments. Also it would allow
> overriding a previously selected timestamp
I've just pushed these two small changes:
>From 7e6c39cc02f461c45ef51544a512a40791d6d603 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 23 Jun 2022 08:07:18 -0700
Subject: [PATCH 1/2] maint: remove unnecessary inclusion of hash.h
* src/cut.c: Don't include hash.h. The implementat
On Wed, Dec 22, 2021 at 4:38 PM Bernhard Voelker
wrote:
>
> On 12/22/21 18:15, Jim Meyering wrote:
> > Thanks. Please push.
>
> Thanks for the review, done:
> https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=1435e8e5c5
>
> > I like the idea of adding a s
On Mon, Dec 20, 2021 at 2:31 PM Bernhard Voelker
wrote:
> Patch attached.
>
> Additionally, it may be worth adding a syntax-check rule to ensure the files
> physically copied from gnulib stay in sync.
> WDYT?
>
> Have a nice day,
> Berny
>
> diff --git a/cfg.mk b/cfg.mk
> index
A few syntax-check failures snuck in, so I've just fixed them with
these two just-pushed commits.
sc.diff
Description: Binary data
I've just pushed this:
maint: factor.c: avoid new GCC 12 warning
* src/factor.c (millerrabin2): Mark as ATTRIBUTE_PURE,
per advice from GCC 12.
---
src/factor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/factor.c b/src/factor.c
index caa97cbd2..7fc30717a 100644
---
On Thu, Nov 18, 2021 at 8:38 AM Paul Eggert wrote:
> I spotted a SELinux security-context race introduced by the circa-2012
> fix for Bug#11100, and installed the attached patch into coreutils
> master. This also gets rid of a label and goto (which is what led me to
> find the issue).
Nice!
Uname -v reports this:
Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021;
root:xnu-7195.141.6~3/RELEASE_X86_64
Sorry, I don't have time to delve into this, but here's the log from
the sole test failure:
pipe-f.log
Description: Binary data
On Mon, Sep 20, 2021 at 8:18 AM Pádraig Brady wrote:
> On 20/09/2021 15:19, Jim Meyering wrote:
> > On Mon, Sep 20, 2021 at 3:14 AM Pádraig Brady wrote:
> >> On 20/09/2021 06:46, Jim Meyering wrote:
> >>> I noticed/fixed a spurious test failure on OS X:
> >&g
On Mon, Sep 20, 2021 at 6:02 AM Pádraig Brady wrote:
> On 20/09/2021 11:03, Pádraig Brady wrote:
> > On 18/09/2021 17:34, Jim Meyering wrote:
> >> I didn't see an explanation for the single quotes in cksum --help, so
> >> propose to remove them as unnecessary synt
On Mon, Sep 20, 2021 at 3:14 AM Pádraig Brady wrote:
> On 20/09/2021 06:46, Jim Meyering wrote:
> > I noticed/fixed a spurious test failure on OS X:
>
> Oh interesting.
> This seems like a more general issue.
> Should we do this more centrally by adding to the list in
> te
I noticed/fixed a spurious test failure on OS X:
0001-tests-env-s.pl-avoid-spurious-failure-on-OS-X.patch
Description: Binary data
I didn't see an explanation for the single quotes in cksum --help, so
propose to remove them as unnecessary syntax.
Also, IMHO, you should now be listed as a coauthor of the umbrella
"cksum" program.
0002-cksum-list-P-draig-as-coauthor.patch
Description: Binary data
On Thu, Sep 16, 2021 at 3:35 PM Pádraig Brady wrote:
> * src/rmdir.c (main): Only inspect the returned stat structure,
> when stat(2) returns success.
> ---
> src/rmdir.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/rmdir.c b/src/rmdir.c
> index
On Thu, Sep 16, 2021 at 2:44 PM Pádraig Brady wrote:
> On 16/09/2021 21:30, Jim Meyering wrote:
> > I tried to build with upcoming GCC12 and with warnings + -Werror, and
> > hit one failure.
> > Here's a patch to avoid that:
>
> Cool. Small nit; it's probably best to
I tried to build with upcoming GCC12 and with warnings + -Werror, and
hit one failure.
Here's a patch to avoid that:
0001-build-avoid-new-chmod.c-warnings-from-upcoming-GCC12.patch
Description: Binary data
Thanks for all your recent changes! I built+tested with ASAN on Fedora 34:
Configure and build as usual, then "make clean" and do this:
> san='-fsanitize-address-use-after-scope -fsanitize=address -static-libasan';
> ASAN_OPTIONS=detect_leaks=0 , CFLAGS='-O -ggdb3' AM_CFLAGS="$san"
>
On Tue, Sep 14, 2021 at 5:36 AM Pádraig Brady wrote:
> On 12/09/2021 23:01, Pádraig Brady wrote:
> > On 12/09/2021 19:13, Pádraig Brady wrote:
> >> This patch set refactors all digest implementations
> >> to their own modules, all interfaced through digest.c.
> >> All file operations and
Re this:
+#if HASH_ALGO_CKSUM
+ /* TODO: Remove these restrictions. */
+ switch (cksum_algorithm)
+{
+case bsd:
+case sysv:
+case crc:
+if (delim != '\n')
+ die (EXIT_FAILURE, 0,
+ _("--zero is not supported with --algorithm={bsd,sysv,crc}"));
+
On Tue, Sep 7, 2021 at 10:39 PM Pádraig Brady wrote:
> I need to add some NEWS for this one:
>
> diff --git a/NEWS b/NEWS
> index d9ab04529..7c245f1a6 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -88,6 +88,11 @@ GNU coreutils NEWS-*-
> outline -*-
>
> ** New
On Tue, Sep 7, 2021 at 5:47 PM Pádraig Brady wrote:
> This patch set refactors all digest implementations
> to their own modules, all interfaced through digest.c.
> All file operations and diagnostics are done in digest.c.
> All digests are made available through `cksum -a`.
> Also we add support
On Mon, Aug 30, 2021 at 11:23 AM Pádraig Brady wrote:
> I'm working on consolidating digest algorithms
> (interfaced through cksum --algorithm),
> and I noticed this inconsistency in sum(1),
> which seems appropriate to address before consolidation
> (see attached).
Looks fine to me. Thanks!
On Wed, Aug 25, 2021, 4:37 PM Bernhard Voelker
wrote:
> On 8/25/21 10:38 AM, Jim Meyering wrote:
> > * cfg.mk (exclude_file_name_regexp--sc_system_h_headers):
> > Add find-mount-point.h to the regexp.
>
> +1
> even better, thanks.
>
Thanks. Pushed.
>
On Tue, Aug 24, 2021 at 11:10 PM Paul Eggert wrote:
> On 8/24/21 12:42 PM, Bernhard Voelker wrote:
> > Was there a particular reason to include stdlib.h?
>
> It's needed to declare 'free', which is used by _GL_ATTRIBUTE_DEALLOC_FREE.
>
> I added "#include " so that find-mount-point.h would be an
On Tue, Aug 17, 2021 at 2:02 AM Pádraig Brady wrote:
> On 16/08/2021 22:17, Assaf Gordon wrote:
> > Hello Emil and all,
> >
> > Thanks for the clear and easily reproducible bug report.
> >
> > Attached a suggested fix.
> > Comments very welcomed,
>
> minor nit in NEWS:
> s/silently
I've just pushed this:
maint: bootstrap: remove reference to unused hash-pjw module
* bootstrap.conf (gnulib_modules): Remove hash-pjw. No longer used.
diff --git a/bootstrap.conf b/bootstrap.conf
index f55da99db..daea2824c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -128,7
On Mon, May 3, 2021 at 10:59 AM Pádraig Brady wrote:
> I noticed this issue while looking at allocation of hash structures for:
> https://bugs.gnu.org/48189
>
> Addressed with the attached.
Good catch! Thanks. That is an old bug.
Looks like I introduced it here:
TEXTUTILS-2_0_15-40-g9d0fbdaf3
On Sun, May 2, 2021 at 2:50 PM Pádraig Brady wrote:
> FYI tomorrow I'm going to push a change to
> remove the fiemap extent handling logic from cp/mv/install etc.
> (Assuming that ok with folks of course).
>
> This is only used on 10 year old linux kernels,
> (where SEEK_HOLE is not available).
>
On Sun, Apr 11, 2021 at 12:48 PM Jim Meyering wrote:
>
> On Sun, Apr 11, 2021 at 10:38 AM Pádraig Brady wrote:
> ...
> > The changes didn't introduce any new instances
> > of that const declaration style (apart from the new forward declaration),
> > but you're right w
On Sun, Apr 11, 2021 at 10:38 AM Pádraig Brady wrote:
...
> The changes didn't introduce any new instances
> of that const declaration style (apart from the new forward declaration),
> but you're right we should be consistent here.
> This seems like the perfect thing for a syntax check,
> so I
On Sun, Apr 11, 2021 at 9:10 AM Jim Meyering wrote:
>
> On Sat, Apr 10, 2021 at 8:22 PM Pádraig Brady wrote:
> > On 09/04/2021 23:51, Pádraig Brady wrote:
> > > On 09/04/2021 13:02, Carl Edquist wrote:
> > >> Dear Coreutils Maintainers,
> > >>
> &g
On Sat, Apr 10, 2021 at 8:22 PM Pádraig Brady wrote:
> On 09/04/2021 23:51, Pádraig Brady wrote:
> > On 09/04/2021 13:02, Carl Edquist wrote:
> >> Dear Coreutils Maintainers,
> >>
> >> I'd like to introduce my favorite 'ls' option, '-W', which I have been
> >> enjoying using regularly over the
On Mon, Mar 22, 2021 at 4:20 PM Bernhard Voelker
wrote:
>
> On 3/21/21 10:24 PM, Paul Eggert wrote:
> > Today I updated Coreutils to current Gnulib, [...].
>
> Thanks for getting rid of the diacrit module.
>
> The attached also updates the bootstrap script.
>
> BTW: what about a syntax-check rule
On Sat, Mar 13, 2021 at 10:19 AM Pádraig Brady wrote:
> On 13/03/2021 16:13, Pádraig Brady wrote:
>
> FYI testing on an older i3-2310M system
> shows the bottleneck is not near I/O (cat is much faster).
> A 500MiB file improves from 1.40s to 0.67s on the i3-2310M.
>
> $ time src/cksum file.in
>
On Tue, Feb 9, 2021 at 3:01 PM Pádraig Brady wrote:
...
> I agree the current behavior is less than useful because:
>
>* \r\n is common a line end combination
>* catting such a file without options causes it to display normally
>* overwriting the first char with $, loses info
>
> I
On Fri, Jan 22, 2021 at 10:37 AM Tony Fischetti
wrote:
>
> For a while, I've been using a small program I wrote (with help from a
> GPL AVL-library) to filter unsorted duplicate lines. I thought I might
> see if this can be added to `uniq` (or some other way) but I saw that
> a nearly identical
tags 45093 notabug
close 45093
stop
On Mon, Dec 7, 2020 at 9:11 AM Paul Eggert wrote:
> On 12/6/20 8:23 PM, Robert S. Kissel wrote:
> > I'm pretty sure this is a bug in the Windoze port of head and tail,
>
> You should have better luck writing directly to the people who prepared that
> port, as
On Wed, Nov 11, 2020 at 9:34 AM Pádraig Brady wrote:
> This crash was identified by Cyber Independent Testing Lab:
> https://cyber-itl.org/2020/10/28/citl-7000-defects.html
> and was introduced with commit v6.9.90-11-g4245876e2
>
> * src/ls.c (gobble_file): Ensure scontext is initialized
> in the
On Sun, Nov 8, 2020 at 1:26 PM Pádraig Brady wrote:
> On 08/11/2020 18:52, Jim Meyering wrote:
> > On Sat, Nov 7, 2020 at 2:08 PM Pádraig Brady wrote:
> >> * m4/jm-macros.m4: Check for setitimer.
> >> * src/timeout.c: Use setitimer if timer_settime is not avai
On Sat, Nov 7, 2020 at 2:08 PM Pádraig Brady wrote:
> * m4/jm-macros.m4: Check for setitimer.
> * src/timeout.c: Use setitimer if timer_settime is not available.
> * NEWS: Mention the improvement.
Thanks! The patch looks fine and I confirmed it works.
I encountered a few hurdles to make
FYI, I've just pushed this:
maint: avoid new sort.c warning from upcoming GCC11
gcc version 11.0.0 20201025 (experimental) warns that
src/sort.c:1655:1: warning: function might be candidate for attribute \
'pure' if it is known to return normally [-Wsuggest-attribute=pure]
On Mon, Oct 26, 2020 at 6:13 AM Pádraig Brady wrote:
> On 26/10/2020 10:44, Kamil Dudka wrote:
> > The workaround triggers warnings with new kernel versions in case
> > a user does not have sufficient privileges for the MTIOCGET ioctl.
> >
> > * src/dd.c (skip_via_lseek): Drop wrapper function no
While POSIX (now) actually specifies the desired behavior for rm, it
does not (yet) for chown or chgrp.
IMHO, it would be a welcome change to make chown and chgrp reject an
attempt to operate recursively on a root file system, even though
POSIX has not yet required that behavior. In a way, adding
On Mon, Jun 1, 2020 at 4:45 PM Bob Proulx wrote:
> Paul Eggert wrote:
> > * src/echo.c (main): Don’t assign pointer to bool.
> > This is well-defined in C99, but is arguably bad style
> > and Oracle Studio 12.6 complains.
> ...
> > + bool posixly_correct = !!getenv ("POSIXLY_CORRECT");
>
> Of
On Mon, May 11, 2020 at 5:43 PM Peng Yu wrote:
> Are you the author of -m? If not, maybe the author of -m should knows how
> it works with -s? If not, maybe this should be documented anyway?
Peng Yu,
Given the context of Eric's patiently instructive reply[1], your own
reply here comes across as
On Wed, Mar 18, 2020 at 11:03 AM Kaz Kylheku (Coreutils)
<962-396-1...@kylheku.com> wrote:
>
> On 2020-03-18 04:27, "Toni Uhlig (Smartphone)" via GNU coreutils General
> Discussion wrote:
> > There are a lot of failing CI jobs and nobody seems to care about.
> > Some of them seem to fail since
On Tue, Mar 10, 2020 at 12:24 PM Kaz Kylheku (Coreutils)
<962-396-1...@kylheku.com> wrote:
> On 2020-03-10 11:52, Jim Meyering wrote:
> > Otherwise, du provides no way of seeing how much of the actual disk
> > space is being used by such FS-compressed files.
>
>
[note: this was not a sparse file and I wasn't using --apparent-size]
On a 1TB local btrfs file system, I found a log file for which du
reported a size of 1.2 petabytes. Quite surprising for a moment, then
I remembered btrfs's "compression".
Should we teach du to report compressed size? Via a
On Sat, Feb 8, 2020 at 5:54 PM Jim Meyering wrote:
...
> > > Hence, my last resort suggestion: disable that warning option for all
> > > gnulib compiles. Note that simply omitting the -W... option was
> > > insufficient (probably pulled in by some high-level one), so
On Fri, Feb 7, 2020 at 5:47 AM Pádraig Brady wrote:
>
> On 06/02/2020 17:05, Jim Meyering wrote:
> > On Thu, Feb 6, 2020 at 6:03 AM Pádraig Brady wrote:
> >> On 06/02/2020 00:27, Jim Meyering wrote:
> >>> Building latest latest coreutils using latest-from-
On Thu, Feb 6, 2020 at 6:03 AM Pádraig Brady wrote:
> On 06/02/2020 00:27, Jim Meyering wrote:
> > Building latest latest coreutils using latest-from-git gcc10 evokes
> > this false positive:
> >
> > lib/careadlinkat.c: In function 'careadlinkat':
> > cc1: e
Building latest latest coreutils using latest-from-git gcc10 evokes
this false positive:
lib/careadlinkat.c: In function 'careadlinkat':
cc1: error: function may return address of local variable
[-Werror=return-local-addr]
lib/careadlinkat.c:73:8: note: declared here
73 | char
On Mon, Feb 3, 2020 at 5:28 AM Pádraig Brady wrote:
...
> Actually I think the key issue is not errno handling,
> but a logic error fixed with:
>
> @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir)
> return (ignore_fail_on_non_empty
> &&
On Sun, Feb 2, 2020 at 5:11 AM Bernhard Voelker
wrote:
> On 2020-02-02 07:32, Jim Meyering wrote:
> > FTR, here's a minimal test addition that exercises the bug. Succeeds
> > on 6.10, fails on 6.11:
>
> Minor tweak for the test ...
>
> -rmdir --ignore-fail-on-non-empty
Nice find and thank you for the patch. That's a 12-year-old bug I introduced.
I confirm: with 6.10, running this:
mkdir -p a/b && chmod a-w a && rmdir --ignore a/b
prints this and exits nonzero:
rmdir: failed to remove `a/b': Permission denied
With 6.11 and newer, it silently succeeds.
On
es the equivalent of strcmp (byte comparison). Since the two
> lines compare equal in your locale, GNU 'uniq' says there's just one line.
>
> The GNU 'uniq' behavior appears to be a consequence of this commit:
>
> commit 545c2323d493c7ed9c770d9b8e45a15db6f615bc
> Author: Jim Meyering
On Tue, Aug 6, 2019 at 5:56 PM Assaf Gordon wrote:
> On Tue, Aug 06, 2019 at 09:35:01PM +0200, Bernhard Voelker wrote:
> > On 8/2/19 9:05 AM, Jim Meyering wrote:
> > > Nice work. I've had to go through this process a few times over the
> > > years, and having thes
On Thu, Aug 1, 2019 at 7:48 PM Assaf Gordon wrote:
> While trying to find out the first version with the 'seq' bug
> (my previous email), I realized it has become quite hard to build
> old coreutils version on newer glibc system.
>
> In particular:
> 1. At some point 'gets' was removed from
On Sun, Jul 28, 2019 at 11:29 PM Assaf Gordon wrote:
...
> What do others think? If this is a desired improvement, I'll finish the
> patch with news/tests/etc.
...
> [PATCH] mv: improve ENOTEMPTY/EEXIST error message
>
> Suggested by Alex Mantel in
> https://bugs.gnu.org/36831 .
>
> $ mkdir
On Sun, Jun 9, 2019, 04:43 Pádraig Brady wrote:
> * doc/coreutils.texi (tail invocation): Update to match
> the new behavior following commit v8.23-189-gb28ff6a
> ---
> ...
> No matter which method you use, if the tracked file is determined to have
> shrunk, @command{tail} prints a message
On Wed, Mar 6, 2019 at 10:55 PM Pádraig Brady wrote:
> We plan to release coreutils-8.31 in the coming week
> so any testing you can do on various different systems between now and then
> would be most welcome.
Thanks for all the work and for yet another release.
I tried to build on Fedora 29
On Tue, Jan 29, 2019 at 9:01 PM Pádraig Brady wrote:
> On 28/01/19 19:19, Bruno Haible wrote:
> > Hi,
> >
> > Compiling coreutils on Android produces this error:
> >
> > CC src/tail.o
> > In file included from ../src/tail.c:63:
> > ../src/fs-is-local.h: In function 'is_local_fs_type':
> >
On Sat, Jan 19, 2019 at 9:27 PM Pádraig Brady wrote:
> On 13/01/19 22:16, Pádraig Brady wrote:
> > Ok I've sent a gnulib patch to support disbling VLA use with GNULIB_NO_VLA,
> > which is enabled in coreutils with the attached.
>
> Both now pushed at:
>
>
On Sat, Jan 5, 2019, 05:56 Pádraig Brady FYI I've added a link on the main coreutils page on gnu.org
> to this useful code structure overview for the coreutils
>
> http://www.maizure.org/projects/decoded-gnu-coreutils/
Nice!
On Tue, Jan 1, 2019 at 4:13 PM Assaf Gordon wrote:
>
> Hello all,
>
> I took the liberty to update the copyright years,
> based on the same patch from last year (commit ece71579):
>
> maint: update all copyright year number ranges
>
> Run "make update-copyright" and then...
>
> *
On Sun, Oct 28, 2018 at 12:59 PM Bernhard Voelker
wrote:
> On 10/28/18 1:25 PM, Jim Meyering wrote:
> > Thanks for fixing that, but...
> >
> >> - @h='same.h' re='\ > + @h='same.h' re='\ >
> > please use the "?" operator instead of an empt
On Sun, Oct 28, 2018 at 12:22 PM Bernhard Voelker
wrote:
>
> sorry, I forgot to include bug-gnulib, sending again ...
> For reference, the original change in coreutils was published here:
> https://lists.gnu.org/r/coreutils/2018-10/msg00032.html
>
> On 10/28/18 9:48 AM, Paul Eggert wrote:
> >
On Sat, Oct 20, 2018 at 8:22 PM Bernhard Voelker
wrote:
> On 10/20/18 11:32 AM, Jim Meyering wrote:
> > If you adjust your function to be:
> >
> > num_sort() { tr -s ' ' '\n' |sort -n; }
> >
> > then you can make less invasive changes like this:
On Sat, Oct 20, 2018 at 12:04 AM Bernhard Voelker
wrote:
>
> On my openSUSE:Tumbleweed system, I get a false positive test failure
> in the above 'check-root' test because the group lists inside and
> outside the chroot have a different order:
>
> ++ chroot --userspec=berny / id -G
> ++ id -G
To trigger the bug, you'd have to run "make check" as a user with
membership in no more than one group.
I noticed that syntax highlighting was all messed up for many lines
starting there.
>From 7ff3e79312f0a9b6bf2c3198cee5c32793ca3bf8 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Dat
1 - 100 of 5559 matches
Mail list logo
