Re: Can't cross-build on macOS: clock.h

2023-10-27 Thread Jan Schaumann
Tobias Nygren wrote: > The header being used from the tools build was an unexpected surprise > but such reasons are why those ifdef guards exist. So I think it > just just be put back the way it was. The example came from > sys/atomic.h so it shouldn't be controversial. I've just reverted the la

Re: Can't cross-build on macOS: clock.h

2023-10-27 Thread Simon Burge
Valery Ushakov wrote: > On Fri, Oct 27, 2023 at 19:10:09 +1100, Simon Burge wrote: > > > isn't installed on all architectures? The original > > change was to include but then that added #ifdef magic. > > > > Since is already a system header file, wouldn't it be > > better to make sure is ins

Re: Can't cross-build on macOS: clock.h

2023-10-27 Thread Valery Ushakov
On Fri, Oct 27, 2023 at 19:10:09 +1100, Simon Burge wrote: > isn't installed on all architectures? The original > change was to include but then that added #ifdef magic. > > Since is already a system header file, wouldn't it be > better to make sure is installed everywhere? This happens whe

Re: Can't cross-build on macOS: clock.h

2023-10-27 Thread Simon Burge
Martin Husemann wrote: > On Fri, Oct 27, 2023 at 08:49:53AM +0200, Tobias Nygren wrote: > > The header being used from the tools build was an unexpected surprise > > but such reasons are why those ifdef guards exist. So I think it > > just just be put back the way it was. The example came from > >

Re: Can't cross-build on macOS: clock.h

2023-10-26 Thread Martin Husemann
On Fri, Oct 27, 2023 at 08:49:53AM +0200, Tobias Nygren wrote: > The header being used from the tools build was an unexpected surprise > but such reasons are why those ifdef guards exist. So I think it > just just be put back the way it was. The example came from > sys/atomic.h so it shouldn't be c

Re: Can't cross-build on macOS: clock.h

2023-10-26 Thread Tobias Nygren
On Fri, 27 Oct 2023 08:03:48 +0200 Adam wrote: > Greetings, > > This change: > > --- clock.h 26 Oct 2023 00:59:16 - 1.5 > +++ clock.h 26 Oct 2023 14:04:45 - 1.6 > @@ -1,4 +1,4 @@ > -/* $NetBSD: clock.h,v 1.5 2023/10/26 00:59:16 jschauma Exp $ */ > +/* $NetBSD: clock.h,v 1.6 2023/10/26 1

Can't cross-build on macOS: clock.h

2023-10-26 Thread Adam
Greetings, This change: --- clock.h 26 Oct 2023 00:59:16 - 1.5 +++ clock.h 26 Oct 2023 14:04:45 - 1.6 @@ -1,4 +1,4 @@ -/* $NetBSD: clock.h,v 1.5 2023/10/26 00:59:16 jschauma Exp $ */ +/* $NetBSD: clock.h,v 1.6 2023/10/26 14:04:45 jschauma Exp $ */ /*- * Copyright (c) 1996 The NetBSD