Re: [PATCH cygport] Add customization support for announce command

2024-05-01 Thread Christian Franke via Cygwin-apps
Adam Dinwoodie via Cygwin-apps wrote: On Tue, Apr 30, 2024 at 12:27:35PM +0200, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 10/03/2024 16:33, Christian Franke via Cygwin-apps wrote: +    /bin/bash -c "cd ${top} || exit 1 +${HOMEPAGE+HOMEPAGE=${HOMEPAGE@Q}} +P=${P@Q}; PF

Re: [PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-05-01 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-04-30 15:07, Christian Franke via Cygwin-apps wrote: Brian Inglis via Cygwin-apps wrote: On 2024-04-30 11:45, Christian Franke via Cygwin-apps wrote: The new script uses the SPDX webpages to create the license file. I didn't find a usable single

Re: [PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-04-30 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-04-30 11:45, Christian Franke via Cygwin-apps wrote: ... Attached. The new script uses the SPDX webpages to create the license file. I didn't find a usable single license list at https://github.com/spdx What about: https://spdx.github.io

[PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-04-30 Thread Christian Franke via Cygwin-apps
2001 From: Christian Franke Date: Tue, 30 Apr 2024 19:28:01 +0200 Subject: [PATCH] Add check of SPDX expression provided by LICENSE variable The new script 'tools/spdx-checks' checks a SPDX license expression. License identifiers are provided by the new file 'spdx-licenses' which could be created by

Re: [PATCH cygport] Add customization support for announce command

2024-04-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 10/03/2024 16:33, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due

Re: [PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-04-28 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: _FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 13.2.1 test release. Silently falls back to level 2 if level 3 is unsupported (older headers or gcc) or to level 0 if unsupported at all (C++, clang

Re: [ITP] afflib 3.7.20-1

2024-03-22 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: marco atzeri wrote: On Wed, Mar 6, 2024 at 11:26 PM Christian Franke via Cygwin-apps  wrote: ... Should I also rename libtsk to libtsk19 in the planned sleutkit-*-2 package which will add afflib support ? yes please The original package is only a few days old and has

Re: [ITP] afflib 3.7.20-1

2024-03-21 Thread Christian Franke via Cygwin-apps
On Wed, 6 Mar 2024 23:26:05 +0100, Christian Franke wrote: Jon Turney wrote: ... be added only when needed for new not backward compatible releases. The upstream afflib project is mostly idling, so I don't expect any new major lib versions in the near future. If course, I could rename

[ITP] mandoc 1.14.6-1

2024-03-11 Thread Christian Franke via Cygwin-apps
I would like to contribute mandoc. Also present in Debian, Fedora, Ubuntu, ... and as the default man page formatter on *BSD. Useful to check man pages for compatibility with *BSD systems. The build is reproducible without the need to export SOURCE_DATE_EPOCH. SUMMARY="BSD mandoc compiler

[PATCH cygport] Add repro-finish command

2024-03-11 Thread Christian Franke via Cygwin-apps
and expressions. Any interest to add this to cygport and then check LICENSE settings? -- Regards, Christian From b08796262308cf1b3a2c063349d024a5ccfd2455 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 11 Mar 2024 12:12:32 +0100 Subject: [PATCH] Add repro-finish command This command removes

Re: [PATCH cygport] Add customization support for announce command

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due to the hard-coded email submission. The attached patch adds more flexibility

Re: [PATCH cygport] dodoc: Skip a file if a compressed version already exists

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 01/03/2024 13:13, Christian Franke via Cygwin-apps wrote: It IMO makes sense to compress large and rarely viewed doc files like change logs. This seems to be common practice on Debian etc. With current cygport, the following results in ChangeLog and ChangeLog.gz

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 26/02/2024 19:53, Christian Franke via Cygwin-apps wrote: Would it not make more sense to just re-export it if set? If the cygport file decides to set but not export it, there is possibly no need to do it. An example is smartmontools.cygport which passes

[ITP] bmake 20240301-1

2024-03-09 Thread Christian Franke via Cygwin-apps
I would like to contribute bmake. Also present in Debian, Fedora, FreeBSD, Ubuntu, ... I occasionally use it to check whether Makefiles are compatible with non-GNU versions of make. SUMMARY="Portable version of the NetBSD 'make' utility" DESCRIPTION="\ bmake is a portable version of the

Re: [ITP] afflib 3.7.20-1

2024-03-08 Thread Christian Franke via Cygwin-apps
marco atzeri wrote: On Wed, Mar 6, 2024 at 11:26 PM Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 06/03/2024 15:39, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package do

Re: [ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 06/03/2024 15:39, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package doesn't include the soversion, i.e. why not libafflib0? Libtsk and libafflib are my first li

Re: [ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package doesn't include the soversion, i.e. why not libafflib0? Libtsk and libafflib are my first library packages, so I'm not sure what the policy is. My recent package libtsk has been

[ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
I would like to contribute afflib. Also present in Debian, Fedora, Ubuntu, ... but package naming differs: Debian/Ubuntu: afflib-tools, libafflib0v5, libafflib-dev Fedora: afftools, afflib, afflib-devel It is indented to enable afflib format support for the next version of the sleuthkit

Re: [ITP] sleuthkit 4.12.1

2024-03-02 Thread Christian Franke via Cygwin-apps
Hi Marco, Marco Atzeri via Cygwin-apps wrote: On 02/03/2024 13:05, Christian Franke via Cygwin-apps wrote: I would like to contribute sleuthkit. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Tools for analysis of volume and filesystem data" DESCRIPTION="The

[ITP] sleuthkit 4.12.1

2024-03-02 Thread Christian Franke via Cygwin-apps
I would like to contribute sleuthkit. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Tools for analysis of volume and filesystem data" DESCRIPTION="The Sleuth Kit (TSK) is a collection of command line tools for disk images.  It allows to analyze volume and filesystem data, examine disk

Re: [PATCH cygport] Add repro-check command

2024-03-01 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: This could be used to check whether a package is possibly reproducible. Then it could make sense to add a reasonable SOURCE_DATE_EPOCH value to the cygport file. Example: $ export SOURCE_DATE_EPOCH=$(date +%s) $ cygport project.cygport all repro-check ... *** Info

[PATCH cygport] dodoc: Skip a file if a compressed version already exists

2024-03-01 Thread Christian Franke via Cygwin-apps
e/doc/${PN}/ChangeLog" } The attached patch fixes this and also adds some missing documentation. -- Regards, Christian From 1934651b93cda92207429ac91b964cff220c76d5 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 1 Mar 2024 13:56:45 +0100 Subject: [PATCH] dodoc: Skip a file if a

Re: [PATCH cygport] Set TZ=UTC if SOURCE_DATE_EPOCH is used

2024-02-28 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: Further tests of 'repro-check' patch revealed that the "origsrc/*" timestamps in patch files contain the local timezone offset. This would be no longer needed for patch files if "Modify origsrc timestamp in patch files if SOURCE_DATE_EPOCH is used&qu

[PATCH cygport] Modify origsrc timestamp in patch files if SOURCE_DATE_EPOCH is used

2024-02-28 Thread Christian Franke via Cygwin-apps
Found during testing of 'repro-check' patch with getent-2.18.90-5 source package. This patch also removes the requirement to set TZ=UTC before patches are generated. -- Regards, Christian From 342ff5113499a83b2ffda441ddc80b4952b400f8 Mon Sep 17 00:00:00 2001 From: Christian Franke Date

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-26 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 16/02/2024 12:29, Christian Franke via Cygwin-apps wrote: Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not exported. What is the valid range here? The range accepted by 'date -d @EPOCH ...', later used to adjust

[PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script

2024-02-23 Thread Christian Franke via Cygwin-apps
Harmless bug ... -- Regards, Christian From b1074f4cfe549c852be7fa59d85d312c9579cf0d Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 23 Feb 2024 13:04:21 +0100 Subject: [PATCH] Fix variable expansion in error message of embedded SMTP perl script --- lib/pkg_upload.cygpart | 2

Re: [PATCH cygport] Add customization support for announce command

2024-02-23 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due to the hard-coded email submission. The attached patch adds more flexibility. The patch is on top of the "Use correct wording if only one package is anno

Re: [PATCH cygport] Use correct wording if only one package is announced

2024-02-23 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-02-21 07:25, Christian Franke via Cygwin-apps wrote: Change variable name from $s to $has or $s_have as variable $s usually implies only the plural letter s or nothing; e.g. ... +    local has="s have" + +    [ $pkg_count != 1 ] ||

[PATCH cygport] Add customization support for announce command

2024-02-21 Thread Christian Franke via Cygwin-apps
quot;1,/^\$/d" "$1" >$PF-announcement.txt && echo "Announcement placed here: $(pwd)/$PF-announcement.txt" ' ANNOUNCE_TO_CMD=' /usr/local/sbin/custom-mailer \   --sender="$SMTP_SENDER" \   --smarthost="$SMTP_SERVER" \   ...more...options... \   cygwin-a

[PATCH cygport] Use correct wording if only one package is announced

2024-02-21 Thread Christian Franke via Cygwin-apps
Only cosmetic ... -- Regards, Christian From f1381ebc872f3b099c257677e2b8d5bf2451bb23 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Wed, 21 Feb 2024 13:35:14 +0100 Subject: [PATCH] Use correct wording if only one package is announced --- lib/pkg_upload.cygpart | 5 - 1 file

[PATCH cygport] Set TZ=UTC if SOURCE_DATE_EPOCH is used

2024-02-20 Thread Christian Franke via Cygwin-apps
flict resolution due to the then missing 'else' branch. -- Regards, Christian From e9553d8541f9fb2fd4a4e49a488dfc8511fb9c8e Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 20 Feb 2024 10:32:52 +0100 Subject: [PATCH] Set TZ=UTC if SOURCE_DATE_EPOCH is used --- bin/cygport.in | 4 +++

[PATCH cygport] Add repro-check command

2024-02-18 Thread Christian Franke via Cygwin-apps
17 00:00:00 2001 From: Christian Franke Date: Sun, 18 Feb 2024 16:33:07 +0100 Subject: [PATCH] Add repro-check command This command checks for reproducibility of distribution packages. The source package from the dist directory is unpacked to the temp directory. A nested rebuild of the packages

[ITP] f3 8.0

2024-02-17 Thread Christian Franke via Cygwin-apps
I would like to contribute f3. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Test real flash memory capacity" DESCRIPTION="f3 is a simple tool that tests flash cards capacity and performance to see if they live up to claimed specifications. It fills the device with pseudorandom data and

[PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-16 Thread Christian Franke via Cygwin-apps
From b04c8f5e9becd6e91095e2add551f72870c9e869 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 16 Feb 2024 13:16:06 +0100 Subject: [PATCH] Add more checks of SOURCE_DATE_EPOCH Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not exported

Re: [PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-02-04 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 02/02/2024 16:13, Christian Franke via Cygwin-apps wrote: _FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 13.2.1 test release. Silently falls back to level 2 if level 3 is unsupported (older headers or gcc) or to level 0 if unsupported at all (C

[PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-02-02 Thread Christian Franke via Cygwin-apps
Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 2 Feb 2024 17:00:18 +0100 Subject: [PATCH] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS This enables buffer overflow checks if the buffer size is non-const but known during runtime and GCC 12.0 or later is used. --- lib

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-10-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 28/08/2023 16:12, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: A small step towards reproducible packaging... Thanks very much for this. Sorry for taking so long to look at it. No problem. A few questions and suggestions interspersed

Re: cygport may not create debug info if top directory contains a symlink

2023-10-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 20/09/2023 11:58, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-18 04:41, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote

[PATCH rebase] Fix handling of unset PE checksums

2023-10-09 Thread Christian Franke via Cygwin-apps
855be8d72a1f96d0a3cfcb0a97fbe12a9a912748 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 9 Oct 2023 09:56:05 +0200 Subject: [PATCH] Fix handling of unset PE checksums Leave unset (zero) checksums as is unless checksum update is explicitly requested. Remove misleading peflags warning 'Checksum update failed'. Signed

Re: cygport may not create debug info if top directory contains a symlink

2023-09-20 Thread Christian Franke via Cygwin-apps
Brian Inglis wrote: On 2023-09-18 04:41, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote: Found during tests of busybox package: If the path of the top build directory

Re: cygport may not create debug info if top directory contains a symlink

2023-09-18 Thread Christian Franke via Cygwin-apps
Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote: Found during tests of busybox package: If the path of the top build directory contains a symlink and the project's build scripts normalize pathnames, no debug

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-29 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: If the build-path changes, more files differ (cygcheck.exe, ldd.exe, cygserver.exe) because __FILE__ is used and expands to an absolute path name. This could be fixed by adding -fmacro-prefix and/or -ffile-prefix arguments

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-28 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: A small step towards reproducible packaging... Currently only tested with upcoming smartmontools package - contains only exe, man, doc files (no dll, lib, ...). Multiple cygport runs produce binary identical distribution tarballs if SOURCE_DATE_EPOCH (from the past

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-24 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: If binutils, gzip and tar also would support this, the patch would be empty :-) GZip has -n though ... For gzip I decided to keep the timestamp and use (the GNU version of) touch instead. and GNU tar --mtime

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-24 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2023-08-23 11:39, Christian Franke via Cygwin-apps wrote: A small step towards reproducible packaging... Currently only tested with upcoming smartmontools package - contains only exe, man, doc files (no dll, lib, ...). Multiple cygport runs produce

[PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-23 Thread Christian Franke via Cygwin-apps
in the cygport file. -- Regards, Christian From 146b1df83a20ccd71e57d6123c7ee24b8390ca3a Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Wed, 23 Aug 2023 19:27:02 +0200 Subject: [PATCH] Add initial support for SOURCE_DATE_EPOCH If specified, ensure that the header timestamps of executables

Re: [PATCH rebase 1/2] Always update the file checksum in the PE header

2023-08-15 Thread Christian Franke via Cygwin-apps
Corinna Vinschen wrote: On Aug 12 14:26, Christian Franke via Cygwin-apps wrote: This patch is still experimental, but tested with all /bin/cyg*.dll from my installation. Does that mean I shouldn't apply it for now, or do you want me to apply it but not create a new release yet? Meantime I

[PATCH rebase 2/2] rebase: Don't update the PE header timestamp unless -t is used

2023-08-12 Thread Christian Franke via Cygwin-apps
This changes existing behavior but a new option --keep-timestamp is IMO not needed. -- Regards, Christian From 1c13ccb047ebfbcd2f239bedcd50a128fec659e9 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 12 Aug 2023 14:17:04 +0200 Subject: [PATCH] rebase: Don't update the PE header

[PATCH rebase 1/2] Always update the file checksum in the PE header

2023-08-12 Thread Christian Franke via Cygwin-apps
This patch is still experimental, but tested with all /bin/cyg*.dll from my installation. -- Regards, Christian From 53663d46c2c989e665143b33c0614b416fd1c666 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 12 Aug 2023 14:13:43 +0200 Subject: [PATCH] Always update the file checksum

Re: [PATCH rebase] rebase: Add -c, --checksum option

2023-08-08 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 08/08/2023 11:10, Christian Franke via Cygwin-apps wrote: Last patch for now. Left for later: ReBaseImage64() unconditionally updates the timestamp in the file header. Just for clarity: does this mean that rebasing as it is currently implemented leaves the PE file

[PATCH rebase] rebase: Add -c, --checksum option

2023-08-08 Thread Christian Franke via Cygwin-apps
Last patch for now. Left for later: ReBaseImage64() unconditionally updates the timestamp in the file header. -- Regards, Christian From 3973a92cf11056521552d9d3f87efe8e721e8c31 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 8 Aug 2023 12:04:25 +0200 Subject: [PATCH] rebase: Add

[PATCH rebase] Add missing pechecksum.* to SRC_DISTFILES

2023-08-08 Thread Christian Franke via Cygwin-apps
Missed yesterday, sorry. -- Regards, Christian From 84065da466d9501d0522af8860ea829ee51c12f5 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 8 Aug 2023 10:52:14 +0200 Subject: [PATCH] Add missing pechecksum.* to SRC_DISTFILES Signed-off-by: Christian Franke --- Makefile.in | 3

Re: [PATCH rebase] peflags: Fix ULONG range checks

2023-08-08 Thread Christian Franke via Cygwin-apps
Corinna Vinschen wrote: On Aug 8 10:06, Christian Franke via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps wrote: Hi Christian, On Aug 7 16:07, Christian Franke via Cygwin-apps wrote: Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian

Re: [PATCH rebase] peflags: Fix ULONG range checks

2023-08-08 Thread Christian Franke via Cygwin-apps
Corinna Vinschen via Cygwin-apps wrote: Hi Christian, On Aug 7 16:07, Christian Franke via Cygwin-apps wrote: Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian ... diff --git a/peflags.c b/peflags.c index 93eaa0b..d98b121 100644

[PATCH rebase 2/2] peflags: Add -k, --checksum option

2023-08-07 Thread Christian Franke via Cygwin-apps
This patch is on top of the --timestamp patch. Could not be applied to current HEAD without conflicts. -- Regards, Christian From 9ecaf86bff5d229bf5b2a1ba1ff4674526fc1b68 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 7 Aug 2023 15:52:14 +0200 Subject: [PATCH] peflags: Add -k

[PATCH rebase 1/2] peflags: Add -p, --timestamp option

2023-08-07 Thread Christian Franke via Cygwin-apps
:00 2001 From: Christian Franke Date: Mon, 7 Aug 2023 14:02:12 +0200 Subject: [PATCH] peflags: Add -p, --timestamp option This allows to set the header timestamp to 0 or some other fixed value (SOURCE_DATE_EPOCH) to support reproducible builds. Signed-off-by: Christian Franke --- peflags.c | 29

[PATCH rebase] peflags: Fix ULONG range checks

2023-08-07 Thread Christian Franke via Cygwin-apps
Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian From 9da405da78e92dc8263239e25365bee3167f185e Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 7 Aug 2023 13:42:50 +0200 Subject: [PATCH] peflags: Fix ULONG range checks Don't use

Re: [PATCH setup] Keyboard accelerator for keep or skip

2023-07-31 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 25/04/2023 18:00, Christian Franke via Cygwin-apps wrote: Use case: Easily prevent update of multiple packages in the "Pending" view, in particular useful if "Test" is selected. Sorry for the delay in looking at this.  Obviously needed. N.P. Please apply. Done.

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: ... Using std::set_intersection() on values from std::map() here is probably a mistake. It's simple to write, but the performance is not good. A faster alternative which avoids set_intersection calls in a loop is possibly to use one large data structure which maps

[PATCH setup] Keyboard accelerator for keep or skip

2023-04-25 Thread Christian Franke via Cygwin-apps
Use case: Easily prevent update of multiple packages in the "Pending" view, in particular useful if "Test" is selected. -- Regards, Christian From 05d9c72f07cf754dc6172a998b2e0991034d363f Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 25 Apr 2023 18:42:18 +

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-24 Thread Christian Franke via Cygwin-apps
Jon Turney via Cygwin-apps wrote: Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable IMO a useful enhancement. Notes: Reading file catalog from a package is

Re: [PATCH setup] Add tooltip for Ctrl+I/R/U accelerator keys

2023-02-02 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 22/11/2022 16:00, Christian Franke wrote: This is a first try to make these keys more obvious as requested on the Cygwin ML. A more complex approach would be to mention only the keys which actually would change the current package state. Thanks for this patch. So, I

Re: [PATCH setup] Ignore reinstall requests if version is not accessible

2022-12-16 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 11/12/2022 15:11, Christian Franke via Cygwin-apps wrote: This prevents accidental package loss if reinstall is run from local directory but the package is no longer cached. Thanks.  This seems right, so please apply. Done. Could you please also review "[PATCH

[PATCH setup] Ignore reinstall requests if version is not accessible

2022-12-11 Thread Christian Franke via Cygwin-apps
7 00:00:00 2001 From: Christian Franke Date: Sun, 11 Dec 2022 15:55:47 +0100 Subject: [PATCH] Ignore reinstall requests if version is not accessible --- package_meta.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package_meta.cc b/package_meta.cc index 2257b59..3daa

Re: [Bug] setup regression #2

2022-11-30 Thread Christian Franke
Jon Turney wrote: On 20/11/2022 19:05, Achim Gratz wrote: Jon Turney writes: I believe that the intent of the code in setup is that there should only be two modes: USER: install "for me", with the users primary group As I understand it, the intention here was that the user can have a

Re: [PATCH setup] Add new option --chown-admin

2022-11-30 Thread Christian Franke
Jon Turney wrote: On 04/10/2022 13:05, Christian Franke wrote: Jon Turney wrote: Corinna had some concerns about making the owner a group, rather than a user, which I believe historically caused some difficulties in Cygwin, so I think I'll need to understand that better before making

[PATCH setup] Add tooltip for Ctrl+I/R/U accelerator keys

2022-11-22 Thread Christian Franke
From: Christian Franke Date: Tue, 22 Nov 2022 16:38:39 +0100 Subject: [PATCH] Add tooltip for Ctrl+I/R/U accelerator keys Tooltip is shown for "New" column of selected row. --- ListView.cc | 3 ++- ListView.h | 2 +- PickCategoryLine.cc | 2 +- PickCategoryL

Re: [PATCH setup] Add new option --chown-admin

2022-10-04 Thread Christian Franke
Jon Turney wrote: On 02/09/2022 16:17, Christian Franke wrote: Jon Turney wrote: On 28/08/2022 18:33, Christian Franke wrote: As the 'root_scope' issues are now fixed, here a reworked and enhanced (checkbox, setup.rc entry) version of the original patch from this thread. With the new

Re: [Bug] setup regression

2022-10-04 Thread Christian Franke
Jon Turney wrote: On 27/09/2022 14:51, Christian Franke wrote: Christian Franke wrote: ... I made the false assumption that default_version=empty in set_action() always implies that the default version is not accessible. This is not the case for packages selected for installation before

Re: [Bug] setup regression

2022-09-27 Thread Christian Franke
Christian Franke wrote: ... I made the false assumption that default_version=empty in set_action() always implies that the default version is not accessible. This is not the case for packages selected for installation before chooser is visible. I'm working on a new fix for the "C

Re: [Bug] setup regression

2022-09-26 Thread Christian Franke
current version is not accessible" case. The correct logic is already in toggle_action(): Install the most recent accessible non-test ('naively_preferred') version. From 54665f0596f8ca50eff99ec8ec35970dc5fd439d Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 26 Sep 2022 16:47:42 +0200 Subject:

Re: [PATCH setup] Add new option --chown-admin

2022-09-02 Thread Christian Franke
Jon Turney wrote: On 28/08/2022 18:33, Christian Franke wrote: As the 'root_scope' issues are now fixed, here a reworked and enhanced (checkbox, setup.rc entry) version of the original patch from this thread. With the new setting enabled, setup behaves like other install tools when run

Re: [PATCH setup] Add new option --chown-admin

2022-08-28 Thread Christian Franke
-files package if desired. -- Regards, Christian From 6d996b377b4a6a908fbb4c217bda24249b4b58c1 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sun, 28 Aug 2022 19:23:44 +0200 Subject: [PATCH] Optionally change owner of installed files to local administrator Could be selected via new

Re: [PATCH setup] Add new option --chown-admin

2022-08-26 Thread Christian Franke
Jon Turney wrote: On 23/08/2022 18:27, Christian Franke wrote: Jon Turney wrote: On 12/07/2022 13:50, Jon Turney wrote: [Replying to the right list this time...] On 09/07/2022 13:21, Christian Franke wrote: [...] The UserSettings ctor has a somewhat hidden side effect which sets

Re: [PATCH setup] Add new option --chown-admin

2022-08-23 Thread Christian Franke
Jon Turney wrote: On 12/07/2022 13:50, Jon Turney wrote: [Replying to the right list this time...] On 09/07/2022 13:21, Christian Franke wrote: [...] The UserSettings ctor has a somewhat hidden side effect which sets root_scope correctly:   UserSettings::UserSettings

Re: [PATCH setup] Keyboard accelerators for install/reinstall/uninstall

2022-08-23 Thread Christian Franke
Jon Turney wrote: On 22/08/2022 16:29, Christian Franke wrote: Jon Turney wrote: On 14/08/2022 12:57, Christian Franke wrote: This eases state changes of a selected sequence of packages. Nice!  The keyboard control of the package chooser was a bit of an after-thought, which it really

Re: [PATCH setup] Keyboard accelerators for install/reinstall/uninstall

2022-08-22 Thread Christian Franke
Jon Turney wrote: On 14/08/2022 12:57, Christian Franke wrote: This eases state changes of a selected sequence of packages. Nice!  The keyboard control of the package chooser was a bit of an after-thought, which it really shouldn't be. Thanks - revised patch is attached. Ctrl+U

Re: [PATCH setup] Add view mode "Unneeded"

2022-08-15 Thread Christian Franke
Jon Turney wrote: On 02/08/2022 13:17, Christian Franke wrote: In long standing cygwin installations, many no longer needed automatically installed packages (e.g. libicuNN) accumulate. This patch adds a new view which is possibly helpful to cleanup packages manually. Some possible later

[PATCH setup] Keyboard accelerators for install/reinstall/uninstall

2022-08-14 Thread Christian Franke
ctionality more obvious. -- Regards, Christian From 71da4fbc68022b5083eba0cbdf2c0a4a541ddf1c Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sun, 14 Aug 2022 13:43:48 +0200 Subject: [PATCH] Keyboard accelerators for install/reinstall/uninstall Ctrl+I/R/U select install/reinstall

[PATCH setup] Add view mode "Unneeded"

2022-08-02 Thread Christian Franke
the user changed a package status as this may add or remove entries. - add a keyboard shortcut (^U) to the list view for "Uninstall this package and then select next package" -- Regards, Christian From 07a2e561b7ba19817a0bebb2cbf542a9b18a6d4e Mon Sep 17 00:00:00 2001 From: Christ

[PATCH rebase] Print list of DLLs which still overlap after rebasing + Fix index ...

2022-07-19 Thread Christian Franke
hat's all for now. Thanks, Christian From c6e050fa69552e023d18df2cf1255a2a827f1bcc Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 19 Jul 2022 10:36:20 +0200 Subject: [PATCH 1/2] Print list of DLLs which still overlap after rebasing --- rebase.c | 38

Re: [PATCH rebase] Fix handling of newly added non-rebaseable DLLs

2022-07-18 Thread Christian Franke
Revised version which also handles the --oblivious case. -- Regards, Christian From 19139e1b984eb3f4d11f83e6951c66064a2f2dd3 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 18 Jul 2022 17:06:05 +0200 Subject: [PATCH] Fix handling of newly added non-rebaseable DLLs Reset

[PATCH rebase] Fix handling of newly added non-rebaseable DLLs

2022-07-18 Thread Christian Franke
The current behavior in this (possibly rare) case is misleading. -- Regards, Christian From 6a68800512ce80689efbf43e639e7c1f38371636 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 18 Jul 2022 16:07:26 +0200 Subject: [PATCH] Fix handling of newly added non-rebaseable DLLs Reset

[PATCH rebase] Ensure that no rebaseable DLL overlaps a non-rebaseable DLL

2022-07-16 Thread Christian Franke
Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 16 Jul 2022 17:55:58 +0200 Subject: [PATCH] Ensure that no rebaseable DLL overlaps a non-rebaseable DLL Restart rebase decision loop with newly sorted list if a DLL is not rebaseable. Search for all DLLs which overlap such a DLL. --- rebase.c

Re: [PATCH setup 0/2] Simplify setting group ownership of installed files

2022-07-13 Thread Christian Franke
Jon Turney wrote: Jon Turney (2): Drop group change while running postinstall scripts Defer setting group until after All Users/Just For Me is chosen main.cc| 2 +- postinstall.cc | 13 - root.cc| 5 + win32.cc | 13 ++--- win32.h

Re: [PATCH setup] Add new option --no-write-registry

2022-07-12 Thread Christian Franke
Jon Turney wrote: On 09/07/2022 16:59, Christian Franke wrote: IMO useful for temporary test installs or "portable" installs to USB devices. The 0002-patch adds a related log message. These patches are ok. If you can provide a help-text for the new option, I will apply them. At

[PATCH setup] Add new option --no-write-registry

2022-07-09 Thread Christian Franke
STEM : IDC_ROOT_USER; ... } -- Regards, Christian From ab3c94ebf0e78606c3660bec8e0c04c6e6b8ddd4 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 9 Jul 2022 16:52:47 +0200 Subject: [PATCH 1/2] Add new option --no-write-registry If specified, the rootdir is not written to the registry and no registry key i

Re: [PATCH setup] Add new option --chown-admin

2022-07-07 Thread Christian Franke
Christian Franke wrote: It does fix the regression, it adds a new installation flavor which fixes it as a side effect. It does *not* fix the regression, of course

Re: [PATCH setup] Add new option --chown-admin

2022-07-07 Thread Christian Franke
Jon Turney wrote: On 06/07/2022 17:34, Christian Franke wrote: Jon Turney wrote: On 06/07/2022 08:14, Christian Franke wrote: If an installer is run elevated, the installed files will be typically owned by the local administrator (or in some cases SYSTEM or TrustedInstaller) instead

Re: [PATCH setup] Add new option --chown-admin

2022-07-06 Thread Christian Franke
Jon Turney wrote: On 06/07/2022 08:14, Christian Franke wrote: If an installer is run elevated, the installed files will be typically owned by the local administrator (or in some cases SYSTEM or TrustedInstaller) instead of the current user. This is not the case for a Cygwin "All

Re: New version of GNU ddrescue available (1.26)

2022-07-06 Thread Christian Franke
Hamish McIntyre-Bhatty wrote: On 05/07/2022 10:22, Christian Franke wrote: Hamish McIntyre-Bhatty wrote: I was wondering if the maintainer for GNU ddrescue could update to 1.26 please? 1.27-pre2 is already released, so I wait for 1.27 final. Fair enough. Do you know if there's a mailing

[PATCH setup] Add new option --chown-admin

2022-07-06 Thread Christian Franke
rds, Christian From 1dfc8d63a8438e42544b06cfdf225f222107eed2 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Wed, 6 Jul 2022 07:41:18 +0200 Subject: [PATCH] Add new option --chown-admin If specified and the process token owner is the local administrator, the owner is preserved and the primary group is set to the local

Re: New version of GNU ddrescue available (1.26)

2022-07-05 Thread Christian Franke
Hamish McIntyre-Bhatty wrote: I was wondering if the maintainer for GNU ddrescue could update to 1.26 please? 1.27-pre2 is already released, so I wait for 1.27 final. -- Regards, Christian

Re: SFTP release directories missing

2022-07-03 Thread Christian Franke
Christian Franke wrote: Adam Dinwoodie wrote: I'm currently seeing attempts to run `cygport stage` fail with an error "cd: Access failed: No such file (/x86_64/release)". And logging in manually over sftp, that looks to be accurate; the only file I can see is my !mail file. ``` $

Re: SFTP release directories missing

2022-07-02 Thread Christian Franke
Adam Dinwoodie wrote: I'm currently seeing attempts to run `cygport stage` fail with an error "cd: Access failed: No such file (/x86_64/release)". And logging in manually over sftp, that looks to be accurate; the only file I can see is my !mail file. ``` $ echo $'ls\npwd\n' | sftp

Re: [ITP] etckeeper 1.18.17-1

2022-07-02 Thread Christian Franke
Adam Dinwoodie wrote: On Wed, Jun 29, 2022 at 09:55:10AM +0200, Christian Franke wrote: Christian Franke wrote: ... A possible simple extension which would allow the user to choose between manual or automatic installation+initialization: Provide an optional package, for example "etck

Re: [PATCH setup] Add perpetual support for preremove scripts

2022-07-01 Thread Christian Franke
Christian Franke wrote: Jon Turney wrote: ... Can you please also write a patch for [1] (source in [2]) to document this? [1] https://cygwin.com/packaging-package-files.html#postinstall [2] https://cygwin.com/git/?p=cygwin-htdocs.git;a=blob;f=packaging-package-files.html Of course. I

[ITP] pass 1.7.4-1 (password-store)

2022-07-01 Thread Christian Franke
I would like to contribute pass (password-store): https://www.passwordstore.org/ https://repology.org/project/password-store/versions pass-1.7.4-1.hint: category: Utils requires: bash coreutils grep sed tree sdesc: "Lightweight CLI directory-based password manager" ldesc: "Pass is a command

Re: [PATCH setup] Add perpetual support for preremove scripts

2022-06-29 Thread Christian Franke
Christian Franke wrote: Jon Turney wrote: On 26/06/2022 17:33, Christian Franke wrote: ... This patch adds the missing functionality to run the pre-install hook. It is limited to /etc/preremove/0p_* because there is possibly no use case for /etc/preremove/zp_*. Thanks. I'm not sure what

Re: [PATCH setup] Add perpetual support for preremove scripts

2022-06-29 Thread Christian Franke
Jon Turney wrote: On 26/06/2022 17:33, Christian Franke wrote: Use case: I ITP etckeeper (https://etckeeper.branchable.com/) which I frequently use on Debian. For fully automatic operation, it requires pre-install and post-install hooks, e.g: /etc/preremove/0p_000_etckeeper_pre-install.sh

  1   2   3   >