Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Igor Pechtchanski
Ping... Igor On Tue, 25 Mar 2003, Igor Pechtchanski wrote: On 26 Mar 2003, Robert Collins wrote: On Wed, 2003-03-26 at 02:11, Igor Pechtchanski wrote: Do I need to regenerate this against HEAD once Max checks in the postinstall thread patch? Yes, and I'll review it then.

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Robert Collins
On Tue, 2003-04-01 at 02:42, Igor Pechtchanski wrote: Ping... Igor Pong. Uhmm, try_run_script is always called with to_log true. So, why have the parameter there at all? Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc Description: This is a

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Robert Collins
On Tue, 2003-04-01 at 08:02, Igor Pechtchanski wrote: On 1 Apr 2003, Robert Collins wrote: On Tue, 2003-04-01 at 02:42, Igor Pechtchanski wrote: Ping... Igor Pong. Uhmm, try_run_script is always called with to_log true. So, why have the parameter there at all? Rob

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Igor Pechtchanski
On 1 Apr 2003, Robert Collins wrote: On Tue, 2003-04-01 at 08:02, Igor Pechtchanski wrote: On 1 Apr 2003, Robert Collins wrote: Uhmm, try_run_script is always called with to_log true. So, why have the parameter there at all? Rob Umm, for symmetry? If you ever wanted to turn off

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Robert Collins
On Tue, 2003-04-01 at 09:31, Igor Pechtchanski wrote: Rob, The reason I wanted to keep the to_log parameter is that I wanted to keep the code around that directs output to console. If there are no objections, I'll just make the default value of to_log TRUE, and remove the third

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-31 Thread Igor Pechtchanski
On 1 Apr 2003, Robert Collins wrote: On Tue, 2003-04-01 at 09:31, Igor Pechtchanski wrote: Rob, The reason I wanted to keep the to_log parameter is that I wanted to keep the code around that directs output to console. If there are no objections, I'll just make the default value of

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-25 Thread Igor Pechtchanski
Umm... Ping?.. Do I need to regenerate this against HEAD once Max checks in the postinstall thread patch? It should apply with fuzz even then. Igor On Fri, 21 Mar 2003, Igor Pechtchanski wrote: This patch extends logging support to preremove/postremove scripts. Igor

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-25 Thread Robert Collins
On Wed, 2003-03-26 at 02:11, Igor Pechtchanski wrote: Umm... Ping?.. Do I need to regenerate this against HEAD once Max checks in the postinstall thread patch? Yes, and I'll review it then. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-25 Thread Igor Pechtchanski
On 26 Mar 2003, Robert Collins wrote: On Wed, 2003-03-26 at 02:11, Igor Pechtchanski wrote: Do I need to regenerate this against HEAD once Max checks in the postinstall thread patch? Yes, and I'll review it then. Rob Ok, here you go. Igor

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-24 Thread Brian Keener
Igor Pechtchanski wrote: This patch extends logging support to preremove/postremove scripts. Igor = Igor, gave the patch a shot on my Win2k and Win95 laptops and reinstalling gcc-mingw an inetutils and the Command window seems to be gone but other than the reference to

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-24 Thread Igor Pechtchanski
Brian, Replies inline below. On Mon, 24 Mar 2003, Brian Keener wrote: Igor Pechtchanski wrote: This patch extends logging support to preremove/postremove scripts. Igor = Igor, gave the patch a shot on my Win2k and Win95 laptops and reinstalling gcc-mingw an

Re: [PATCH] Allow logging of {pre,post}remove scripts

2003-03-24 Thread Brian Keener
Igor, My apologies - all is well - see below. Igor Pechtchanski wrote: I'm not sure I understand the above, though - was the preremove script logged or wasn't it? The gcc-mingw preremove script's output should be the following one line: *** Removing gcc-mingw files. Please wait. *** and

[PATCH] Allow logging of {pre,post}remove scripts

2003-03-21 Thread Igor Pechtchanski
This patch extends logging support to preremove/postremove scripts. Igor == 2003-03-18 Igor Pechtchanski [EMAIL PROTECTED] * script.cc (try_run_script): Add optional to_log boolean parameter.