Re: Integrating Ralf's rebase into setup.exe

2003-01-31 Thread Jason Tishler
Ralf, On Fri, Jan 31, 2003 at 12:23:55AM +0100, Ralf Habacker wrote: > Applied and checked in. Thanks! Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6

RE: Integrating Ralf's rebase into setup.exe

2003-01-30 Thread Ralf Habacker
> The attached fixes the following: > > 1. merge problem when you applied (by hand?) the following patch: > >http://cygwin.com/ml/cygwin/2002-12/msg00138.html > > 2. bug I introduced in the above patch when I attempted but did >not successfully fix rebasing up > > #1 cau

Re: Integrating Ralf's rebase into setup.exe

2003-01-29 Thread Jason Tishler
Ralf, On Tue, Jan 21, 2003 at 10:37:03PM +0100, Ralf Habacker wrote: > > The attached patch enables libimagehelper.a to be usable by C source > > too. > > > Applied. Thanks for fixing this. The attached fixes the following: 1. merge problem when you applied (by hand?) the following patch:

RE: Integrating Ralf's rebase into setup.exe

2003-01-21 Thread Ralf Habacker
Hi Jason, > The attached patch enables libimagehelper.a to be usable by C source > too. > Applied. Thanks for fixing this. Ralf

Re: Integrating Ralf's rebase into setup.exe

2003-01-21 Thread Jason Tishler
Ralf, On Sat, Jan 04, 2003 at 12:16:57AM +0100, Ralf Habacker wrote: > This seems mostly to be fixed in the recent cvs release. The attached patch enables libimagehelper.a to be usable by C source too. Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerp

RE: Integrating Ralf's rebase into setup.exe

2003-01-03 Thread Ralf Habacker
> > 1) some that go to stdout probably should be stderr, and vice versa. > > still open. I think debug message should go to cerr and normal printing should > go to cout. > This seems mostly to be fixed in the recent cvs release. Ralf

RE: Integrating Ralf's rebase into setup.exe

2003-01-03 Thread Ralf Habacker
> Of course, rebind_main doesn't call BindImage or BindImageEx. It does > have a commented-out call to dll.rebind() -- but > LinkedObjectFile::rebind() doesn't call BindImage() or BindImageEx > either -- LinkedObjectFile::rebind() does all of the work itself. > > Looks like the factorization isn't

RE: Integrating Ralf's rebase into setup.exe

2003-01-03 Thread Ralf Habacker
Hi Gary, > > How about "libhabackersimagehelp.a" etc? > this would suggest, that this is my lib, but there are also others who have worked and probably will work on this library. I habe only started this lib I think imagehelper will be good. Ralf

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Gary R. Van Sickle
on Tishler; [EMAIL PROTECTED] > Subject: RE: Integrating Ralf's rebase into setup.exe > > > > > If I remember right, this lib will be used for a cygwin based > > rebase and later > > > in the cygwin's setup application which is mingw based. So this >

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Charles Wilson
Ralf Habacker wrote: You have gotten me just between finishing the things. I was interrupted a little after written the last mail, so 10 minutes later is was mostly fixed. Lucky me. 5) is the 'bindimage.cc' file used at all? it is used in rebind_main.cc. You mean it *should* be used in r

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> Not really -- it doesn't compile anymore. Among other things: You have gotten me just between finishing the things. I was interrupted a little after written the last mail, so 10 minutes later is was mostly fixed. > 0) Update the changelog when you do stuff. (You renamed the library > itself

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Charles Wilson
Ralf Habacker wrote: Thats orthogonal (but IIRC is possible now/soon). The build within setup.exe will be a .a library, not a .dll. You could always use a compile flag to choose between cout error reporting and exceptions. What about the following: Step 1: library for standalone rebase Step

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> IIRC, it is not part of Mingw. > > I just used a copy of getopt.[ch] from the Cygwin sources for my stand > alone rebase. > That curious: getopt is compiled into /usr/lib/mingw/libliberty.a; only the header is missing. I've copied the header from /usr/include/getopt.h to /usr/include/mingw and it

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Jason Tishler
Ralf, On Thu, Jan 02, 2003 at 05:00:52PM +0100, Ralf Habacker wrote: > What about getopt, ... IIRC, it is not part of Mingw. I just used a copy of getopt.[ch] from the Cygwin sources for my stand alone rebase. Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Finger

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> But, they are part of Cygwin gcc in Mingw mode (i.e., gcc -mno-cygwin). > You're right. My gcc installation was corrupted. Now I can compile it. What about getopt, I can find the symbol in a library, but not the related header. ? I have installed mingw-runtime 2.2.1. Ralf

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Christopher Faylor
On Thu, Jan 02, 2003 at 04:23:08PM +0100, Ralf Habacker wrote: >> My stand alone rebase is currently a Mingw app. However, it was >> initially a Cygwin app but I switched in over to Mingw when Chuck >> pointed out that imagehlp.dll is dependent on msvcrt.dll. >> >> Now that I will be using your re

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Jason Tishler
Ralf, On Thu, Jan 02, 2003 at 04:23:08PM +0100, Ralf Habacker wrote: > > Now that I will be using your rebase functionality instead, I have > > the option to switch back to Cygwin. For various reasons, I was > > intending on keeping my stand alone rebase a Mingw app. What do > > others think? >

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> My stand alone rebase is currently a Mingw app. However, it was > initially a Cygwin app but I switched in over to Mingw when Chuck > pointed out that imagehlp.dll is dependent on msvcrt.dll. > > Now that I will be using your rebase functionality instead, I have the > option to switch back to Cy

Re: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Jason Tishler
Ralf, On Thu, Jan 02, 2003 at 10:27:12AM +0100, Ralf Habacker wrote: > If I remember right, this lib will be used for a cygwin based rebase > and later in the cygwin's setup application which is mingw based. So > this lib must be buildable for cygwin and mingw, isn't it ? My stand alone rebase is

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Robert Collins
On Thu, 2003-01-02 at 20:50, Ralf Habacker wrote: > You have already stated > > - libcygimagehlp (for cygwin applications like rebase) > > Do you mean > > - libmingwimagehlp > > for setup.exe ? I really don't care, as long as it doesn't comflict with the real imagehlp library. > What abou

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> > If I remember right, this lib will be used for a cygwin based > rebase and later > > in the cygwin's setup application which is mingw based. So this lib must be > > buildable for cygwin and mingw, isn't it ? > > Yes. And the library should use the appropriate naming convention for > the target

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Robert Collins
On Thu, 2003-01-02 at 20:31, Ralf Habacker wrote: > > Thats orthogonal (but IIRC is possible now/soon). The build within > > setup.exe will be a .a library, not a .dll. You could always use a > > compile flag to choose between cout error reporting and exceptions. > > > What about the following: >

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Robert Collins
On Thu, 2003-01-02 at 20:27, Ralf Habacker wrote: > > Rob suggested libcygimagehlp.a for the library. > > > > Should we leave the names as is, but use -L and -I to find the right > > files instead? > > > If I remember right, this lib will be used for a cygwin based rebase and later > in the cygwin'

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> Thats orthogonal (but IIRC is possible now/soon). The build within > setup.exe will be a .a library, not a .dll. You could always use a > compile flag to choose between cout error reporting and exceptions. > What about the following: Step 1: library for standalone rebase Every exported library

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> Rob suggested libcygimagehlp.a for the library. > > Should we leave the names as is, but use -L and -I to find the right > files instead? > If I remember right, this lib will be used for a cygwin based rebase and later in the cygwin's setup application which is mingw based. So this lib must be bu

RE: Integrating Ralf's rebase into setup.exe

2003-01-02 Thread Ralf Habacker
> Still missing a lot of the errors that were fixed in my patch. Here's > the remainder: > > 1) 'hex' and 'endl' are also in the std:: namespace > 2) unbind_main.cc needs 'using namespace std;' > 3) (new) rebind_main will rebind the first commandline argument over and > over; it needs to use ar

RE: Integrating Ralf's rebase into setup.exe

2003-01-01 Thread Robert Collins
On Wed, 2003-01-01 at 22:35, Ralf Habacker wrote: > > And heres a show stopper. The library should not use cout at all. It > > should throw an exception, and let the user interface handle it. > > > Does this work also, if this library is compiled as a dll ? Thats orthogonal (but IIRC is possible

RE: Integrating Ralf's rebase into setup.exe

2003-01-01 Thread Ralf Habacker
> And heres a show stopper. The library should not use cout at all. It > should throw an exception, and let the user interface handle it. > Does this work also, if this library is compiled as a dll ? Do you have an example, how to do for this ? Ralf

RE: Integrating Ralf's rebase into setup.exe

2003-01-01 Thread Ralf Habacker
> In checkimage.cc: > > - ctFile dll(filename); > + LinkedObjectFile dll(filename); > fixed. > >>README needs a brief note about this 0.6 version. > > > > > > More than I have written in my last email ? > > No, it's just that the README file itself contains some brief > descriptions of version 0.

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Robert Collins
On Wed, 2003-01-01 at 02:17, Charles Wilson wrote: > I needed to make the following changes before this would compile. > Mostly namespace errors, but also a typo and main() void vs. int. > > I figured the library files should explicitly call std::cout & friends, > but the executables could go ah

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Charles Wilson
Still missing a lot of the errors that were fixed in my patch. Here's the remainder: 1) 'hex' and 'endl' are also in the std:: namespace 2) unbind_main.cc needs 'using namespace std;' 3) (new) rebind_main will rebind the first commandline argument over and over; it needs to use argv[i] not argv

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Charles Wilson
Ralf Habacker wrote: I needed to make the following changes before this would compile. Mostly namespace errors, the std:: below or something else ? Nope, that was it. but also a typo where ? In checkimage.cc: - ctFile dll(filename); + LinkedObjectFile dll(filename); README needs a b

RE: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Ralf Habacker
> I needed to make the following changes before this would compile. > Mostly namespace errors, the std:: below or something else ? > but also a typo where ? > and main() void vs. int. fixed > I figured the library files should explicitly call std::cout & friends, fixed > but the execut

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Jason Tishler
On Tue, Dec 31, 2002 at 06:41:45PM +0100, Ralf Habacker wrote: > > However, should we use the names libimagehlp.a and imagehlp.h? They > > clash with the mingw versions. > > > Do you have a better name ? Rob suggested libcygimagehlp.a for the library. Should we leave the names as is, but use -

RE: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Ralf Habacker
> However, should we use the names libimagehlp.a and imagehlp.h? They > clash with the mingw versions. > Do you have a better name ? Ralf

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Charles Wilson
I needed to make the following changes before this would compile. Mostly namespace errors, but also a typo and main() void vs. int. I figured the library files should explicitly call std::cout & friends, but the executables could go ahead and say 'using namespace std;'. Oh, a few other niggles:

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Jason Tishler
Ralf, On Tue, Dec 31, 2002 at 02:20:36PM +0100, Ralf Habacker wrote: > - creates a static lib containing all needed objectfiles for > RebaseImage() and friends. The library is named libimagehlp.a and the > relating include file imagehlp.h. After checking out just call > > $ make imagehlp

Re: Integrating Ralf's rebase into setup.exe

2002-12-31 Thread Ralf Habacker
Hi all, relating to the this thread, which starts at http://www.cygwin.com/ml/cygwin-apps/2002-12/msg00021.html I have updated the rebase source with : - creates a static lib containing all needed objectfiles for RebaseImage() and friends. The library is named libimagehlp.a and the relating inc

Re: Integrating Ralf's rebase into setup.exe

2002-12-05 Thread Jason Tishler
Rob, On Thu, Dec 05, 2002 at 06:18:56PM +1100, Robert Collins wrote: > On Thu, 2002-12-05 at 07:59, Jason Tishler wrote: > As for design, here's what I'd like to see: > Ralfs reimplementation sites in a lib - i.e. libcygimagehlp.a - and > you and I carry on the design discussion with no change. Is

Re: Integrating Ralf's rebase into setup.exe

2002-12-04 Thread Robert Collins
On Thu, 2002-12-05 at 07:59, Jason Tishler wrote: > However, I'm concerned that you will not accept his code into setup.exe > for various reasons (e.g., formatting, design, etc). Please peruse his > code at: Well, formatting is trivial isn't it :}. As for design, here's what I'd like to see: Ra

Integrating Ralf's rebase into setup.exe

2002-12-04 Thread Jason Tishler
Rob, I have begun the process of merging Ralf's rebase into mine with the ultimate goal of integrating with setup.exe: http://cygwin.com/ml/cygwin/2002-12/msg00138.html To refresh your memory, Ralf's rebase does not rely on imagehlp.dll so it works under Me. Additionally, his code can fix r