Re: [1.7] rename/renameat error

2009-09-30 Thread Corinna Vinschen
On Sep 29 20:10, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Corinna Vinschen on 9/29/2009 1:35 PM: > > On Sep 29 13:18, Eric Blake wrote: > >> I missed one corner case in my testing; how about this followup? > >> > >> 2009-09-29 Eric Blake > >> > >>

Re: [1.7] rename/renameat error

2009-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 9/29/2009 1:35 PM: > On Sep 29 13:18, Eric Blake wrote: >> I missed one corner case in my testing; how about this followup? >> >> 2009-09-29 Eric Blake >> >> * syscalls.cc (rename): Fix regression on rename("dir

Re: [1.7] rename/renameat error

2009-09-29 Thread Corinna Vinschen
On Sep 29 13:18, Eric Blake wrote: > I missed one corner case in my testing; how about this followup? > > 2009-09-29 Eric Blake > > * syscalls.cc (rename): Fix regression on rename("dir","d/"). Looks ok to me. Isn't that partly covered by the next if, though? YA piece of code lacking c

Re: [1.7] rename/renameat error

2009-09-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 9/26/2009 8:57 AM: >> But how does it look now? > > It looks good. Thanks. Please check in. I missed one corner case in my testing; how about this followup? 2009-09-29 Eric Blake * syscalls.cc (rename

Re: [1.7] rename/renameat error

2009-09-26 Thread Christopher Faylor
On Fri, Sep 25, 2009 at 06:03:22PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >According to Christopher Faylor on 9/25/2009 9:11 AM: >>> >+ /* POSIX says mkdir("symlink-to-missing/") should create the >>> >+ directory "missing", but Linux rejects it with EEXIST.

Re: [1.7] rename/renameat error

2009-09-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 9/25/2009 9:11 AM: >> >+ /* POSIX says mkdir("symlink-to-missing/") should create the >> >+ directory "missing", but Linux rejects it with EEXIST. Copy >> >+ Linux behavior for now. */ >> >+ >> >+ dlen = s

Re: [1.7] rename/renameat error

2009-09-25 Thread Christopher Faylor
On Thu, Sep 24, 2009 at 09:31:45PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >According to Christopher Faylor on 9/23/2009 10:41 AM: >>> Also less risky would be to make changes locally in mkdir, link, and >>> rename for now. > >Done - this patch narrows the scope o

Re: [1.7] rename/renameat error

2009-09-25 Thread Corinna Vinschen
On Sep 24 21:31, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Christopher Faylor on 9/23/2009 10:41 AM: > >> Also less risky would be to make changes locally in mkdir, link, and > >> rename for now. > > Done - this patch narrows the scope of the changes to

Re: [1.7] rename/renameat error

2009-09-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 9/23/2009 10:41 AM: >> Also less risky would be to make changes locally in mkdir, link, and >> rename for now. Done - this patch narrows the scope of the changes to just the interfaces in question. I've also tested

Re: [1.7] rename/renameat error

2009-09-23 Thread Christopher Faylor
On Wed, Sep 23, 2009 at 06:08:46PM +0200, Corinna Vinschen wrote: >On Sep 23 10:09, Christopher Faylor wrote: >>On Wed, Sep 23, 2009 at 03:30:15PM +0200, Corinna Vinschen wrote: >>>Urgh. I stumbled over the need_directory flag only two days ago. >>>while debugging the symlink errno problem you rep

Re: [1.7] rename/renameat error

2009-09-23 Thread Corinna Vinschen
On Sep 23 10:09, Christopher Faylor wrote: > On Wed, Sep 23, 2009 at 03:30:15PM +0200, Corinna Vinschen wrote: > >Urgh. I stumbled over the need_directory flag only two days ago. while > >debugging the symlink errno problem you reported on the list. CGF is my > >witness. It's the reason I made

Re: [1.7] rename/renameat error

2009-09-23 Thread Christopher Faylor
On Wed, Sep 23, 2009 at 03:30:15PM +0200, Corinna Vinschen wrote: >Urgh. I stumbled over the need_directory flag only two days ago. while >debugging the symlink errno problem you reported on the list. CGF is my >witness. It's the reason I made the trailing slash change in symlink >rather than i

Re: [1.7] rename/renameat error

2009-09-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 9/23/2009 7:30 AM: > Urgh. I stumbled over the need_directory flag only two days ago. while > debugging the symlink errno problem you reported on the list. CGF is my > witness. It's the reason I made the trailing sl

Re: [1.7] rename/renameat error

2009-09-23 Thread Corinna Vinschen
On Sep 23 06:58, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Eric Blake on 9/22/2009 3:02 PM: > > I've got a patch in testing for both of these issues. > > Does this look okay to apply? The fix in path.cc affects more than just > link, hence I had to add

Re: [1.7] rename/renameat error

2009-09-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/22/2009 3:02 PM: > I've got a patch in testing for both of these issues. Does this look okay to apply? The fix in path.cc affects more than just link, hence I had to add a new option to keep mkdir("d/",mode) still working