Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-25 Thread Corinna Vinschen
On Oct 24 08:58, Takashi Yano wrote: > Hi Corinna, > > On Fri, 22 Oct 2021 17:11:13 +0200 > Corinna Vinschen wrote: > > Just to close this up prior to the 3.3.0 release... > > > > Given we never actually strived for 32<->64 bit interoperability, it's > > hard to argue why this should be

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-23 Thread Takashi Yano
Hi Corinna, On Fri, 22 Oct 2021 17:11:13 +0200 Corinna Vinschen wrote: > Just to close this up prior to the 3.3.0 release... > > Given we never actually strived for 32<->64 bit interoperability, it's > hard to argue why this should be different for the clipboard stuff. > > Running 32 and 64 bit

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-23 Thread Mark Geisert
Ken Brown wrote: On 10/23/2021 1:35 AM, Mark Geisert wrote: Corinna Vinschen wrote: Just to close this up prior to the 3.3.0 release... Given we never actually strived for 32<->64 bit interoperability, it's hard to argue why this should be different for the clipboard stuff. Running 32 and 64

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-23 Thread Ken Brown
On 10/23/2021 1:35 AM, Mark Geisert wrote: Corinna Vinschen wrote: Just to close this up prior to the 3.3.0 release... Given we never actually strived for 32<->64 bit interoperability, it's hard to argue why this should be different for the clipboard stuff. Running 32 and 64 bit Cygwin

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-22 Thread Mark Geisert
Hi all, Corinna Vinschen wrote: On Oct 11 08:11, Ken Brown wrote: On 10/11/2021 2:13 AM, Mark Geisert wrote: It's just that after submitting the patch I realized that, if we really are going to support both Cygwin archs (x86_64 and i686), there is still the issue of different cygcb_t layouts

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-22 Thread Corinna Vinschen
On Oct 11 08:11, Ken Brown wrote: > On 10/11/2021 2:13 AM, Mark Geisert wrote: > > It's just that after submitting the patch I realized that, if we really > > are going to support both Cygwin archs (x86_64 and i686), there is still > > the issue of different cygcb_t layouts between Cygwin versions

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-11 Thread Ken Brown
On 10/11/2021 2:13 AM, Mark Geisert wrote: It's just that after submitting the patch I realized that, if we really are going to support both Cygwin archs (x86_64 and i686), there is still the issue of different cygcb_t layouts between Cygwin versions being ignored. Specifically, the

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-11 Thread Mark Geisert
Ken Brown wrote: On 10/9/2021 10:29 AM, Jon Turney wrote: [...] On 10/8/2021 5:52 AM, Takashi Yano wrote: [...] Thanks all for the comments; much appreciated. They'll be factored into v2 in one form or another. I pronounced my original patch "bad" not because of any problem with code

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-09 Thread Ken Brown
On 10/9/2021 10:29 AM, Jon Turney wrote: On 07/10/2021 06:22, Mark Geisert wrote: > The cygutils package has two programs, putclip and getclip, that also > depend on the layout of the cygcb_t.  At present they have duplicate > defs of struct cygcb_t defined here as no Cygwin header provides

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-09 Thread Jon Turney
On 07/10/2021 06:22, Mark Geisert wrote: > The cygutils package has two programs, putclip and getclip, that also > depend on the layout of the cygcb_t. At present they have duplicate > defs of struct cygcb_t defined here as no Cygwin header provides it. This struct should maybe be in

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-09 Thread Ken Brown
On 10/8/2021 5:52 AM, Takashi Yano wrote: How about simply just: diff --git a/winsup/cygwin/fhandler_clipboard.cc b/winsup/cygwin/fhandler_clipboard.cc index ccdb295f3..d822f4fc4 100644 --- a/winsup/cygwin/fhandler_clipboard.cc +++ b/winsup/cygwin/fhandler_clipboard.cc @@ -28,9 +28,10 @@

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-08 Thread Takashi Yano
How about simply just: diff --git a/winsup/cygwin/fhandler_clipboard.cc b/winsup/cygwin/fhandler_clipboard.cc index ccdb295f3..d822f4fc4 100644 --- a/winsup/cygwin/fhandler_clipboard.cc +++ b/winsup/cygwin/fhandler_clipboard.cc @@ -28,9 +28,10 @@ static const WCHAR *CYGWIN_NATIVE =

Re: [PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-06 Thread Mark Geisert
Mark Geisert wrote: This allows correct copy and pasting between the two Cygwin flavors. [...] Eh, that's a bad patch. Don't apply. It's OK for concept review. v2 forthcoming. Thanks, ..mark

[PATCH] Cygwin: Make native clipboard layout same for 32- and 64-bit

2021-10-06 Thread Mark Geisert
This allows correct copy and pasting between the two Cygwin flavors. What's done is to overlay the differing timespec formats via a union within the control structure cygcb_t. Then conversion between the two formats is done on the 32-bit side only. The cygutils package has two programs, putclip