Re: [PATCH] profile support

2011-08-30 Thread Ryan Johnson
On 29/08/2011 2:15 PM, jojelino wrote: On 2011-08-30 AM 5:23, Christopher Faylor wrote: Maybe Corinna will disagree but I think there is way too much code change here for me to be comfortable with including it. It looks like it would be an ongoing maintenance issue, requiring constant vigilance

Re: [PATCH] profile support

2011-08-29 Thread jojelino
On 2011-08-30 AM 5:23, Christopher Faylor wrote: endif ... ... +endif +#if !defined(PROFILE) void *rv = malloc(size); +#else +void *rv = LocalAlloc(LMEM_FIXED,size); +#endif Since the code is in gmon.c then I don't see a reason to #ifdef it but I still don't understand the motiva

Re: [PATCH] profile support

2011-08-29 Thread Christopher Faylor
On Tue, Aug 30, 2011 at 05:10:39AM +0900, jojelino wrote: >On 2011-08-23 PM 2:40, Christopher Faylor wrote: >> On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: >>> Index: winsup/cygwin/Makefile.in >>> === >>> RCS file: /cvs/sr

Re: [PATCH] profile support

2011-08-29 Thread jojelino
On 2011-08-23 PM 2:40, Christopher Faylor wrote: On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: Index: winsup/cygwin/Makefile.in === RCS file: /cvs/src/src/winsup/cygwin/Makefile.in,v retrieving revision 1.248 diff -u -p

Re: [PATCH] profile support

2011-08-22 Thread Christopher Faylor
On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: >Index: winsup/cygwin/Makefile.in >=== >RCS file: /cvs/src/src/winsup/cygwin/Makefile.in,v >retrieving revision 1.248 >diff -u -p -r1.248 Makefile.in >--- winsup/cygwin/Makefile

Re: [PATCH] profile support

2011-08-22 Thread jojelino
On 2011-08-20 PM 5:49, Corinna Vinschen wrote: Hi Jin-woo, On Aug 20 06:59, jojelino wrote: On 2011-08-20 AM 6:48, jojelino wrote: cd i686-pc-cygwin/winsup/cygwin;rm *.o;make profile=1 it would work. Please ignore attachment from 6:48, i have mistaken by attaching invalid winsup-profile-supp