Re: [darktable-dev] Code reformatting...

2023-02-01 Thread Mark Feit
I don't contribute code to darktable often, but I do follow this list closely and feel the need to comment on this.  Take it or leave it as you wish. On 2/1/23 7:04 AM, Moritz Moeller wrote: This has nothing to do with how many character fit on a line on any display and everything with

Re: [darktable-dev] where to discuss big changes

2019-04-17 Thread Mark Feit
On 4/16/19 1:51 PM, rawfiner wrote: Using github by commenting directly on PRs I'm in favor of this with some modifications with the mailing list as a second choice.  IRC is too ephemeral without logging and conversations can go on for days and end up intermixed with other topics, making it

Re: Fwd: [darktable-dev] Pushing ISO (ISO invarience)

2019-03-02 Thread Mark Feit
On 3/2/19 5:37 AM, Bruce Williams wrote: Yeah, but the numb nuts said "darktable could only give +3 stops of exposure". Clearly, they did not know about the ability to instigate a second instead of a module. As cameras continue to see better in the dark, I wonder if it would be worth

Re: [darktable-dev] Dynamic Memory Allocation Overhaul

2019-02-05 Thread Mark Feit
On 2/5/19 10:20 AM, parafin wrote: One can argue that crashing might be helpful for debugging - backtrace is produced and it's possible to deduce the reason DT exited. E.g. if some allocation size is computed too high (say due to integer underflow) malloc can fail and if we just exit cleanly we

Re: [darktable-dev] Dynamic Memory Allocation Overhaul

2019-02-05 Thread Mark Feit
On 2/5/19 3:10 AM, Stefan Klinger wrote: IMHO it would not make sense to try to be overly smart here. A system with failing `malloc` is on the brink of desaster, and writing failsave code under these conditions is extremely difficult. For one, the recovery routines must not try to allocate

Re: [darktable-dev] Dynamic Memory Allocation Overhaul

2019-02-04 Thread Mark Feit
On 2/4/19 2:22 AM, Andreas Schneider wrote: If you want to change allocations anyway, you should really take a look at talloc [1]. talloc is a hierarchical, reference counted memory pool system with destructors. If you free the top memory context all children will be freed to. It is just fun

[darktable-dev] Dynamic Memory Allocation Overhaul

2019-02-03 Thread Mark Feit
(This has been split off from the static code analysis thread since it's a different topic.) I've completed the first cut of an overhaul of the use of dynamic memory allocation in the source tree with an eye toward safety and an eventual place to do a clean shutdown (closing the database,

Re: [darktable-dev] static code analysis

2019-01-28 Thread Mark Feit
On 1/28/19 3:15 AM, johannes hanika wrote: re: malloc() and 0: linux overcommits, i.e. it will likely never return 0 even if your memory is all full. this means checking for 0 is completely useless in this context. To be blunt, that reads like a rationalization for writing bad software.

Re: [darktable-dev] static code analysis

2019-01-27 Thread Mark Feit
On 1/27/19 6:18 AM, Heiko Bauke wrote: Currently, there is an offer for open source developers to get a free license for the PVS-Studio Analyzer tool.  I got one and applied the tool to the darktable master branch. ... I was not yet able to study the results in detail.  There might be a lot

Re: [darktable-dev] Feature request

2018-12-12 Thread Mark Feit
On 12/12/18 4:28 PM, Terry Duell wrote: This is pretty much the solution that Patrick proposed. Unless I missed something (not ruling that out; it's been known to happen), the first reply I saw was Pascal Obry's, which was GUI-centric. The impression I got from your reply was that you were

Re: [darktable-dev] Feature request

2018-12-12 Thread Mark Feit
On 12/11/18 10:07 PM, Terry Duell wrote: The requirement for uncropped images seriously complicates the task if using darktable-cli. The request is to have a 'crop=0' switch (or similar) for darktable-cli...if that is possible, and reasonable. That would start a trend of having to propagate

Re: [darktable-dev] Darkroom UI refactoring

2018-10-09 Thread Mark Feit
On 10/9/18 3:02 AM, Aurélien Pierre wrote: But even if we keep the actual disposition, don't you think it's weird that : * in/out color profiles are stored in the color tabs, whereas they are "basic" in the sense they are needed from technical requirements and always on, I don't

Re: [darktable-dev] Which colour target is recommended for a proper colour matrix

2018-09-05 Thread Mark Feit
On 9/4/18 12:42 PM, Andreas Schneider wrote: If you want to create a camera profile with a target, I suggest you read: https://pixls.us/articles/profiling-a-camera-with-darktable-chart/ For what it's worth, I have a convenient system for building and installing color profiles into your dt

Re: [darktable-dev] Lens Correction

2018-04-23 Thread Mark Feit
On 04/23/2018 03:26 AM, sturmflut wrote: Could it maybe be possible that the lensfun database got corrupted on some systems? It's not just some systems and it's not a database problem.  I've had this problem for a long time and, figuring it was pilot error, never got around to digging around

Re: [darktable-dev] darktable accessing lensfun issues

2018-04-18 Thread Mark Feit
On 4/18/18 12:29 PM, Patrick Shanahan wrote: did you try lensfun-update-data For what it's worth, I have the same problem and have verified that the lensfun data is current. --Mark ___ darktable developer mailing list

Re: [darktable-dev] Show maximum possible export size in light table?

2018-01-12 Thread Mark Feit
On 1/12/18 3:29 AM, Heiko Bauke wrote: At the moment, one can collect images by specific criteria.  Some of these criteria can be expressed by numerical values, e.g., focal length or ISO.  It would be nice if one could collect not only images taken at a specific ISO, let's say, but also

Re: [darktable-dev] Darktable + Cloud-computing

2017-11-02 Thread Mark Feit
Aurélien PIERRE wrote: So… what do you think of having the heavy filters processed in Darktable through the servers of Amazon or anybody else instead of having to break the bank for a new (almost) disposable computer ? Possible or science-fiction ? How many of you don't have a 1MB/s or

Re: [darktable-dev] PSA: Does anyone still use gcc-4.8/4.9 ?

2017-03-28 Thread Mark Feit
On 03/28/2017 04:57 AM, Roman Lebedev wrote: I want to bump gcc requirement up to GCC-5 soon, Thus, subj. If you do, please speak up now. PS: using outdated distro version is not an excuse. I'm not even a bit player in this but... This will put off anybody using EL7 or its derivatives

Re: [darktable-dev] Re: PSA: ATTENTION NIKON OWNERS !!! LAST CALL

2016-10-14 Thread Mark Feit
On 10/13/16 1:51 PM, Roman Lebedev wrote: Okay, some samples were provided, a few cameras got off the list. But not all. Here is the current up-to-date list of the cameras, samples from which are still wanted: ... NIKON CORPORATION NIKON D1 How short is the timeline on this? I have a D1 in

Re: [darktable-dev] Harsh reaction

2016-10-04 Thread Mark Feit
On 10/04/2016 02:54 AM, Frederic Crozat wrote: Just ignore him. This kind of behavior is not acceptable (I'm not a darktable developer, I have zero interest in Windows or macos ports, I'm only helping for openSUSE packaging when needed). You are fixing real bugs in the codebase, which