Re: [darktable-dev] Code reviews requested : Profile gamma correction

2018-09-18 Thread Aurélien Pierre
Thanks Jo ! so now I'm working on the OpenCL port. I have this function in the IOP : #ifdef HAVE_OPENCL int process_cl(struct dt_iop_module_t *self, dt_dev_pixelpipe_iop_t *piece, cl_mem dev_in, cl_mem dev_out,    const dt_iop_roi_t *const roi_in, const dt_iop_roi_t *const roi_out) {

Re: [darktable-dev] Code reviews requested : Profile gamma correction

2018-09-18 Thread johannes hanika
heya, [..] > Actually, I even wonder if OpenCL is relevant for this as it's a linear > operation performed on only one pixel at the time over the flatten array. I > wouldn't be surprised if the OpenCL version were slower on some systems than > a good SSE2 version. maybe on some systems. the

Re: [darktable-dev] Code reviews requested : Profile gamma correction

2018-09-12 Thread Aurélien Pierre
Le 12/09/2018 à 12:59, rawfiner a écrit : > Hi Aurélien > > Fist, thank you for showing me this interesting video. > I just compiled your branch. > > My first question is, is it possible to find shift power slope values > that reproduce the result we had before with linear and gamma? > If yes, I

Re: [darktable-dev] Code reviews requested : Profile gamma correction

2018-09-12 Thread rawfiner
Sorry for the spelling mistake, didn't mean "Fist" but "First" My apologies cheers, rawfiner Le mer. 12 sept. 2018 à 18:59, rawfiner a écrit : > Hi Aurélien > > Fist, thank you for showing me this interesting video. > I just compiled your branch. > > My first question is, is it possible to find

Re: [darktable-dev] Code reviews requested : Profile gamma correction

2018-09-12 Thread rawfiner
Hi Aurélien Fist, thank you for showing me this interesting video. I just compiled your branch. My first question is, is it possible to find shift power slope values that reproduce the result we had before with linear and gamma? If yes, I think you should compute the new parameters values from

[darktable-dev] Code reviews requested : Profile gamma correction

2018-09-12 Thread Aurélien Pierre
Hi everyone, when working with color profiles, the main historic issue was the non-linearity of the sensors/films. Now, it is rather that the color profile is performed on a chart having 6-7 EV of dynamic range while modern cameras have 12-15 EV. Simple gamma corrections (invented for CRT