Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-21 Thread Keresztes Barna
Modified again, thanks to a suggestion by Aurélien. I made a testing version (found on my pull request https://github.com/darktable-org/darktable/pull/3121) with 3 vibrance sliders to compare the effects of the different formulas. At the moment only on non-OpenCL version. I checked the effect on

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-11 Thread Keresztes Barna
Pull request done! First I wanted to make sure everything was okay. Thanks again for the suggestions on the vibrance formula! On 11/10/2019 18:33, Pascal Obry wrote: If you want to have a little chance that this be tested please create a pull-request on the main darktable GitHub. Thanks,

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-11 Thread Pascal Obry
Le vendredi 11 octobre 2019 à 18:22 +0200, Keresztes Barna a écrit : > Thanks Aurélien! > > Formula changed, new version on Git ready for testing: > https://github.com/kbarni/darktable > (please test especially the OpenCL kernel, as I don't have the hardware to > test it!) If you want to have

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-11 Thread Keresztes Barna
Thanks Aurélien! Formula changed, new version on Git ready for testing: https://github.com/kbarni/darktable (please test especially the OpenCL kernel, as I don't have the hardware to test it!) On 11/10/2019 16:57, Aurélien Pierre wrote: Actually, I made a mistake. The formula I gave you will

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-11 Thread Aurélien Pierre
Le 11/10/2019 à 13:31, Keresztes Barna a écrit : > Thanks for the feedback, Aurélien! > > 1. I used this formula for the > vibrance: http://redqueengraphics.com/category/color-adjustments/ (it > can also be computed together with saturation).  > I changed it to your proposed formula, to be

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-11 Thread Keresztes Barna
Thanks for the feedback, Aurélien! 1. I used this formula for the vibrance: http://redqueengraphics.com/category/color-adjustments/ (it can also be computed together with saturation). I changed it to your proposed formula, to be consistent with other software. It's also cleaner to have the two

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-10 Thread Aurélien Pierre
Hi, 1. Vibrance is supposed to be *{ RGB } = Y + saturation * ( { RGB } - Y )^vibrance*, where Y is the luminance channel from XYZ space, and { RGB } a pixel vector. This way, you perform both operations at once. Also, using (R + G + B) / 3 instead of Y is generally not a good idea since it has

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-10 Thread Keresztes Barna
On Thu, Oct 10, 2019 at 8:58 PM parafin wrote: > Is it any different from velvia iop in darktable? > Yes, it affects colors less than Velvia. It doesn't intend to emulate film. The results of this slider are very similar to the standalone Vibrance tool. There are some important differences: -

Re: [darktable-dev] Vibrance slider in the Basic adjustments tool

2019-10-10 Thread parafin
Is it any different from velvia iop in darktable? On Thu, 10 Oct 2019 20:44:25 +0200 Keresztes Barna wrote: > Hi all, > > I'm a happy user of Darktable! One of my favorite tools in the 2.7 branch > is the *Basic Adjustments tool*, where I can find in one place most of the > tools I need to