Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Roumano
Hi, Thank you very much for the help/invesigation ! I have created a bug in exiv2 : Bug #895 ( URL : http://dev.exiv2.org/issues/895 ) after searching in existing bug in exiv2, a another bug already exist for the same ID 169 but another lens : Bug #854 ( http://dev.exiv2.org/issues/854 ) Rega

Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Pascal de Bruijn
On Mon, Mar 18, 2013 at 12:56 PM, Roumano wrote: > Hi, > > I'm using a plain 0.23 version > > It's not your own version as i'm running on another OS-ditrib... > > i have upload a sample image : > http://dl.free.fr/m8coKz7E4 Looking at canonmn.cpp in the Exiv2 codebase: { 169, "Canon EF 1

Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Torsten Bronger
Hallöchen! Roumano writes: > [...] > > 1) Canon EF-S 55-250 : > > exiftool 20130303_0011.CR2| grep -i lens > Lens Type : Canon EF-S 55-250mm f/4-5.6 IS > Lens Model : EF-S55-250mm f/4-5.6 IS > Lens: 55.0 - 250.0 mm > Lens ID

Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Roumano
Hi, I'm using a plain 0.23 version It's not your own version as i'm running on another OS-ditrib... i have upload a sample image : http://dl.free.fr/m8coKz7E4 Regards Le lundi 18 mars 2013 à 12:08 +0100, Pascal de Bruijn a écrit : > Exiv2

Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Pascal de Bruijn
On Mon, Mar 18, 2013 at 11:57 AM, Roumano wrote: > Hi, > > Personnaly, i have 4 lens & 2 of them have name problem with lensfun > database : > > 1) Canon EF-S 55-250 : > > exiftool 20130303_0011.CR2| grep -i lens > Lens Type : Canon EF-S 55-250mm f/4-5.6 IS > Lens Model

Re: [darktable-devel] lensfun issue resolved

2013-03-18 Thread Roumano
Hi, Personnaly, i have 4 lens & 2 of them have name problem with lensfun database : 1) Canon EF-S 55-250 : exiftool 20130303_0011.CR2| grep -i lens Lens Type : Canon EF-S 55-250mm f/4-5.6 IS Lens Model : EF-S55-250mm f/4-5.6 IS Lens

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Torsten Bronger
Hallöchen! Sebastian Kraft writes: > Am 17.03.2013 15:27, schrieb Torsten Bronger: > >> [...] >> >> [...] The only problem is, how do we get the aliases? We will >> have to hope that people running into this problem will find >> their way to the mailing lists. > > That's exactly the point I don

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Sebastian Kraft
Am 17.03.2013 15:27, schrieb Torsten Bronger: > Hallöchen! > > Sebastian Kraft writes: > >> [...] >> >> Your proposal was to add aliases in the database. But this will be >> quite specific to the library used by applications and fill the >> database with highly redundant information. Not a good sol

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Torsten Bronger
Hallöchen! Sebastian Kraft writes: > [...] > > Your proposal was to add aliases in the database. But this will be > quite specific to the library used by applications and fill the > database with highly redundant information. Not a good solution > IMO. In my opinion, it is not redundant. On the

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Ulrich Pegelow
Am 17.03.2013 13:28, schrieb Sebastian Kraft: > I see... that won't work with the Canon lenses only differing by II or > III :( > > [...] > > Your proposal was to add aliases in the database. But this will be quite > specific to the library used by applications and fill the database with > highly

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Markus Jung
Am 17.03.2013 13:28, schrieb Sebastian Kraft: > Am 17.03.2013 12:22, schrieb Ulrich Pegelow: >>> >>> The score field in the lens search result struct is documented in the >>> manual. So I think it is supposed to be used. The only missing thing is >>> a specification of the value range. >>> >>> Why

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Pascal de Bruijn
On Sun, Mar 17, 2013 at 1:36 PM, Colin Adams wrote: > On 17 March 2013 12:28, Sebastian Kraft wrote: > >> Ok, what we have so far: >> >> Strict search won't work as lens names are not standardized and differ >> in some parts of the name. See Tamron 17-50. >> >> Fuzzy search won't work as lens nam

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Colin Adams
On 17 March 2013 12:28, Sebastian Kraft wrote: > Ok, what we have so far: > > Strict search won't work as lens names are not standardized and differ > in some parts of the name. See Tamron 17-50. > > Fuzzy search won't work as lens names sometimes only differ by one last > letter. See Canon 70-20

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Sebastian Kraft
Am 17.03.2013 12:22, schrieb Ulrich Pegelow: >> >> The score field in the lens search result struct is documented in the >> manual. So I think it is supposed to be used. The only missing thing is >> a specification of the value range. >> >> Why not giving it a try? Maybe with a conservative thresho

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Ulrich Pegelow
Am 16.03.2013 21:40, schrieb Sebastian Kraft: > Am 16.03.2013 16:34, schrieb Ulrich Pegelow: >> Am 16.03.2013 15:23, schrieb Sebastian Kraft: >>> Am 16.03.2013 15:18, schrieb Ulrich Pegelow: Is the score value documented anywhere? What would be a good threshold to accept or refuse a

Re: [darktable-devel] lensfun issue resolved

2013-03-17 Thread Ulrich Pegelow
Am 16.03.2013 21:40, schrieb Sebastian Kraft: > > The score field in the lens search result struct is documented in the > manual. So I think it is supposed to be used. The only missing thing is > a specification of the value range. > > Why not giving it a try? Maybe with a conservative threshold fi

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Sebastian Kraft
Am 16.03.2013 16:34, schrieb Ulrich Pegelow: > Am 16.03.2013 15:23, schrieb Sebastian Kraft: >> Am 16.03.2013 15:18, schrieb Ulrich Pegelow: >>> >>> Is the score value documented anywhere? What would be a good threshold >>> to accept or refuse a match? >>> >> >> Unfortunately not :( I just found ou

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Ulrich Pegelow
Am 16.03.2013 15:23, schrieb Sebastian Kraft: > Am 16.03.2013 15:18, schrieb Ulrich Pegelow: >> >> Is the score value documented anywhere? What would be a good threshold >> to accept or refuse a match? >> > > Unfortunately not :( I just found out that this exists a few weeks ago. > You can compile

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Sebastian Kraft
Am 16.03.2013 15:18, schrieb Ulrich Pegelow: > Am 16.03.2013 15:14, schrieb Sebastian Kraft: >> >> One way to improve the matching with the fuzzy search would be to >> evaluate the score returned with the search result. If the score is high >> you know the search result matches quite good. Have you

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Ulrich Pegelow
Am 16.03.2013 15:14, schrieb Sebastian Kraft: > > One way to improve the matching with the fuzzy search would be to > evaluate the score returned with the search result. If the score is high > you know the search result matches quite good. Have you tried this? > > For me this gives a very good indi

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Sebastian Kraft
> > Just aliasing all the Exiv2 names will make autoselection work in most > practical cases though. Well, but cluttering the database with lens names is not a proper solution. > >> For example Darktable could automatically select the correct profile in >> it's GUI but the user would have to manu

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Pascal de Bruijn
On Sat, Mar 16, 2013 at 12:35 PM, Sebastian Kraft wrote: > > slr-tamron.xml:Tamron 17-50mm f/2.8 XR Di II LD > > > > Exif.PentaxDng.LensType Byte4 Tamron AF > > 17-50mm F2.8 XR Di-II LD (Model A16) > > > > So the problem seems to be the Model A16 suffix

Re: [darktable-devel] lensfun issue resolved

2013-03-16 Thread Sebastian Kraft
> slr-tamron.xml:Tamron 17-50mm f/2.8 XR Di II LD > > Exif.PentaxDng.LensType Byte4 Tamron AF > 17-50mm F2.8 XR Di-II LD (Model A16) > > So the problem seems to be the Model A16 suffix :( > > So looking into the Exiv2 sources: > > { 0x04e6, "Tamr

Re: [darktable-devel] lensfun issue resolved

2013-03-15 Thread Torsten Bronger
Hallöchen! Ivan Tarozzi writes: > [...] > > The problem still open. In the past, I already opened a ticket > (http://developer.berlios.de/bugs/?func=detailbug&bug_id=18777&group_id=9034) > to lensfun project, and they closed: "Closed, as problem is in > darktables handling of the database search"

Re: [darktable-devel] lensfun issue resolved

2013-03-15 Thread Ivan Tarozzi
Il 15/03/2013 07:54, Torsten Bronger ha scritto: > Hallöchen! > > Ivan Tarozzi writes: > >> [...] >> >> Sincerely I don't understand why fuzzy search was removed... commit >> message says "more consistent behavior of gui and auto-detection" but I >> have not found issue using fuzzy detection. Am

Re: [darktable-devel] lensfun issue resolved

2013-03-14 Thread Torsten Bronger
Hallöchen! Ivan Tarozzi writes: > [...] > > Sincerely I don't understand why fuzzy search was removed... commit > message says "more consistent behavior of gui and auto-detection" but I > have not found issue using fuzzy detection. Am I wrong? See http://thread.gmane.org/gmane.comp.graphics.dark

Re: [darktable-devel] lensfun issue resolved

2013-03-14 Thread Ivan Tarozzi
Il 14/03/2013 18:44, Pascal de Bruijn ha scritto: > > I'm afraid we had to break this again :( > > slr-tamron.xml:Tamron 17-50mm f/2.8 XR Di II LD > > Exif.PentaxDng.LensType Byte4 Tamron AF > 17-50mm F2.8 XR Di-II LD (Model A16) > > So the problem seems to

Re: [darktable-devel] lensfun issue resolved

2013-03-14 Thread Torsten Bronger
Hallöchen! Pascal de Bruijn writes: > [...] > > So looking into the Exiv2 sources: > > { 0x04e6, "Tamron SP AF 17-50mm F2.8 XR Di II" }, > { 0x07e6, "Tamron AF 17-50mm F2.8 XR Di-II LD (Model A16)" }, > > So to be honest I'm not sure how to proceed with this I'm tempted > to think t

Re: [darktable-devel] lensfun issue resolved

2013-03-14 Thread Pascal de Bruijn
On Wed, Feb 6, 2013 at 10:19 PM, Ulrich Pegelow wrote: > Am 06.02.2013 22:03, schrieb Pascal de Bruijn: >> On Wed, Feb 6, 2013 at 9:57 PM, Serge Gavrilov wrote: >>> On Ср., 2013-02-06 at 21:23 +0100, Pascal de Bruijn wrote: > > Could you make a sample RAW available for testing?

Re: [darktable-devel] lensfun issue resolved

2013-02-06 Thread Ulrich Pegelow
Am 06.02.2013 22:03, schrieb Pascal de Bruijn: > On Wed, Feb 6, 2013 at 9:57 PM, Serge Gavrilov wrote: >> On Ср., 2013-02-06 at 21:23 +0100, Pascal de Bruijn wrote: Could you make a sample RAW available for testing? >>> >>> Bump :) >> >> You can try >> http://www.pdmi.ras.ru/~serge/DSC_1

Re: [darktable-devel] lensfun issue resolved

2013-02-06 Thread Serge Gavrilov
On Ср., 2013-02-06 at 22:03 +0100, Pascal de Bruijn wrote: > On Wed, Feb 6, 2013 at 9:57 PM, Serge Gavrilov wrote: > > On Ср., 2013-02-06 at 21:23 +0100, Pascal de Bruijn wrote: > >> > > >> > Could you make a sample RAW available for testing? > >> > >> Bump :) > > > > You can try > > http://www.pd

Re: [darktable-devel] lensfun issue resolved

2013-02-06 Thread Pascal de Bruijn
On Wed, Feb 6, 2013 at 9:57 PM, Serge Gavrilov wrote: > On Ср., 2013-02-06 at 21:23 +0100, Pascal de Bruijn wrote: >> > >> > Could you make a sample RAW available for testing? >> >> Bump :) > > You can try > http://www.pdmi.ras.ru/~serge/DSC_1009.zip It says: "corrections done: only distortion" o

Re: [darktable-devel] lensfun issue resolved

2013-02-06 Thread Serge Gavrilov
On Ср., 2013-02-06 at 21:23 +0100, Pascal de Bruijn wrote: > > > > Could you make a sample RAW available for testing? > > Bump :) You can try http://www.pdmi.ras.ru/~serge/DSC_1009.zip Thanks! -- Serge -- Free Next-

Re: [darktable-devel] lensfun issue resolved

2013-02-06 Thread Pascal de Bruijn
On Tue, Feb 5, 2013 at 10:56 PM, Pascal de Bruijn wrote: > On Tue, Feb 5, 2013 at 8:15 PM, Serge Gavrilov wrote: >> On Вт., 2013-02-05 at 18:27 +0100, Pascal de Bruijn wrote: >> >>> I pushed the patch to git master and darktable-1.1.x so it can be >>> tested more widely: >>> >>> https://github.co

Re: [darktable-devel] lensfun issue resolved

2013-02-05 Thread Pascal de Bruijn
On Tue, Feb 5, 2013 at 8:15 PM, Serge Gavrilov wrote: > On Вт., 2013-02-05 at 18:27 +0100, Pascal de Bruijn wrote: > >> I pushed the patch to git master and darktable-1.1.x so it can be >> tested more widely: >> >> https://github.com/darktable-org/darktable/commit/ef0975ebe1b0a58c6af266300c96cbac8

Re: [darktable-devel] lensfun issue resolved

2013-02-05 Thread Serge Gavrilov
On Вт., 2013-02-05 at 18:27 +0100, Pascal de Bruijn wrote: > I pushed the patch to git master and darktable-1.1.x so it can be > tested more widely: > > https://github.com/darktable-org/darktable/commit/ef0975ebe1b0a58c6af266300c96cbac8c358668 > Works for me now, many thanks. The only one arti

Re: [darktable-devel] lensfun issue resolved

2013-02-05 Thread Pascal de Bruijn
On Tue, Feb 5, 2013 at 1:55 PM, Benjamin Lefaudeux wrote: > Same for me, I've had this bug since the beginning on select lenses. Would > be great to see the patch applied mainstream :-) I pushed the patch to git master and darktable-1.1.x so it can be tested more widely: https://github.com/darkt

Re: [darktable-devel] lensfun issue resolved

2013-02-05 Thread Benjamin Lefaudeux
Same for me, I've had this bug since the beginning on select lenses. Would be great to see the patch applied mainstream :-) Thanks Ivan, great job ! ben On 5 February 2013 10:52, Serge Gavrilov wrote: > On Вс., 2013-02-03 at 00:19 +0100, Ivan Tarozzi wrote: > > Hi, > > some month ago I opened a

Re: [darktable-devel] lensfun issue resolved

2013-02-05 Thread Serge Gavrilov
On Вс., 2013-02-03 at 00:19 +0100, Ivan Tarozzi wrote: > Hi, > some month ago I opened a bug report in lensfun project because one of > my lens (Tamron 17-50 f2,8 on Pentax K-7) is not recognized by darktable: > http://developer.berlios.de/bugs/?func=detailbug&bug_id=18777&group_id=9034 > > The i

[darktable-devel] lensfun issue resolved

2013-02-02 Thread Ivan Tarozzi
Hi, some month ago I opened a bug report in lensfun project because one of my lens (Tamron 17-50 f2,8 on Pentax K-7) is not recognized by darktable: http://developer.berlios.de/bugs/?func=detailbug&bug_id=18777&group_id=9034 The iop lens shows the correct camera and lens, but when I enable the m