Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-02 Thread jeremy rosen
(again, I was wrong about exposure, this applies only to WB) it's more about what WB fundamentally is than how we implement it, but yes there are technicall reasons why you can't do that On Fri, Aug 2, 2013 at 7:53 PM, Richard Levitte wrote: > So what you're saying is that there are technical

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-02 Thread Richard Levitte
So what you're saying is that there are technical reasons, and they are about how dt, or at least those modules are constructed. In message on Thu, 1 Aug 2013 10:56:22 +0200, jeremy rosen said: jeremy.rosen> to put it simply, you cannot not have some sort of exposure/white balance on parts o

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread johannes hanika
On Thu, Aug 1, 2013 at 11:33 AM, jeremy rosen wrote: > > So you say we can have a mask between two values right? When you open an >> image in the darkroom module it has a default WB value and EV (i'm guessing >> 0EV). If you enable a mask and change the EV or WB value we could apply the >> mask b

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread jeremy rosen
> So you say we can have a mask between two values right? When you open an > image in the darkroom module it has a default WB value and EV (i'm guessing > 0EV). If you enable a mask and change the EV or WB value we could apply the > mask between the new value and the base value. Am i wrong on this?

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread Pascal Obry
Johannes, I have created a pull-request for this feature. Ok to merge? I've done some testing and it seems to work just fine... -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.g

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread Pascal Obry
2013/8/1 johannes hanika : > i don't see a technical reason for exposure, but wb works on the bayer > pattern before demosaicing which makes blending difficult. you can do color > correction though. I think we already had this discussion about exposure and masks, so what about activating this then

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread johannes hanika
i don't see a technical reason for exposure, but wb works on the bayer pattern before demosaicing which makes blending difficult. you can do color correction though. j. On Thu, Aug 1, 2013 at 10:56 AM, jeremy rosen wrote: > to put it simply, you cannot not have some sort of exposure/white bala

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread Gonçalo Marrafa
Hi Jeremy, thanks for your reply. So you say we can have a mask between two values right? When you open an image in the darkroom module it has a default WB value and EV (i'm guessing 0EV). If you enable a mask and change the EV or WB value we could apply the mask between the new value and the base

Re: [Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread jeremy rosen
to put it simply, you cannot not have some sort of exposure/white balance on parts of images. you could have a gradiant/mask between two values, but you can not have no EV compensation or WB at all. arguably it would be interesting to have a way to do that, in particular for WB where different zo

[Darktable-users] Masks on white balance and exposure modules

2013-08-01 Thread Gonçalo Marrafa
Hi. I posted this question (twice) on DT's Google+ comunity ( http://goo.gl/CBvw7y) but got no answer, so i'm trying this mailing list :) Why aren't masks/conditional blending available in white balance and exposure modules? Is it a technical reason or an implementation decision? It would be nice