Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-03-01 Thread Subhasish Ghosh
Srinivasan stali...@mistralsolutions.com Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver we used separate files and hence we decided to keep the code in a separate directory so that the related files can be identified easily. Fair enough but I would have thought you could drop the two files

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-03-01 Thread Alan Cox
I tried using a tasklet for the TX part, but that did not help. Another way is to prepare the buffer for the next read and read the data immediately. Something like this: 1. Call tty_prepare_flip_string while startup. 2. When the read interrupt arrives, read the data immediately. 3. Call

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-24 Thread Subhasish Ghosh
Hello, Ok, have implemented the test_and_clear_bit. On Tuesday 22 February 2011, Subhasish Ghosh wrote: @@ -122,13 +122,10 @@ static void omapl_pru_tx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) if (!(suart_get_duplex(soft_uart, uart_no) ePRU_SUART_HALF_TX))

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-23 Thread Subhasish Ghosh
; m-watk...@ti.com Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver On Tue, Feb 22, 2011 at 02:12:32PM +0530, Subhasish Ghosh wrote: Hello, I had kept separate files to affirm the modularity and ease of portability of the system. There are three different interfaces, 1. The Linux driver

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-23 Thread Greg KH
On Wed, Feb 23, 2011 at 07:05:53PM +0530, Subhasish Ghosh wrote: Hello, Anything regarding this. What is with the impatience? We do sleep around here, sometimes... thanks, greg k-h ___ Davinci-linux-open-source mailing list

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-22 Thread Subhasish Ghosh
...@ti.com Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver On Friday 18 February 2011 19:23:49 Thomas Gleixner wrote: On Fri, 18 Feb 2011, Alan Cox wrote: On Fri, 18 Feb 2011 19:17:38 +0530 Subhasish Ghosh subhas...@mistralsolutions.com wrote: Hello, Regarding the semaphore to mutex

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-22 Thread Subhasish Ghosh
gre...@suse.de; nsek...@ti.com; open list linux-ker...@vger.kernel.org; m-watk...@ti.com Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver On Friday 18 February 2011 19:23:49 Thomas Gleixner wrote: On Fri, 18 Feb 2011, Alan Cox wrote: On Fri, 18 Feb 2011 19:17:38 +0530 Subhasish Ghosh

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-22 Thread Subhasish
...@ti.com; sa...@mistralsolutions.com; Greg Kroah-Hartman gre...@suse.de; open list linux-ker...@vger.kernel.org Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver Don't see why it needs its own sub-directory SG - We have two different layers of implementation. One is the driver layer, which

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-22 Thread Greg KH
On Tue, Feb 22, 2011 at 02:12:32PM +0530, Subhasish Ghosh wrote: Hello, I had kept separate files to affirm the modularity and ease of portability of the system. There are three different interfaces, 1. The Linux driver interface 2. The PRU control interface 3. The McASP serializer

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-22 Thread Arnd Bergmann
On Tuesday 22 February 2011, Subhasish Ghosh wrote: @@ -122,13 +122,10 @@ static void omapl_pru_tx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) if (!(suart_get_duplex(soft_uart, uart_no) ePRU_SUART_HALF_TX)) return; - if

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-18 Thread Subhasish Ghosh
...@vger.kernel.org Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver Don't see why it needs its own sub-directory +#ifdef __SUART_DEBUG +#define __suart_debug(fmt, args...) \ + printk(KERN_DEBUG suart_debug: fmt, ## args) +#else +#define __suart_debug(fmt, args...) +#endif + +#define __suart_err(fmt

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-18 Thread Alan Cox
On Fri, 18 Feb 2011 19:17:38 +0530 Subhasish Ghosh subhas...@mistralsolutions.com wrote: Hello, Regarding the semaphore to mutex migration. We are using down_trylock in interrupt context, mutex_trylock cannot be used in interrupt context, so we cannot use mutex in our driver. Then you

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011 19:23:49 Thomas Gleixner wrote: On Fri, 18 Feb 2011, Alan Cox wrote: On Fri, 18 Feb 2011 19:17:38 +0530 Subhasish Ghosh subhas...@mistralsolutions.com wrote: Hello, Regarding the semaphore to mutex migration. We are using down_trylock in interrupt

Re: [PATCH v2 13/13] tty: pruss SUART driver

2011-02-11 Thread Alan Cox
Don't see why it needs its own sub-directory +#ifdef __SUART_DEBUG +#define __suart_debug(fmt, args...) \ + printk(KERN_DEBUG suart_debug: fmt, ## args) +#else +#define __suart_debug(fmt, args...) +#endif + +#define __suart_err(fmt, args...) printk(KERN_ERR suart_err: