Re: [PATCH] serial: 8250: Add cpufreq support

2012-04-18 Thread Alan Cox
> As per my understanding, tty count keeps the count of tty_open and > tty_release, that is > how many open and close happened on the tty device file(/dev/ttyS*). > The requirement here is a tty count check, if it is greater than zero then > only it should > proceed for further execution. The p

RE: [PATCH] serial: 8250: Add cpufreq support

2012-04-17 Thread Shankarmurthy, Akshay
On Thu, Apr 12, 2012 at 15:17:58, Alan Cox wrote: > > > > I will have a look at this and add the lock if necessary. > > > > > > At the very least you need reference counts held on the tty struct and to > > > allow for the tty having vanished under you. > > > > > > > I am planning to add "tty->t

Re: [PATCH] serial: 8250: Add cpufreq support

2012-04-12 Thread Alan Cox
> > > I will have a look at this and add the lock if necessary. > > > > At the very least you need reference counts held on the tty struct and to > > allow for the tty having vanished under you. > > > > I am planning to add "tty->termios_mutex" lock. Any comments ? Explain how this will help.

RE: [PATCH] serial: 8250: Add cpufreq support

2012-04-11 Thread Shankarmurthy, Akshay
On Thu, Apr 05, 2012 at 16:23:22, Alan Cox wrote: > On Thu, 5 Apr 2012 10:40:55 + > "Shankarmurthy, Akshay" wrote: > > > Hi, > > > > On Tue, Apr 03, 2012 at 15:25:30, Alan Cox wrote: > > > > This patch was submitted 2 years ago but didn't make it to the > > > > mainline. Now i am reposting

Re: [PATCH] serial: 8250: Add cpufreq support

2012-04-05 Thread Alan Cox
On Thu, 5 Apr 2012 10:40:55 + "Shankarmurthy, Akshay" wrote: > Hi, > > On Tue, Apr 03, 2012 at 15:25:30, Alan Cox wrote: > > > This patch was submitted 2 years ago but didn't make it to the mainline. > > > Now i am reposting it. > > > > Can you fix it instead of just reposting it ? > > >

RE: [PATCH] serial: 8250: Add cpufreq support

2012-04-05 Thread Shankarmurthy, Akshay
Hi, On Tue, Apr 03, 2012 at 15:25:30, Alan Cox wrote: > > This patch was submitted 2 years ago but didn't make it to the mainline. > > Now i am reposting it. > > Can you fix it instead of just reposting it ? > > > > +#ifdef CONFIG_CPU_FREQ > > +static int serial8250_cpufreq_transition(struct n

Re: [PATCH] serial: 8250: Add cpufreq support

2012-04-03 Thread Alan Cox
> This patch was submitted 2 years ago but didn't make it to the mainline. Now > i am reposting it. Can you fix it instead of just reposting it ? > +#ifdef CONFIG_CPU_FREQ > +static int serial8250_cpufreq_transition(struct notifier_block *nb, > + unsigne

RE: [PATCH] serial: 8250: Add cpufreq support

2010-01-18 Thread Chaithrika U S
On Wed, Jan 13, 2010 at 19:14:45, Alan Cox wrote: > > +static int serial8250_cpufreq_transition(struct notifier_block *nb, > > +unsigned long val, void *data) > > +{ > > + struct uart_8250_port *p; > > + struct uart_port *uport; > > + > > + p = containe