Re: Proposed change to disconnect in DBD::ODBC

2011-03-17 Thread H.Merijn Brand
On Wed, 16 Mar 2011 16:49:41 +, Martin J. Evans martin.ev...@easysoft.com wrote: This area is already inconsistent. From DBI under disconnect: The transaction behaviour of the disconnect method is, sadly, undefined. Some database systems (such as Oracle and Ingres) will automatically

Proposed change to disconnect in DBD::ODBC

2011-03-16 Thread Martin J. Evans
DBI does not define what happens wrt transactions when disconnect is called. Up to DBD::ODBC 1.29, DBD::ODBC always called SQLEndTran(SQL_ROLLBACK) to roll back any outstanding transactions (if AutoCommit was off) before calling SQLDisconnect. This means the outstanding transaction that is

Re: Proposed change to disconnect in DBD::ODBC

2011-03-16 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 but in the second case DBD::ODBC will rollback the transaction before disconnecting and there is no error or warning. I don't really like this behaviour and would like to change it so in the second case above, DBD::ODBC issues a warning

Re: Proposed change to disconnect in DBD::ODBC

2011-03-16 Thread Martin J. Evans
On 16/03/11 16:07, Greg Sabino Mullane wrote: -BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 but in the second case DBD::ODBC will rollback the transaction before disconnecting and there is no error or warning. I don't really like this behaviour and would like to change it so in the

Re: Proposed change to disconnect in DBD::ODBC

2011-03-16 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 This area is already inconsistent. From DBI under disconnect: The transaction behaviour of the disconnect method is, sadly, undefined. Some database systems (such as Oracle and Ingres) will automatically commit any outstanding changes,