Thank you so much for your review, I hope it will do what it is supposed to
do. ))
Cheers,
Ahmed.
On 26 March 2013 00:14, Jona Christopher Sahnwaldt wrote:
> Hi Ahmed,
>
> I think your code is correct. I will merge your pull request soon.
>
> Details:
>
> I looked at the Scala file in several d
Thank you so much Joan, here is the link, take a look please:
https://github.com/ktobah/extraction-framework/tree/ArabicConfiguration
On 25 March 2013 23:09, Jona Christopher Sahnwaldt wrote:
> Hi Ahmed,
>
> please send us a link to your files on github. I don't know much about
> right-to-left
Hi Ahmed,
I think your code is correct. I will merge your pull request soon.
Details:
I looked at the Scala file in several different programs, and it looks
different each time. Each program seems to have its own heuristic -
something like "oh, there's an Arabic character, let's switch to
right-
Hi Ahmed,
please send us a link to your files on github. I don't know much about
right-to-left problems, but I'd like to take a look.
Your fork is not visible on
https://github.com/dbpedia/extraction-framework/network
I think it should, but I don't know much about github though.
Cheers,
JC
On 2
Fine now, I pushed the changes.
One issue as I figured when I went to the github repo, I opened one of the
files that I've changed "DateTimeParserConfig.scala", I noticed that the
Arabic text is making some trouble there because as you know Arabic is
written from right to left.
Will that make a
I did something wrong, I am using Windows 7 with Intellij IDEA, it's little
confusing, but I am going to try it again.
On 25 March 2013 18:33, Jona Christopher Sahnwaldt wrote:
> Hi Ahmed,
>
> On 25 March 2013 17:44, Ahmed Ktob wrote:
> > Alright, I committed the changes, I hope someone will re
Hi Ahmed,
On 25 March 2013 17:44, Ahmed Ktob wrote:
> Alright, I committed the changes, I hope someone will review them.
It looks like this didn't quite work. I don't see a pull request here:
https://github.com/dbpedia/extraction-framework/pulls
Did you send a pull request? (Step 7 in
https://gi
Alright, I committed the changes, I hope someone will review them.
On 25 March 2013 17:32, Ahmed Ktob wrote:
> Hello Jona,
>
> Thank you so much, I am going to follow the instructions on that link, in
> case I face some problems, I will be back.
>
> On 25 March 2013 17:30, Jona Christopher Sahnw
Hello Jona,
Thank you so much, I am going to follow the instructions on that link, in
case I face some problems, I will be back.
On 25 March 2013 17:30, Jona Christopher Sahnwaldt wrote:
> On 25 March 2013 17:21, Ahmed Ktob wrote:
> > Hello guys,
> >
> > I have made some changes to the followi
On 25 March 2013 17:21, Ahmed Ktob wrote:
> Hello guys,
>
> I have made some changes to the following files (I added the Arabic
> configuration) :
> In the path "main/scala/org.dbpedia.extraction/config/dataparser
>
> DateTimeParserConfig.scala
> DurationParserConfig.scala
> FlagTemplateParserConf
Hello guys,
I have made some changes to the following files (I added the Arabic
configuration) :
In the path "main/scala/org.dbpedia.extraction/config/dataparser
DateTimeParserConfig.scala
DurationParserConfig.scala
FlagTemplateParserConfig.scala
ParserUtilsConfig.scala
In the path "main/scala/
11 matches
Mail list logo
