Bug#375491: patch suggestion

2006-08-23 Thread Ronny Aasen
patch Index: autopartition-lvm === --- autopartition-lvm (revision 40105) +++ autopartition-lvm (working copy) @@ -26,10 +26,50 @@ log-output -t update-dev update-dev fi + # Check if the device already contains any

Bug#375491: patch suggestion

2006-08-23 Thread Ronny Aasen
The basic algorithm looks OK, but you should probably try to use the general functions already available in lvm_tools.sh (part of the partman-lvm package) instead of the direct calls to pvs and vgs. I begin at the end, since that was the easy part. Attached is a patch doing the same, but

Bug#375491: patch suggestion

2006-08-21 Thread Ronny Aasen
Hello I have written a patch that i hope could help on this issue. it can probably be santized, or rewritten in a better way, but it works for me as it looks now. what it does is basicaly. it checks that it's beeing run preseeded, if not it does nothing. if the lvm check finds lvm volumes on

Bug#375491: patch suggestion

2006-08-21 Thread Frans Pop
On Monday 21 August 2006 20:55, Ronny Aasen wrote: I have written a patch that i hope could help on this issue. it can probably be santized, or rewritten in a better way, but it works for me as it looks now. Thanks Ronny. what it does is basicaly. it checks that it's beeing run preseeded,

Bug#375491: patch suggestion

2006-08-21 Thread Ronny Aasen
patch attached instead Ronny Aasen Index: autopartition-lvm === --- autopartition-lvm (revision 40105) +++ autopartition-lvm (working copy) @@ -26,10 +26,42 @@ log-output -t update-dev update-dev fi + # Check if

Bug#375491: patch suggestion

2006-08-21 Thread David Härdeman
On Mon, Aug 21, 2006 at 09:47:59PM +0200, Frans Pop wrote: On Monday 21 August 2006 20:55, Ronny Aasen wrote: if it finds that the vg is isolated to the disk, preseeded to be erased, it removes all Logicalvolumes, and VolumeGroups on that disk. The basic algorithm looks OK, but you should