Bug#286917: [PATCH] fix endless loop in local queries

2010-04-30 Thread Thibaut VARÈNE
Le 29 avr. 10 à 18:36, Thibaut VARÈNE a écrit : I'm pondering cleaning up/rewriting the code. I've spotted a few other problems. If I get around to doing that, maybe I'll step up to maintain the code while I'm there, if that can help. Just for the records, I'm doing it. It's gonna be pretty

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Thibaut VARÈNE
Le 29 avr. 10 à 17:06, Wesley W. Terpstra a écrit : Well, what I mean is that as long as the firewall doesn't have any connections of its own. Which is pretty typical for a firewall, I'd say. Well, depends. The initial submitter had MTA running on his firewall, which is not entirely sill

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Wesley W. Terpstra
On Thu, Apr 29, 2010 at 4:33 PM, Thibaut VARENE wrote: > > 2) Firewall with no local IRC clients: works because ip_conntrack exists > and > > there's no need to check the local TCP connections. > > wrong, see below > Well, what I mean is that as long as the firewall doesn't have any connections

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Joel Yliluoma
On Thu, 29 Apr 2010, Wesley W. Terpstra wrote: Drama aside, I'm glad someone finally figured this out. From what I understand these are the scenarios: 1) End-user system with no IP-forwarding: works because ip_conntrack doesn't exist 2) Firewall with no local IRC clients: works because ip_conntra

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Thibaut VARENE
On Thu, Apr 29, 2010 at 4:24 PM, Wesley W. Terpstra wrote: > Drama aside, I'm glad someone finally figured this out. From what I > understand these are the scenarios: > 1) End-user system with no IP-forwarding: works because ip_conntrack doesn't > exist correct > 2) Firewall with no local IRC cl

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Wesley W. Terpstra
Drama aside, I'm glad someone finally figured this out. From what I understand these are the scenarios: 1) End-user system with no IP-forwarding: works because ip_conntrack doesn't exist 2) Firewall with no local IRC clients: works because ip_conntrack exists and there's no need to check the local

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Joel Yliluoma
On Thu, 29 Apr 2010, Thibaut VARENE wrote: All I require is that any patch to the official version comes from a source that I can trust. So if somebody comes with a fix, that you can understand, but you do not know that person, you will drop the patch? At this point I don't know what to say.

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Thibaut VARENE
On Thu, Apr 29, 2010 at 12:42 PM, Joel Yliluoma wrote: > On Thu, 29 Apr 2010, Thibaut VARENE wrote: > This utility is GPL, and it is stored in a Git repository > anyone can clone; anyone can branch it, or express their > desire to take over. > I am doing the token effort to keep it accessible, ho

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Joel Yliluoma
On Thu, 29 Apr 2010, Thibaut VARENE wrote: > Thank you for the patch though. If I just get a second opinion > (i.e. confirmation from one of you maintainers that this patch > actually works), I will apply it and release version 1.1.4 with > that patch. If you cannot understand that this patch is

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-29 Thread Thibaut VARENE
On Thu, Apr 29, 2010 at 8:23 AM, Joel Yliluoma wrote: > On Thu, 29 Apr 2010, Thibaut VARÈNE wrote: >> >> Using bidentd 1.1.1 (lenny), I have the exact same problem. >> >> Steps to reproduce: install bidentd and an IRC client locally. Connect to >> anyIRC server. >> >> Cause: bidentd code for local

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-28 Thread Joel Yliluoma
On Thu, 29 Apr 2010, Thibaut VARÈNE wrote: Using bidentd 1.1.1 (lenny), I have the exact same problem. Steps to reproduce: install bidentd and an IRC client locally. Connect to any IRC server. Cause: bidentd code for local query is never reached. Fix: see attached patch. I simply moved the l

Bug#286917: [PATCH] fix endless loop in local queries

2010-04-28 Thread Thibaut VARÈNE
Hi, Using bidentd 1.1.1 (lenny), I have the exact same problem. Steps to reproduce: install bidentd and an IRC client locally. Connect to any IRC server. Cause: bidentd code for local query is never reached. Fix: see attached patch. I simply moved the local query code before the forwardin