Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-27 Thread Holger Levsen
Hi, Tom, thanks for your work on this! On Donnerstag, 27. August 2009, Stig Sandbeck Mathisen wrote: Munin and munin-node creates a /var/log/munin directory, perhaps creating /var/log/munin/munin-node-configure.log is a good idea, and send STDOUT and STDERR there? That would be a place I'd

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-27 Thread Tom Feiner
Hi, Could you please review the attached patch? (It's written against the svn rev: 2375). This patch does the following: * It removes the deletion of the TMPFILE that caused all plugins not to be activated, in case one of them raised an error. * It logs the STDOUT and STDERR to

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-26 Thread Tom Feiner
I've been looking at this bug, and from what I can see here's the problem: The command munin-node-configure (supplied by upstream) when executed with the --shell command line option, goes over each available plugin from /usr/share/munin/plugins/ with autoconf as the first parameter, which

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-26 Thread Stig Sandbeck Mathisen
Thanks for a good analysis. It matches my view of the issue. I think the correct place to fix this is in munin-node-configure, or in the surrounding code in the munin-node.postinst script. It (and the plugins) has since been rewritten upstream in a more sane manner to run the plugins with

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-26 Thread Tom Feiner
Hi Stig, Thanks for the quick reply. I'd be happy to write the patch either in the postinst or munin-node-configure. I'll have a look at munin-node-configure from the 1.3 trunk to see how much it has changed to see if it's sensible to try and backport it. (if not we can always do it in the

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-26 Thread Stig Sandbeck Mathisen
Tom Feiner feiner@gmail.com writes: Thanks for the quick reply. I'd be happy to write the patch either in the postinst or munin-node-configure. A patch would be welcome. I'll have a look at munin-node-configure from the 1.3 trunk to see how much it has changed to see if it's sensible to

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-04 Thread janning
Package: munin-node Version: 1.2.6-10~lenny1 Severity: normal $ aptitude install munin-node # Got junk from df_inode: df: `/var/lib/postgresql/8.4/main/base': Permission denied # Got junk from df_inode: Error executing df. Exit code 256 # Got junk from df: df:

Bug#539886: munin-node: maintainer scripts fails to create default set of enabled plugins due to df error

2009-08-04 Thread Holger Levsen
Hi Janning, On Dienstag, 4. August 2009, janning wrote: the error should be handled and the maintainer script should go on to install other plugins at the moment no plugins are installed, just because df fails on one mount point. I agree, thanks for your bug report! regards, Holger