Bug#547223: libvorbis: ov_fopen should have const qualifier for char *path

tags 547223 - wontfix tags 547223 + fixed-upstream thanks Dear Sebastian, On Mon, Mar 29, 2010 at 08:10:10AM +0200, Sebastian Dröge wrote: Hi, adding a const qualifier to a function parameter without changing the handling of the parameter (e.g. copying or not copying it inside the function)

Bug#547223: libvorbis: ov_fopen should have const qualifier for char *path

Hi, adding a const qualifier to a function parameter without changing the handling of the parameter (e.g. copying or not copying it inside the function) is no API breakage. Removing the const qualifier would arguably be an API breakage though. Compilers warn about implicitly removing a const

Bug#547223: libvorbis: ov_fopen should have const qualifier for char *path

tags 547223 + wontfix thanks On Thu, Sep 17, 2009 at 03:11:25PM -0500, Kumar Appaiah wrote: As can clearly be seen, char *path is used merely to open the file f. Since fopen requires only a const char * (it doesn't muck around with the path variable), ov_fopen should also have no business in

Bug#547223: libvorbis: ov_fopen should have const qualifier for char *path

Package: libvorbis Version: 1.2.0.dfsg-6 Severity: minor Tags: upstream, patch Dear libvorbis maintainers, I was looking at the implementation of the ov_fopen function. Currently, the implementation is: int ov_fopen(char *path,OggVorbis_File *vf) { int ret; FILE *f = fopen(path,rb);