Bug#723763: monkeysign should not sign revoked uids

2016-09-01 Thread anarcat
On Thu, Sep 01, 2016 at 11:11:57AM -0400, Antoine Beaupré wrote: > On 2016-08-01 17:53:11, Antoine Beaupré wrote: > > Control: tags -1 +moreinfo > > > > Could you provide unit tests coverage for this and verify that the tests > > pass after the patch is applied? > > Also, after discussing with

Bug#723763: monkeysign should not sign revoked uids

2016-09-01 Thread Antoine Beaupré
On 2016-08-01 17:53:11, Antoine Beaupré wrote: > Control: tags -1 +moreinfo > > Could you provide unit tests coverage for this and verify that the tests > pass after the patch is applied? Also, after discussing with the Geysigning people, it seems that I missed another patch that was already made

Bug#723763: monkeysign should not sign revoked uids

2016-08-07 Thread Antoine Beaupré
On 2016-08-06 17:09:11, Nicholas D Steeves wrote: > Hi Antoine, > > I think by default Monkeysign still signs revoked keys and sends > emails to addresses that might no longer be active. I just ran a > monkeysign 7B75921E, and I think you have received a signed key for a > few of your revoked

Bug#723763: monkeysign should not sign revoked uids

2016-08-06 Thread Nicholas D Steeves
Control: found -1 monkeysign/2.0.2 Hi Antoine, I think by default Monkeysign still signs revoked keys and sends emails to addresses that might no longer be active. I just ran a monkeysign 7B75921E, and I think you have received a signed key for a few of your revoked ones. Cheers, Nicholas

Bug#723763: monkeysign should not sign revoked uids

2016-08-01 Thread Antoine Beaupré
Control: tags -1 +moreinfo Could you provide unit tests coverage for this and verify that the tests pass after the patch is applied? Thanks! -- Never attribute to malice that which can be adequately explained by stupidity, but don't rule out malice. - Albert Einstein

Bug#723763: monkeysign should not sign revoked uids

2016-07-19 Thread Jerome Charaoui
tags patch thanks Please review the attached patches fixing the two issues mentioned in this thread: * Remove revoked uids from keys before processing * Refuse to sign on a revoked primary key Thanks! -- Jerome From a78ebe82bd16f228f1649790f03e0f91e66cbf2c Mon Sep 17 00:00:00 2001 From: Jerome

Bug#723763: monkeysign should not sign revoked uids

2013-10-16 Thread Philip Jägenstedt
On Sat, 2013-10-05 at 16:27 -0400, Antoine Beaupré wrote: On 2013-09-19 12:23:14, Philip Jägenstedt wrote: It looks like monkeysign doesn't care that a uid is revoked, it signs and sends out an email anyway. Could probably be fixed by first cleaning the key. (Also need to check that

Bug#723763: monkeysign should not sign revoked uids

2013-10-16 Thread Antoine Beaupré
On 2013-10-16 15:28:46, Philip Jägenstedt wrote: I looks to me --with-colons will show both revocation of the public keys and uids, e.g. here's my old revoked key: pub:r:1024:17:C8D53F30F42163A4:2006-08-25:::-:Philip Jägenstedt phi...@foolip.org::sca:

Bug#723763: monkeysign should not sign revoked uids

2013-10-16 Thread Philip Jägenstedt
On Wed, 2013-10-16 at 15:44 -0400, Antoine Beaupré wrote: On 2013-10-16 15:28:46, Philip Jägenstedt wrote: I looks to me --with-colons will show both revocation of the public keys and uids, e.g. here's my old revoked key: pub:r:1024:17:C8D53F30F42163A4:2006-08-25:::-:Philip Jägenstedt

Bug#723763: monkeysign should not sign revoked uids

2013-10-16 Thread Antoine Beaupré
On 2013-10-16 15:49:29, Philip Jägenstedt wrote: On Wed, 2013-10-16 at 15:44 -0400, Antoine Beaupré wrote: On 2013-10-16 15:28:46, Philip Jägenstedt wrote: I looks to me --with-colons will show both revocation of the public keys and uids, e.g. here's my old revoked key:

Bug#723763: monkeysign should not sign revoked uids

2013-10-05 Thread Antoine Beaupré
On 2013-09-19 12:23:14, Philip Jägenstedt wrote: It looks like monkeysign doesn't care that a uid is revoked, it signs and sends out an email anyway. Could probably be fixed by first cleaning the key. (Also need to check that monkeysign won't sign a uid where the master key is revoked.)

Bug#723763: monkeysign should not sign revoked uids

2013-09-19 Thread Philip Jägenstedt
Package: monkeysign Version: 1.0 Severity: important It looks like monkeysign doesn't care that a uid is revoked, it signs and sends out an email anyway. Could probably be fixed by first cleaning the key. (Also need to check that monkeysign won't sign a uid where the master key is revoked.) --