Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-19 Thread gregor herrmann
On Tue, 19 Nov 2019 01:15:52 +0100, Guillem Jover wrote: > Hi! Hola! And thanks for looking into this question. > > I've now come up with a first patch (pushed to git) which seems to > > work and which is not terribly slow. > > t/DpkgLists.t still passes and takes ~9 seconds; with the original

Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-18 Thread Guillem Jover
Hi! On Mon, 2019-11-18 at 18:29:36 +0100, gregor herrmann wrote: > On Sun, 17 Nov 2019 21:38:24 +0100, Guillem Jover wrote: > > [M] lib/Debian/DpkgLists.pm > > > > The function _cat_lists() accesses the file list files directly, and > > should be switched to use either «dpkg-query --listfiles»

Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-18 Thread gregor herrmann
On Mon, 18 Nov 2019 23:14:28 +0200, Damyan Ivanov wrote: > > For convenience, here's the current proposal for _cat_lists(): > > > Looks good to me. Thank you for your review! > The speed regression is unfortunate, but I see nothing in the new > implementation that would cause it. (My first

Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-18 Thread Damyan Ivanov
-=| gregor herrmann, 18.11.2019 18:29:36 +0100 |=- > On Sun, 17 Nov 2019 21:38:24 +0100, Guillem Jover wrote: > > > [M] lib/Debian/DpkgLists.pm > > > > The function _cat_lists() accesses the file list files directly, and > > should be switched to use either «dpkg-query --listfiles» instead, or

Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-18 Thread gregor herrmann
On Sun, 17 Nov 2019 21:38:24 +0100, Guillem Jover wrote: > [M] lib/Debian/DpkgLists.pm > > The function _cat_lists() accesses the file list files directly, and > should be switched to use either «dpkg-query --listfiles» instead, or the > dpkg-query db-fsys:Files virtual field with --show.

Bug#944964: dh-make-perl: Module accesses internal dpkg database

2019-11-17 Thread Guillem Jover
Source: dh-make-perl Source-Version: 0.107 Severity: important User: debian-d...@lists.debian.org Usertags: dpkg-db-access-blocker Hi! This package contains a perl module [M], which directly accesses the dpkg internal database. Instead of using one of the public interfaces provided by dpkg.