Bug#994486: cryptsetup-initramfs: include askpass only when needed?

2021-10-03 Thread Guilhem Moulin
On Thu, 16 Sep 2021 at 17:41:17 +0200, Christoph Anton Mitterer wrote: > I think it would be nice if askpass was only included when actually > needed. > > That seems to be the case, when no keyscript is set, and the KEY field is > none, > cause: > […] > Does the attached patch seem reasonable (ha

Bug#994486: cryptsetup-initramfs: include askpass only when needed?

2021-10-02 Thread Guilhem Moulin
On Sun, 03 Oct 2021 at 00:03:17 +0200, Christoph Anton Mitterer wrote: > It's like you say in the other bugs... people cannot rely on non- > documented features, and you're right there - otherwise you could > barely make any changes. We could also rename internal functions, variables, and paths to

Bug#994486: cryptsetup-initramfs: include askpass only when needed?

2021-10-02 Thread Christoph Anton Mitterer
On Sat, 2021-10-02 at 22:39 +0200, Guilhem Moulin wrote: > What does “would be nice” means concretely, is there anything else > than > the slightly smaller initramfs image? Well I guess there are mainly two beneficial points, IMO: 1) The actually saved space. Sure it's not extremely much, but if

Bug#994486: cryptsetup-initramfs: include askpass only when needed?

2021-10-02 Thread Guilhem Moulin
Hi, On Thu, 16 Sep 2021 at 17:41:17 +0200, Christoph Anton Mitterer wrote: > I think it would be nice if askpass was only included when actually > needed. What does “would be nice” means concretely, is there anything else than the slightly smaller initramfs image? Personally I'm not against doin

Bug#994486: cryptsetup-initramfs: include askpass only when needed?

2021-09-16 Thread Christoph Anton Mitterer
Package: cryptsetup-initramfs Version: 2:2.4.0-1 Severity: wishlist Hi. I think it would be nice if askpass was only included when actually needed. That seems to be the case, when no keyscript is set, and the KEY field is none, cause: - if a keyscript is set, either this shall perform reading a