Bug#453161: Patch to fix libpri FTBFS

2007-11-29 Thread Lucas Nussbaum
Hi Libc maintainers, Could you please comment on this issue? Thank you! On 29/11/07 at 00:52 +, brian m. carlson wrote: On Thu, Nov 29, 2007 at 01:48:33AM +0200, Faidon Liambotis wrote: I will upload after confirming that this changing sys/time.h is supposed to be OK (I don't believe it

Bug#453161: Patch to fix libpri FTBFS

2007-11-29 Thread Aurelien Jarno
Lucas Nussbaum a écrit : Hi Libc maintainers, Could you please comment on this issue? As far as I understand, the patch is correct. If you need a header you have to include it and do not assume it is included by another one. This also improves portability among various OS. Aurelien Thank

Bug#453161: Patch to fix libpri FTBFS

2007-11-29 Thread Faidon Liambotis
Aurelien Jarno wrote: As far as I understand, the patch is correct. If you need a header you have to include it and do not assume it is included by another one. This also improves portability among various OS. My concern was that this is breaking various unrelated packages. Lucas said though

Bug#453161: Patch to fix libpri FTBFS

2007-11-29 Thread Aurelien Jarno
Faidon Liambotis a écrit : Aurelien Jarno wrote: As far as I understand, the patch is correct. If you need a header you have to include it and do not assume it is included by another one. This also improves portability among various OS. My concern was that this is breaking various unrelated

Bug#453161: Patch to fix libpri FTBFS

2007-11-28 Thread brian m. carlson
tags 453161 + patch kthxbye Attached is a patch to include stddef.h, since sys/time.h no longer includes it. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 713 440 7475 | http://crustytoothpaste.ath.cx/~bmc | My opinion only a typesetting engine:

Bug#453161: Patch to fix libpri FTBFS

2007-11-28 Thread Faidon Liambotis
brian m. carlson wrote: Attached is a patch to include stddef.h, since sys/time.h no longer includes it. Thanks! Damn, I had that patch but run out of network battery in the airport before testing it :-) I will upload after confirming that this changing sys/time.h is supposed to be OK (I

Bug#453161: Patch to fix libpri FTBFS

2007-11-28 Thread brian m. carlson
On Thu, Nov 29, 2007 at 01:48:33AM +0200, Faidon Liambotis wrote: I will upload after confirming that this changing sys/time.h is supposed to be OK (I don't believe it is, but the maintainers may disagree for a good reason). According to POSIX, headers are not generally allowed to make symbols