Re: [PATCH v2 3/4] dpkg: change pass_admindir to a bool

Hi! On Sat, 2009-10-24 at 18:40:14 -0500, Jonathan Nieder wrote: This is just for clarity. Noticed while preparing to add a similar pass_memlimit option. diff --git a/src/main.c b/src/main.c index 78c34c3..ff09fa0 100644 --- a/src/main.c +++ b/src/main.c @@ -546,7 +546,7 @@ void

Re: [PATCH v2 02/13] libdpkg: Reduce scope of combuf[] in compress_cat

Hi! On Sat, 2009-10-24 at 17:38:57 -0500, Jonathan Nieder wrote: Move the definition of combuf[] closer to its actual usage. This should make it easier to factor out repeated code and saves some stack space in cases where there is no command line argument to compute. I just merged this with

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

Hi! On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: If only C had templates! Without function templates, macros like these two will have to do. This patch refactors the callers for zlib and libbz2 library functions to share some code, in preparation for some small changes

Re: [PATCH v2 04/13] libdpkg: fix redundant compression error messages

Hi! On Sat, 2009-10-24 at 17:41:48 -0500, Jonathan Nieder wrote: Avoid ohshite() except where errno is useful. This should avoid confusing error messages like data: internal gzip error: read: stream error: Success While we're at it, drop the number of bytes read and written from

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: If only C had templates! Without function templates, macros like these two will have to do. This patch refactors the callers for zlib and libbz2 library functions to share some code, in preparation for some small changes that

Re: [PATCH v2 05/13] libdpkg: fix compress_cat to read/write to arbitrary fds

Hi! On Sat, 2009-10-24 at 17:42:52 -0500, Jonathan Nieder wrote: The compress_cat() code had a hidden assumption that fd_in is 0 and fd_out is 1. This is a bug waiting to happen. But luckily, all callers do use those values, so it is harmless. diff --git a/lib/dpkg/compression.c

Re: [PATCH v2 06/13] libdpkg: report read errors during (de)compression

Hi! On Sat, 2009-10-24 at 17:44:25 -0500, Jonathan Nieder wrote: Instead of using the error handling code, failed reads are being treated as end of file. This applies only when using zlib and libbz2. In practice it probably has not caused problems because I/O errors are rare, and often the

Re: [PATCH v2 07/13] libdpkg: compression: do not handle EINTR

Hi! On Sat, 2009-10-24 at 17:45:03 -0500, Jonathan Nieder wrote: The current callers for the compression code do not install signal handlers, so there is no occasion to test the EINTR handling. Perhaps for this reason, since commit 7bf6e0 (add support for using libz, 2000-12-09) when the

Re: [PATCH v2 08/13] libdpkg: check for write errors during decompression

Hi! On Sat, 2009-10-24 at 17:46:16 -0500, Jonathan Nieder wrote: An unnoticed write error is unlikely to cause major problems, since the process on the other end still has a chance to notice the mangled stream. But it is worth fixing, especially because the writing end can give a better

Re: [PATCH v2 09/13] libdpkg: factor out function to execute compressors

Hi! On Sat, 2009-10-24 at 17:47:01 -0500, Jonathan Nieder wrote: gzip, bzip2, and lzma use the same command-line syntax. Factor out a compress_cmd() function that can be used to invoke any one of these commands. diff --git a/lib/dpkg/compression.c b/lib/dpkg/compression.c index

Re: [PATCH v2 10/13] libdpkg: reorder internal fd_fd_filter() function arguments

Hi! On Sat, 2009-10-24 at 17:47:39 -0500, Jonathan Nieder wrote: Put the compression options string last so it can be replaced with printf-style format string. I applied thie one but not for the reason you wanted to use it, but to be able to pass the command arguments to it. thanks, guillem

Re: [PATCH v2 11/13] libdpkg: simplify code to calculate compression options

Hi! On Sat, 2009-10-24 at 17:48:18 -0500, Jonathan Nieder wrote: Rather than making the reader track down the meaning of indices into a fixed-size buffer as it is modified, calculate the compression options all at once. diff --git a/lib/dpkg/compression.c b/lib/dpkg/compression.c index

Re: [PATCH v2 12/13] libdpkg: compression: move each format's code into its own function

Hi! On Sat, 2009-10-24 at 17:48:59 -0500, Jonathan Nieder wrote: Add compress_gzip, decompress_gzip, etc functions with code from compress_cat and decompress_cat. Instead of switch (type) { case compress_type_gzip: #ifdef WITH_ZLIB /* decompress using zlib

Re: [PATCH v2 13/13] libdpkg: compression: check for output errors closing files

Hi! On Sat, 2009-10-24 at 17:49:49 -0500, Jonathan Nieder wrote: A gzclose call has the same potential for errors as a write, since the compressor needs to flush its buffers before closing its output file. The same applies to BZ2_bzclose, but unfortunately libbz2's gzio-style API does not

Re: [PATCH v2 2/2] libdpkg: compress_lzma(): decrease default compression level

Hi! On Sat, 2009-10-24 at 18:05:47 -0500, Jonathan Nieder wrote: Set the default compression level low enough to produce packages that require no more than 10 MiB of memory to decompress, by using the lzma command's default compression level. Signed-off-by: Jonathan Nieder jrnie...@gmail.com

Re: [buildd-tools-devel] Bug#542843: Does not include orig.tar.gz tarball in changes file.

reassign 542843 dpkg-dev thanks Am Dienstag, den 02.02.2010, 17:38 +0100 schrieb Philipp Kern: On Tue, Feb 02, 2010 at 05:23:07PM +0100, Julian Andres Klode wrote: On Sun, Sep 13, 2009 at 11:05:33AM -0400, Andres Mejia wrote: Just tested 'sbuild -As' and couldn't reproduce the problem. The

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

Hi, Guillem Jover wrote: On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: This patch refactors the callers for zlib and libbz2 library functions to share some code, in preparation for some small changes that apply to both. This one I didn't apply, as the code just seems

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

Hi again, On Tue, Feb 02, 2010 at 12:25:55PM +0100, Guillem Jover wrote: On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: + ohshite(_(%s: internal format error: `%s'), desc, errmsg); \ The format string cannot be concatenated this way or xgettext will not see the

Re: [PATCH v2 2/2] libdpkg: compress_lzma(): decrease default compression level

Hi, Guillem Jover wrote: diff --git a/lib/dpkg/compression-backend.c b/lib/dpkg/compression-backend.c index 8f0c055..4b4c9c3 100644 --- a/lib/dpkg/compression-backend.c +++ b/lib/dpkg/compression-backend.c @@ -25,7 +25,7 @@ static const char default_gz_compression = '9'; static const

Re: webkitkde_0.9svn1080813-1_i386.changes REJECTED

Hi all, I got a reject on a webkit upload, ftpmasters suggested I should ask you: On Thursday 28 January 2010 23.01:04 Torsten Werner wrote: [... me pointing out that dpkg-source from lenny worksforme™ ...] but it does not work on ftp-master.debian.org for unknown reasons. You might want to

Bug#568123: Please add gnuspe architecture to dpkg

Package: dpkg Version: 1.15.5.6 Severity: wishlist X-Debbugs-CC: debian-powe...@lists.debian.org The gnuspe port will use powerpc-linux-gnuspe instead of powerpc-linux-gnu. This results in utilisation of the SPU unit which is currently available e500 based CPUs. Is everyone fine with gnuspe ?

Processed: Re: [buildd-tools-devel] Bug#542843: Does not include orig.tar.gz tarball in changes file.

Processing commands for cont...@bugs.debian.org: reassign 542843 dpkg-dev Bug #542843 [sbuild] Does not include orig.tar.gz tarball in changes file. Bug reassigned from package 'sbuild' to 'dpkg-dev'. Bug No longer marked as found in versions sbuild/0.59.0-1. thanks Stopping processing here.