Bug#609153: lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages

Niels Thykier writes: > I have attached a proposed rewording. Since other similar tags also > appeared affected I have included the change in those tags as well. Looks good to me. -- Russ Allbery (r...@debian.org) -- To UNSUBSCRIBE, email to de

Bug#513663: [general] need infrastructure to check related packages

Niels Thykier writes: > On 2011-01-06 20:18, Russ Allbery wrote: >> As long as we have some way of marking some collections as transient >> and some collections to be retained, and then provide some way of >> overriding that, that sounds fine. I much prefer talking about >> everything as collect

Minor coding and commit style things

A couple of quick notes on recent commits: * Lintian's coding style is all over the map and different in different files, so there isn't much to stay consistent with, and I don't think the exact details of the coding style matter. So take this just as a personal preference, and feel free to

Bug#513663: [general] need infrastructure to check related packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-01-06 20:18, Russ Allbery wrote: > Niels Thykier writes: > >> Speaking of unpacking; as I understand it we once had an "unpack-level >> 2" which has now been removed in favour of collection. I am considering >> to remove the "unpack-level

[SCM] Debian package checker branch, infra-513663, updated. 2.4.3-123-g2d5f371

The following commit has been merged in the infra-513663 branch: commit 2d5f3715ae36487c2169a587140cd47cd315769f Author: Niels Thykier Date: Fri Jan 7 00:21:25 2011 +0100 Refactored the "load collection" code into a sub. diff --git a/frontend/lintian b/frontend/lintian index 5abea3c..07dde

[SCM] Debian package checker branch, infra-513663, updated. 2.4.3-123-g2d5f371

The following commit has been merged in the infra-513663 branch: commit 778975f94e3dd5030802e8c2a945c8d742cf130b Author: Niels Thykier Date: Thu Jan 6 23:42:50 2011 +0100 Move set_value down to the test of the subs. diff --git a/frontend/lintian b/frontend/lintian index 71bfc8f..5abea3c 10

[SCM] Debian package checker branch, infra-513663, updated. 2.4.3-123-g2d5f371

The following commit has been merged in the infra-513663 branch: commit b4e3a997fffe889fe4d0bce25c6b681b52e865c1 Author: Niels Thykier Date: Thu Jan 6 22:13:47 2011 +0100 Made the "remove" case appear earlier in the big "PACKAGE: foreach" loop. This may help simply other parts. diff -

[SCM] Debian package checker branch, infra-513663, updated. 2.4.3-123-g2d5f371

The following commit has been merged in the infra-513663 branch: commit feef9a73e4522bdb56b374b5a43cd69cfe54b1e1 Author: Niels Thykier Date: Thu Jan 6 22:13:41 2011 +0100 delete_lab_entry should always succeed if the entry has already been deleted. diff --git a/lib/Lab/Package.pm b/lib/La

[SCM] Debian package checker branch, infra-513663, updated. 2.4.3-123-g2d5f371

The following commit has been merged in the infra-513663 branch: commit f8bb33e154a8443c0234ed9c7499314f6378077f Author: Niels Thykier Date: Thu Jan 6 17:15:47 2011 +0100 Reorder some code so check if a collection script be run is not scattered around. diff --git a/frontend/lintian b/f

Bug#609153: lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 tags 609153 + patch thanks On 2011-01-06 21:37, Axel Beckert wrote: > Package: lintian > Version: 2.4.3 > Severity: minor > > When checking a "3.0 (native)" source package which contains a .git > directory, lintian explains: > > W: hobbit-plugins

Processed: Re: Bug#609153: lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages

Processing commands for cont...@bugs.debian.org: > tags 609153 + patch Bug #609153 [lintian] lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 609153:

Bug#609153: lintian: Explanation for diff-contains-git-control-dir gives wrong advise for native packages

Package: lintian Version: 2.4.3 Severity: minor When checking a "3.0 (native)" source package which contains a .git directory, lintian explains: W: hobbit-plugins source: diff-contains-git-control-dir .git N: N:The Debian diff or native package contains files in a .git directory. N:These

Bug#513663: [general] need infrastructure to check related packages

Niels Thykier writes: > Speaking of unpacking; as I understand it we once had an "unpack-level > 2" which has now been removed in favour of collection. I am considering > to remove the "unpack-level 1" as well and move everything to collection > as a part of this. > I feel the unpack code mak

Bug#513663: [general] need infrastructure to check related packages

Niels Thykier wrote: > Speaking of unpacking; as I understand it we once had an "unpack-level > 2" which has now been removed in favour of collection. I am considering > to remove the "unpack-level 1" as well and move everything to collection > as a part of this. The frontend needs a couple of t

Re: Spelling error with no single correct

Russ Allbery wrote: > While I agree with this message that idiomatic English would call for > different phrasing in a lot of places, I think correcting "allows to" to > "allows one to" would be acceptable, if not ideal, phrasing in every > example given there. This one was on my ToDo list and had

Bug#513663: [general] need infrastructure to check related packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-01-06 18:27, Russ Allbery wrote: > Niels Thykier writes: > [...] >> That is, if I run: > >> lintian A.deb B.deb A-data.deb B-data.deb > >> should lintian then do A + A-data and then B + B-data or just in >> "whatever" order it feels like?

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

Niels Thykier writes: > I rechecked the code and it is not a problem. Email::Valid does indeed > reject these names, but it is currently only applied to check the > part. The names are still checked by the old > "home-made" regex approach. > Nevertheless I have added a name containing full sto

Bug#513663: [general] need infrastructure to check related packages

Niels Thykier writes: > Really? Judging from Lintian::Schedule I would say it is partly > enforcing this regardless of the output order of dpkg-genchanges > # for each package (the sort is to make sure that source packages are > # before the corresponding binary packages--this has the advantage

Re: Spelling error with no single correct

Niels Thykier writes: > For those of you who have not seen it, there was filed a bug against > Lintian in Ubuntu requesting Lintian to catch the misspelling "allows > to"[1]. > Unfortunately, there do not seem to be an "always correct" > replacement[2]. I have attached a patch that uses [correc

Re: Lintian man pages in pod

Niels Thykier writes: > Done. I made some changes to the script so it tries to highlight paths, > and substitutes a few html tags (which were already used in the desc > files). It also does manpage link substitution: > Text => I > Text => B > Text => I > Text(N) => L > I am n

Bug#602192: marked as done (Ignore hyphens in mdoc .Bd -literal blocks)

Your message dated Thu, 6 Jan 2011 14:07:02 +0200 with message-id <20110106120701.ga4...@straylight.ringlet.net> and subject line Re: Bug#602192: Ignore hyphens in mdoc .Bd -literal blocks has caused the Debian Bug report #602192, regarding Ignore hyphens in mdoc .Bd -literal blocks to be marked as

Spelling error with no single correct

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey For those of you who have not seen it, there was filed a bug against Lintian in Ubuntu requesting Lintian to catch the misspelling "allows to"[1]. Unfortunately, there do not seem to be an "always correct" replacement[2]. I have attached a pat

Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-01-06 01:01, Russ Allbery wrote: > Niels Thykier writes: > >> I am considering to just make the switch to use Email::Valid. I have >> attached a patch that makes the switch and introduces a regression test >> to catch the particular issue i

[SCM] Debian package checker branch, master, updated. 2.4.3-114-g022c1ee

The following commit has been merged in the master branch: commit 022c1eea2fdadd751e1aca534924902e01fb3589 Author: Niels Thykier Date: Thu Jan 6 11:39:09 2011 +0100 Extended fields-uploaders with a valid email. diff --git a/t/tests/fields-uploaders/debian/debian/control.in b/t/tests/field

Re: Lintian man pages in pod

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-01-06 01:04, Russ Allbery wrote: > Niels Thykier writes: > >> [...] >> Do you think this would work, or would it be better just to keep this >> information static in the pod file and manually update it? > > I vote for this -- please go ahe

[SCM] Debian package checker branch, master, updated. 2.4.3-113-ga91c08e

The following commit has been merged in the master branch: commit a91c08e4c7fe63f466ac1b4a08bafc9d5b0cbbdc Author: Niels Thykier Date: Thu Jan 6 10:58:15 2011 +0100 Rewrote manpages in pod. Parts of lintian(1) is now generated from the desc files in collection/ and checks/ . diff --git

[SCM] Debian package checker branch, master, updated. 2.4.3-113-ga91c08e

The following commit has been merged in the master branch: commit bc57f46ca5f29f029dd3b9c011cd21575395cdb0 Author: Niels Thykier Date: Thu Jan 6 10:50:55 2011 +0100 Added or updated the "Info" field in various collections and checks as a prelude to auto-generating the lintian pod file f

Bug#513663: [general] need infrastructure to check related packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2011-01-06 01:15, Russ Allbery wrote: > Niels Thykier writes: > >> I have had a look at this nearly 2 year old bug and I think it would be >> great if we could find a solution for cross-package checks. To make it >> even better I am interested i