Hello
I did review the package, here are my comments
- i did compare usbguard-0.7.0 tag from upstream github with
upstream/0.7.0+ds1 from your repo
- Why did you remove NOTES.md, doc/usbguard-vs-udev.md, and ROADMAP.md?, they
look useful.
- in your git repo there should be a tags with the d
Hi gustavo,
On 07/22/2017 08:43 AM, gustavo panizzo wrote:
> Hello
>
> I did review the package, here are my comments
>
> - i did compare usbguard-0.7.0 tag from upstream github with
> upstream/0.7.0+ds1 from your repo
>
> - Why did you remove NOTES.md, doc/usbguard-vs-udev.md, and
> ROADMAP.
Hi,
On 07/16/2017 05:28 PM, gustavo panizzo wrote:
>> [...]
>> but i've removed those files from the archive for now, patched the
>> relevant testscripts and created a bug report to create the testdata
>> from source [0]
> cool, excelent
> please add a target gen-orig-xz (or gz, or bz2) to d/rules
On Mon, Jul 10, 2017 at 03:52:12PM +0200, Muri Nicanor wrote:
On 06/29/2017 05:35 PM, gustavo panizzo wrote:
Hello, apologies for the late response
no worries, as you can see i'm not very fast myself
oke, so...
On 06/18/2017 11:23 AM, gustavo panizzo wrote:
d/copyright
- please set the yea
i've uploaded another version that removes an unused build-dependency
signature.asc
Description: OpenPGP digital signature
On 06/29/2017 05:35 PM, gustavo panizzo wrote:
> Hello, apologies for the late response
no worries, as you can see i'm not very fast myself
oke, so...
On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> d/copyright
>
> - please set the years to include 2016, 2017. there are some files owned
> by R
Hello, apologies for the late response
On Sun, Jun 25, 2017 at 07:49:51PM +0200, Muri Nicanor wrote:
Hi,
On 06/18/2017 11:23 AM, gustavo panizzo wrote:
- src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
what's the source of that file? please regenerate them at build time
Hi,
On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> - src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
> what's the source of that file? please regenerate them at build time
i'm not sure how to deal with this- the 0001.bin is a copy of a binary
USB Descriptor of one of ups
On Wed, May 24, 2017 at 07:43:35PM +0200, Muri Nicanor wrote:
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "usbguard"
d/copyright
- please set the years to include 2016, 2017. there are some files owned
by RH which are copyright 201
Hi
I'll review the package this weekend
On June 14, 2017 6:51:06 PM GMT+08:00, Muri Nicanor wrote:
>control: tags -1 - moreinfo
>
>hi,
>
>On 06/01/2017 12:07 PM, gustavo panizzo wrote:
>> the package builds fine with pbuilder but tests fails when i try to
>> build using sbuild.
>>
>> FAIL UseCa
control: tags -1 - moreinfo
hi,
On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
>
> FAIL UseCase/001_cli_policy.sh (exit status: 1)
this fails if there is already a running usbguard instance- when i
stoppe
Hi,
On 06/01/2017 11:54 AM, gustavo panizzo wrote:
> Hello
>
> On Wed, May 24, 2017 at 07:43:35PM +0200, Muri Nicanor wrote:
>
>> * New upstream version 0.7.0
>>This release contains a backwards incompatible
>>change because it changes how the device hash is
>>computed for Linux roo
hi,
On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
thanks for the pointer, i totally missed that only using pbuilder. now i
also have a working sbuild sc
On June 1, 2017 6:13:06 PM GMT+08:00, Andrey Rahmatullin
wrote:
>> UseCase/002_cli_devices.sh.log: SKIP UseCase/002_cli_devices.sh
>(exit status: 77)
>No, it's a bad idea to do things requiring root during tests,
>especially
>modprobe/rmmod
Maybe those tests can be run using autopkgtests
I'
On Thu, Jun 01, 2017 at 06:07:40PM +0800, gustavo panizzo wrote:
> some tests are skipped, i feel they should run
>
>
> perhaps usbguard should build-depend on sudo?
>
> UseCase/002_cli_devices.sh.log: + sudo -n dd bs=4096 count=1 if=/dev/zero
> of=/tmp/usbguard_disk
> UseCase/002_cli_devices.
control: owner -1 !
control: tags -1 moreinfo
the package builds fine with pbuilder but tests fails when i try to
build using sbuild.
FAIL UseCase/001_cli_policy.sh (exit status: 1)
some tests are skipped, i feel they should run
perhaps usbguard should build-depend on sudo?
UseCase/002_cli_d
Hello
On Wed, May 24, 2017 at 07:43:35PM +0200, Muri Nicanor wrote:
* New upstream version 0.7.0
This release contains a backwards incompatible
change because it changes how the device hash is
computed for Linux root hub devices
How is it handled for users that already have a config
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "usbguard"
* Package name: usbguard
Version : 0.7.0-1
Upstream Author : Daniel Kopeček
* Url : https://dkopecek.github.io/usbguard/
* Licenses: CC-BY-SA-3.0,
18 matches
Mail list logo
