Bug#646095: Usage of "private" symbol

2011-10-22 Thread Yves-Alexis Perez
On ven., 2011-10-21 at 23:01 +0200, Yves-Alexis Perez wrote: > Anyway, let's see the upstream call on that. https://bugs.launchpad.net/midori/+bug/799603/comments/16 and I'm not knowledgeable enough to remove the guard and the “else” part. One thing I can do is add a versioned build-dep for futur

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Yves-Alexis Perez
On ven., 2011-10-21 at 22:38 +0200, Julien Cristau wrote: > That code should be killed, not > #if !WEBKIT_CHECK_VERSION (1, 4, 3) I've asked on upstream bug about that, but I'm not sure it's that trivial nor really important. That code has been present and working in multiple midori versions alre

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Julien Cristau
On Fri, Oct 21, 2011 at 22:24:18 +0200, Yves-Alexis Perez wrote: > On ven., 2011-10-21 at 22:17 +0200, Julien Cristau wrote: > > At the very least the new webkit will need to declare Breaks on midori > > (<< 0.4.1-2) or something like that. And midori needs to get fixed up, > > by the sound of it

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Yves-Alexis Perez
On ven., 2011-10-21 at 22:17 +0200, Julien Cristau wrote: > At the very least the new webkit will need to declare Breaks on midori > (<< 0.4.1-2) or something like that. And midori needs to get fixed up, > by the sound of it. midori has a guard for this, see https://bugs.launchpad.net/midori/+b

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Julien Cristau
On Fri, Oct 21, 2011 at 14:22:00 -0200, Gustavo Noronha Silva wrote: > On Fri, 2011-10-21 at 18:09 +0200, Philipp Kern wrote: > > On Fri, Oct 21, 2011 at 01:57:42PM -0200, Gustavo Noronha Silva wrote: > > > This is caused by midori using a symbol that was only exported for being > > > used in the

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Gustavo Noronha Silva
On Fri, 2011-10-21 at 18:09 +0200, Philipp Kern wrote: > On Fri, Oct 21, 2011 at 01:57:42PM -0200, Gustavo Noronha Silva wrote: > > This is caused by midori using a symbol that was only exported for being > > used in the test runner. I can't see how a rebuild would fix it, are you > > sure it did?

Re: Bug#646095: Usage of "private" symbol

2011-10-21 Thread Philipp Kern
On Fri, Oct 21, 2011 at 01:57:42PM -0200, Gustavo Noronha Silva wrote: > This is caused by midori using a symbol that was only exported for being > used in the test runner. I can't see how a rebuild would fix it, are you > sure it did? This means that you just introduced an ABI break and are oblig

Bug#646095: Usage of "private" symbol

2011-10-21 Thread Gustavo Noronha Silva
Hey, This is caused by midori using a symbol that was only exported for being used in the test runner. I can't see how a rebuild would fix it, are you sure it did? It was removed here: http://trac.webkit.org/changeset/88621 I can add a work-around to webkit if required, but I'd prefer to have mi