Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package gpodder

Dear Release Managers,

Recently YouTube started requiring connections via HTTPS.  There isn't a
Debian bug filed for this, but upstream contacted me directly to ask
whether this could be addressed for buster.  The upstream issue is:

   https://github.com/gpodder/gpodder/issues/625

And the patch PR:

   https://github.com/gpodder/gpodder/pull/626

I know it's late, but I am filing the unblock with the rationale that
the broken YouTube support will be seen as regression for our users.
Also, the patch is simple.

I have validated the change locally and the debdiff is attached.

Thank you for your consideration!
tony

unblock gpodder/3.10.7-2
diff -Nru gpodder-3.10.7/debian/changelog gpodder-3.10.7/debian/changelog
--- gpodder-3.10.7/debian/changelog     2019-02-02 15:17:35.000000000 -0800
+++ gpodder-3.10.7/debian/changelog     2019-06-11 17:37:34.000000000 -0700
@@ -1,3 +1,9 @@
+gpodder (3.10.7-2) unstable; urgency=medium
+
+  * Add patch to use HTTPS for HTTPS URLs, including YouTube.
+
+ -- tony mancill <tmanc...@debian.org>  Tue, 11 Jun 2019 17:37:34 -0700
+
 gpodder (3.10.7-1) unstable; urgency=medium
 
   * New upstream version 3.10.7
diff -Nru gpodder-3.10.7/debian/patches/series 
gpodder-3.10.7/debian/patches/series
--- gpodder-3.10.7/debian/patches/series        2019-02-02 15:17:35.000000000 
-0800
+++ gpodder-3.10.7/debian/patches/series        2019-06-11 17:37:34.000000000 
-0700
@@ -2,3 +2,4 @@
 utf-8_coding_for_setup.patch
 remove_copyright_character.patch
 switch-appindicator-extension-to-AyatanaAppIndicator-and-python3.patch
+youtube_https.patch
diff -Nru gpodder-3.10.7/debian/patches/youtube_https.patch 
gpodder-3.10.7/debian/patches/youtube_https.patch
--- gpodder-3.10.7/debian/patches/youtube_https.patch   1969-12-31 
16:00:00.000000000 -0800
+++ gpodder-3.10.7/debian/patches/youtube_https.patch   2019-06-11 
17:37:34.000000000 -0700
@@ -0,0 +1,47 @@
+Description: Fix YouTube URLs
+Source: 
https://patch-diff.githubusercontent.com/raw/gpodder/gpodder/pull/626.patch
+Forwarded: not-needed
+
+---
+ src/gpodder/util.py | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/gpodder/util.py b/src/gpodder/util.py
+index 7103bd7a3..3fd717fe9 100644
+--- a/src/gpodder/util.py
++++ b/src/gpodder/util.py
+@@ -1402,7 +1402,10 @@ def format_seconds_to_hour_min_sec(seconds):
+ 
+ def http_request(url, method='HEAD'):
+     (scheme, netloc, path, parms, qry, fragid) = urllib.parse.urlparse(url)
+-    conn = http.client.HTTPConnection(netloc)
++    if scheme == 'https':
++        conn = http.client.HTTPSConnection(netloc)
++    else:
++        conn = http.client.HTTPConnection(netloc)
+     start = len(scheme) + len('://') + len(netloc)
+     conn.request(method, url[start:])
+     return conn.getresponse()
+
+From deebcf8cecb46e4a47ea0a4bb4269d5e2f2c6e9a Mon Sep 17 00:00:00 2001
+From: auouymous <auouym...@users.noreply.github.com>
+Date: Sat, 25 May 2019 15:22:27 +0200
+Subject: [PATCH 2/2] Use https to download from YouTube
+
+---
+ src/gpodder/youtube.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gpodder/youtube.py b/src/gpodder/youtube.py
+index c3e593209..2c87647a9 100644
+--- a/src/gpodder/youtube.py
++++ b/src/gpodder/youtube.py
+@@ -116,7 +116,7 @@ def get_real_download_url(url, preferred_fmt_ids=None):
+     vid = get_youtube_id(url)
+     if vid is not None:
+         page = None
+-        url = 
'http://www.youtube.com/get_video_info?&el=detailpage&video_id=' + vid
++        url = 
'https://www.youtube.com/get_video_info?&el=detailpage&video_id=' + vid
+ 
+         while page is None:
+             req = util.http_request(url, method='GET')

Attachment: signature.asc
Description: PGP signature

Reply via email to