Re: DD ping [Brutespray]

2020-04-26 Thread Samuel Henrique
Hello Stéphane, > I followed your recommendations and modified the control file. It's cleaner > that way. > (Sorry for the last two commits, it's ugly, I should have been careful and > pushed this in one go) Don't worry, I believe the work we do on Debian is the best way to learn real world git

Re: DD ping [Brutespray]

2020-04-26 Thread Stéphane Neveu
Hello Samuel, > > Upstream was kind enough to push another release 1.6.8 so I wasn't sure > if I had to keep version 1.6.7 in the changelog file. > > I finally decided to update the above fields for version 1.6.8, but I'm > not sure so tell me if I was wrong. > > You did the right thing, we only

Re: DD ping [Brutespray]

2020-04-26 Thread Samuel Henrique
Hello Stéphane, > Upstream was kind enough to push another release 1.6.8 so I wasn't sure if I > had to keep version 1.6.7 in the changelog file. > I finally decided to update the above fields for version 1.6.8, but I'm not > sure so tell me if I was wrong. You did the right thing, we only need

Re: DD ping [Brutespray]

2020-04-26 Thread Stéphane Neveu
Hello Samuel, Your changes are fine, but there are two issues now: > 1) I believe you forgot to update d/changelog with the new changes, > you need to add: > * Bump to standards-version version 4.5.0 > * Add Rules-Requires-Root: no > * Update Uploaders field to match changelog > > Sorry abou

Re: DD ping [Brutespray]

2020-04-23 Thread Samuel Henrique
Hello Stéphane, Your changes are fine, but there are two issues now: 1) I believe you forgot to update d/changelog with the new changes, you need to add: * Bump to standards-version version 4.5.0 * Add Rules-Requires-Root: no * Update Uploaders field to match changelog 2) If I understood co

Re: DD ping [Brutespray]

2020-04-23 Thread Stéphane Neveu
Hello Samuel, > > > > 2) "P: brutespray source: rules-requires-root-missing" Lintian is > > > complaining about this[0], I know it's pedantic but it's nice to have, > > > tell me if you have questions on how to address it. > > > > Thanks, If you could show me how to use diffoscope properly, to mak

Re: DD ping [Brutespray]

2020-04-22 Thread Samuel Henrique
Hello Stéphane, > > 2) "P: brutespray source: rules-requires-root-missing" Lintian is > > complaining about this[0], I know it's pedantic but it's nice to have, > > tell me if you have questions on how to address it. > > Thanks, If you could show me how to use diffoscope properly, to make > sure e

Re: DD ping [Brutespray]

2020-04-22 Thread Stéphane Neveu
Hi Samuel, > I removed some cruft from the changelog and then noticed an issue, so > can you take a look at the following? > > 1) Your name in d/control is not matching what is in d/changelog, you > should fix that and Lintian should not complain about: "brutespray > source: changelog-should-menti

Re: DD ping [Brutespray]

2020-04-21 Thread Samuel Henrique
Hello Stéphane, > I've made a new release of brutespray (debian/1.6.7-1 ). > Could you please review it ? I removed some cruft from the changelog and then noticed an issue, so can you take a look at the following? 1) Your name in d/control is not matching what is in d/changelog, you should fix t

DD ping [Brutespray]

2020-04-21 Thread Stéphane Neveu
Hi team! I've made a new release of brutespray (debian/1.6.7-1 ). Could you please review it ? https://salsa.debian.org/pkg-security-team/brutespray Thanks ! Stéphane