Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-14 Thread Sven Geuer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thanks a lot for uploading, Samuel! On Sunday, 13.01.2019, 23:36 + Samuel Henrique wrote: > Hello Everyone, > > Finally got some free time to review the package, I think everything > is ok, > I just did some little changes on d/copyright. > >

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-13 Thread Samuel Henrique
Hello Everyone, Finally got some free time to review the package, I think everything is ok, I just did some little changes on d/copyright. Thank you everybody who helped review and test the package, and Sven for the packaging :) Uploaded. -- Samuel Henrique

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-10 Thread Sven Geuer
Hello Team, a small fix to my previous post: > I managed to run autopkgtest through ssh to a Virtualbox VM. > > Steps: > > Set up an minimal VM by selecting ssh server from debian installer > with > user testbed and password xx where testbed is capable to sudo. > > Copy your local ~/.ssh/i

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-10 Thread Sven Geuer
Hello Team, I managed to run autopkgtest through ssh to a Virtualbox VM. Steps: Set up an minimal VM by selecting ssh server from debian installer with user testbed and password xx where testbed is capable to sudo. Copy your local ~/.ssh/id_rsa.pub to /home/testbed/.ssh/authorizes_keys on t

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-09 Thread Aleksey Kravchenko
Hello, 1. I've found that version 2.0.1.f was released at rocky.eld.leidenuniv.nl [1], and later was imported into github. Although GitHub has autogenerated a tarball for the tag 2.0.1f, its release notes has the url [1] of the correct tarball. The pristine-tar tarball checksum match the checksum

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-09 Thread Sven Geuer
Hello Aleksey, Hello team, > I've reviewed a bit more: > [x] arno-iptables-firewall_2.0.3-1.dsc builds cleanly with pbuilder > [x] the package correctly builds twice by debuild within the source > tree > > I found strange thing. The content match, but checksum doesn't match > for > the previous r

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-09 Thread Aleksey Kravchenko
Hello team, I've reviewed a bit more: [x] arno-iptables-firewall_2.0.3-1.dsc builds cleanly with pbuilder [x] the package correctly builds twice by debuild within the source tree I found strange thing. The content match, but checksum doesn't match for the previous release tarball: $ pristine-tar

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-08 Thread Sven Geuer
Hi Samuel, I removed pre-squeeze upgrade code Regarding your change 'Bump DH level to 12' I believe debian/control needs further changes. The debhelper manpage says: Changes from v11 are: [...] This change makes dh_installinit inject a misc:Pre-Depends for init-system-he

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-08 Thread Sven Geuer
Hi Samuel, > Do you think these people could test the version in experimental? As > far as > I currently reviewed it looks like the only problem which may hit us > is on > upgrades of the package, I mean, I want to make sure that an upgrade > of the > package will not break any configuration file

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-07 Thread Samuel Henrique
Hello Sven, are there still chances to get this into buster? > Yes, we still have plenty of time, the full freeze is only on 2019-03-12, as you can see here[0]. It is better if we manage to upload to unstable before the soft freeze though, which I think will definitely happen. So we regarding Bus

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-07 Thread Sven Geuer
Hello everybody, are there still chances to get this into buster? Is there anybody who can help reviewing this package? I know there are people waiting for an updated/upgraded version in buster. Sven Am Mittwoch, den 02.01.2019, 01:01 + schrieb Samuel Henrique: > Hello Sven, > > I starte

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Aleksey Kravchenko
Hello, quote on RFS bugs from [1]: After you uploaded a package, please close the bug report by sending a mail > to nnn-d...@bugs.debian.org. *Do not close RFS bugs in debian/changelog.* [1] https://mentors.debian.net/sponsor/rfs-howto Best wishes, Aleksey

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Sven Geuer
Hi Team, one question, is it appropriate to close the RFS-Bug [1] by means of debian/changelog via * New maintainer. (Closes: #886951, #915718) ? [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915718 Sven

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Sven Geuer
Thank you so much, Raphael. Am Mittwoch, den 02.01.2019, 15:44 +0100 schrieb Raphael Hertzog: > Hi, > > On Mon, 31 Dec 2018, Sven Geuer wrote: > > Regarding joining the group I seem to miss the obvious. I didn't > > see > > how to do so on [2]. Please advice. > > I have added you to the team (th

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Sven Geuer
Hello Samuel, thanks a lot for uploading! Hello Aleksey, find my replies inline below. Am Mittwoch, den 02.01.2019, 17:01 +0300 schrieb Aleksey Kravchenko: > Hello Sven, > > You should now switch the Vcs-* fields to the new repository > https://salsa.debian.org/pkg-security-team/arno-iptables-

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Raphael Hertzog
Hi, On Mon, 31 Dec 2018, Sven Geuer wrote: > Regarding joining the group I seem to miss the obvious. I didn't see > how to do so on [2]. Please advice. I have added you to the team (there's no button to request to join, you have to ask here, I just clarified this on the wiki page). Cheers, -- R

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-02 Thread Aleksey Kravchenko
Hello Sven, You should now switch the Vcs-* fields to the new repository https://salsa.debian.org/pkg-security-team/arno-iptables-firewall I beleave you should drop ~rc4 suffix after the package version (2.0.3-1). Now, for reviewing you use git commits, instead of uploading ~rc* packages to mento

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2019-01-01 Thread Samuel Henrique
Hello Sven, I started looking at the package, but as there are a lot of changes in there, it will take some time until I can review and confirm that all of them are ok and we are close to the freeze. That's why I decided to upload the package to experimental for now, so it's also easier for other

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2018-12-31 Thread Samuel Henrique
Hello Sven, I created the repo on https://salsa.debian.org/pkg-security-team/arno-iptables-firewall and gave temporary permission for your account so you can work there until you are on the salsa team. I don't think I can add you on the salsa team, Raphaƫl or Gianfranco can confirm that, also, the

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2018-12-31 Thread Sven Geuer
Hello Aleksey, Hello Team, I logged in to salsa.debian.org, created a repo for the package and pushed everything I have, including latest updates [1]. Please review and upload so that this package can go into buster. Regarding joining the group I seem to miss the obvious. I didn't see how to do

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2018-12-30 Thread Aleksey Kravchenko
Hello Sven. On 29.12.2018 22:14, Sven Geuer wrote: > I'd like to ask for a repository for arno-iptables-firewall under > https://salsa.debian.org/pkg-security-team. I would then upload the > version 2.0.1.f-1.1 currently in unstable and buster followed by my > packaged 2.0.3-1 so that changes are

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2018-12-29 Thread Sven Geuer
Hello team, I'd like to ask for a repository for arno-iptables-firewall under https://salsa.debian.org/pkg-security-team. I would then upload the version 2.0.1.f-1.1 currently in unstable and buster followed by my packaged 2.0.3-1 so that changes are easy to spot. Looking forward to reveiving yo

RFS: arno-iptables-firewall/2.0.3-1 [ITA]

2018-12-22 Thread Sven Geuer
Hello team, I intent to adopt the orphaned package arno-iptables-firewall ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915718). Marcos proposed to maintain this package from within the pkg-security team and I would love to follow his suggestion. Having read https://wiki.debian.org/Teams/